Solidifier\EventSubscribers\HTML

Complexity

Total Complexity

8

Size/Duplication

Total Lines	69
Duplicated Lines	11.59 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	setReportFilename()	0	6	1
A	getSubscribedEvents()	8	8	1
A	setCurrentFile()	0	6	1
A	onDefect()	0	10	2
A	formatMessage()	0	8	1
A	postMortemReport()	0	6	1

<?php

namespace Solidifier\EventSubscribers;


use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Solidifier\Events\TraverseEnd;
use Solidifier\Events\ChangeFile;
use Solidifier\Defect;
use Solidifier\Reporters\HTMLReporter;

class HTML implements EventSubscriberInterface
{
    const
        DEFAULT_REPORT_FILENAME = 'report.html';
    
    private
        $defects,

It is generally advisable to only define one property per statement.

The visibility should be declared for property $defects.

        $reporter,
        $reportFilename,
        $currentFile;
    
    public function __construct(HTMLReporter $reporter)
    {
        $this->defects = array();

Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space

        $this->reporter = $reporter;

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

        $this->reportFilename = self::DEFAULT_REPORT_FILENAME;
        $this->currentFile = null;

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

    }
    
    public function setReportFilename($filename)
    {
        $this->reportFilename = $filename;
        
        return $this;
    }
    
    public static function getSubscribedEvents()

This method seems to be duplicated in your project.

    {
        return array(
            Defect::EVENT_NAME => array('onDefect'),
            TraverseEnd::EVENT_NAME => array('postMortemReport'),
            ChangeFile::EVENT_NAME => array('setCurrentFile'),
        );
    }
    
    public function setCurrentFile(ChangeFile $event)
    {
        $this->currentFile = $event->getCurrentFile();

        return $this;
    }    
    
    public function onDefect(Defect $event)
    {
        if(! isset($this->defects[$this->currentFile]))
        {
            $this->defects[$this->currentFile] = array();
        }
        
        $event->formattedMessage = $this->formatMessage($event->getMessage());

The property formattedMessage does not seem to exist in Solidifier\Defect.

Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space

        $this->defects[$this->currentFile][] = $event;
    }
    
    private function formatMessage($message)
    {
        return strtr($message, array(
            'id>' => 'strong>',
            'type>' => 'strong>',
            'method>' => 'strong>',
        ));
    }
    
    public function postMortemReport(TraverseEnd $event)

The parameter $event is not used and could be removed.

    {
        $this->reporter
            ->render($this->defects)
            ->save($this->reportFilename);
    }
}