Solidifier\EventSubscribers\Console

Complexity

Total Complexity

8

Size/Duplication

Total Lines	67
Duplicated Lines	11.94 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getSubscribedEvents()	8	8	1
A	__construct()	0	6	1
A	setOutput()	0	6	1
A	setCurrentFile()	0	6	1
A	onDefect()	0	11	1
A	formatMessage()	0	8	1
A	postMortemReport()	0	8	2

<?php

namespace Solidifier\EventSubscribers;

use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\Console\Output\NullOutput;
use Symfony\Component\Console\Output\OutputInterface;
use Solidifier\Events\TraverseEnd;
use Solidifier\Events\ChangeFile;
use Solidifier\Defect;

class Console implements EventSubscriberInterface
{
    private
        $counter,

It is generally advisable to only define one property per statement.

The visibility should be declared for property $counter.

        $currentFile,
        $output;
    
    public static function getSubscribedEvents()

This method seems to be duplicated in your project.

    {
        return array(
            Defect::EVENT_NAME => array('onDefect'),
            TraverseEnd::EVENT_NAME => array('postMortemReport'),
            ChangeFile::EVENT_NAME => array('setCurrentFile'),
        );
    }

    public function __construct()
    {
        $this->output = new NullOutput();

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

        $this->currentFile = null;
        $this->counter = 0;

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

    }
    
    public function setOutput(OutputInterface $output)
    {
        $this->output = $output;
        
        return $this;
    }
    
    public function setCurrentFile(ChangeFile $event)
    {
        $this->currentFile = $event->getCurrentFile();

        return $this;
    }    
    
    public function onDefect(Defect $event)
    {
        $this->output->writeln(sprintf(
            "<fg=white;options=bold>%s @ l%d</fg=white;options=bold> : %s",
            $this->currentFile,
            $event->getLine(),
            $this->formatMessage($event->getMessage())
        ));
        
        $this->counter++;
    }
    
    private function formatMessage($message)
    {
        return strtr($message, array(
            'id>' => 'comment>',
            'type>' => 'info>',
            'method>' => 'info>',
        ));
    }
    
    public function postMortemReport(TraverseEnd $event)

The parameter $event is not used and could be removed.

    {
        $this->output->writeln(sprintf(
            '<comment>%d defect%s found</comment>',
            $this->counter,
            $this->counter > 0 ? 's' : ''
        ));    
    }
}