Solidifier\Defects\PublicAttribute

Complexity

Total Complexity

2

Size/Duplication

Total Lines	24
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	7	1
A	getMessage()	9	9	1

<?php

namespace Solidifier\Defects;

use Solidifier\Defect;
use Solidifier\Visitors\ObjectType;
use PhpParser\Node\Stmt\Property;

class PublicAttribute extends Defect

This class seems to be duplicated in your project.

{
    private
        $objectType,

It is generally advisable to only define one property per statement.

The visibility should be declared for property $objectType.

        $property;
        
    public function __construct(ObjectType $objectType, $property, Property $node)
    {
        parent::__construct($node);

        $this->objectType = $objectType;    
        $this->property = $property;    

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

    }    
    
    public function getMessage()
    {
        return sprintf(
            'Public property <id>%s</id> in %s <type>%s</type>',
            $this->property,
            $this->objectType->type,
            $this->objectType->fullname
        );
    }
}