Solidifier\Defects\DependencyUponImplementation

Complexity

Total Complexity

2

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	getMessage()	0	10	1

<?php

namespace Solidifier\Defects;

use Solidifier\Defect;
use PhpParser\Node;

class DependencyUponImplementation extends Defect
{
    private
        $parameterTypeName,

It is generally advisable to only define one property per statement.

The visibility should be declared for property $parameterTypeName.

        $parameterType,
        $method;
    
    public function __construct(Node $node, $parameterTypeName, $parameterType, $method)
    {
        parent::__construct($node);
        
        $this->parameterTypeName = $parameterTypeName;
        $this->parameterType = $parameterType;

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

        $this->method = $method;

Equals sign not aligned with surrounding assignments; expected 12 spaces but found 1 space

    }
    
    public function getMessage()
    {
        return sprintf(
            'Parameter <id>%s</id> is typed as %s <type>%s</type> (instead of using an interface) in method <method>%s()</method>',
            $this->node->name,

Accessing name on the interface PhpParser\Node suggest that you code against a concrete implementation. How about adding an instanceof check?

            $this->parameterType,
            $this->parameterTypeName,
            $this->method
        );
    }    
}