Completed
Push — fix-unused-variables ( 9f6b94 )
by Nicolas
36:14 queued 32:12
created
src/Karma/Command/Diff.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         $table->enableFormattingTags()
46 46
             ->setHeaders(array($environment1, $environment2))
47 47
             ->displayKeys()
48
-            ->setValueRenderingFunction(function($value){
48
+            ->setValueRenderingFunction(function($value) {
49 49
                 return $this->formatValue($value);
50 50
             });
51 51
 
Please login to merge, or discard this patch.
src/Karma/Configuration/AbstractReader.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 
41 41
     public function setDefaultEnvironment($environment)
42 42
     {
43
-        if(! empty($environment) && is_string($environment))
43
+        if( ! empty($environment) && is_string($environment))
44 44
         {
45 45
             $this->defaultEnvironment = $environment;
46 46
         }
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 
89 89
     private function handleCustomData($value)
90 90
     {
91
-        if(! is_string($value))
91
+        if( ! is_string($value))
92 92
         {
93 93
             return $value;
94 94
         }
Please login to merge, or discard this patch.
src/Karma/Configuration/FilterInputVariable.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
     {
9 9
         if(is_array($value))
10 10
         {
11
-            return array_map(function ($item) {
11
+            return array_map(function($item) {
12 12
                 return $this->filterOneValue($item);
13 13
             }, $value);
14 14
         }
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 
19 19
     private function filterOneValue($value)
20 20
     {
21
-        if(! is_string($value))
21
+        if( ! is_string($value))
22 22
         {
23 23
             return $value;
24 24
         }
Please login to merge, or discard this patch.
src/Karma/Configuration/InMemoryReader.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 
43 43
     public function getAllVariables()
44 44
     {
45
-        $variables = array_map(function($key){
45
+        $variables = array_map(function($key) {
46 46
             return $this->extractVariableName($key);
47 47
         }, array_keys($this->values));
48 48
 
Please login to merge, or discard this patch.
src/Karma/Configuration/Parser.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 
50 50
     public function enableIncludeSupport()
51 51
     {
52
-        if(! isset($this->parsers[self::INCLUDES]))
52
+        if( ! isset($this->parsers[self::INCLUDES]))
53 53
         {
54 54
             $this->parsers[self::INCLUDES] = new IncludeParser();
55 55
         }
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 
60 60
     public function enableExternalSupport()
61 61
     {
62
-        if(! isset($this->parsers[self::EXTERNALS]))
62
+        if( ! isset($this->parsers[self::EXTERNALS]))
63 63
         {
64 64
             $this->parsers[self::EXTERNALS] = new ExternalParser(new Parser($this->fs));
65 65
         }
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
     public function enableGroupSupport()
71 71
     {
72
-        if(! isset($this->parsers[self::GROUPS]))
72
+        if( ! isset($this->parsers[self::GROUPS]))
73 73
         {
74 74
             $this->parsers[self::GROUPS] = new GroupParser();
75 75
         }
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
     {
102 102
         $files = array($masterFilePath);
103 103
 
104
-        while(! empty($files))
104
+        while( ! empty($files))
105 105
         {
106 106
             foreach($files as $file)
107 107
             {
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 
152 152
     private function extractLines($filePath)
153 153
     {
154
-        if(! $this->fs->has($filePath))
154
+        if( ! $this->fs->has($filePath))
155 155
         {
156 156
             throw new \RuntimeException("$filePath does not exist");
157 157
         }
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
 
202 202
     private function switchSectionParser($sectionName)
203 203
     {
204
-        if(! isset($this->parsers[$sectionName]))
204
+        if( ! isset($this->parsers[$sectionName]))
205 205
         {
206 206
             throw new \RuntimeException('Unknown section name ' . $sectionName);
207 207
         }
Please login to merge, or discard this patch.
src/Karma/Configuration/Parser/GroupParser.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 
105 105
     private function hasDuplicatedValues(array $values)
106 106
     {
107
-        $duplicatedValues = array_filter(array_count_values($values), function ($counter) {
107
+        $duplicatedValues = array_filter(array_count_values($values), function($counter) {
108 108
             return $counter !== 1;
109 109
         });
110 110
 
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 
151 151
         $errors = array_intersect($allEnvironments, array_keys($this->groups));
152 152
 
153
-        if(! empty($errors))
153
+        if( ! empty($errors))
154 154
         {
155 155
             throw new \RuntimeException(sprintf(
156 156
                'Error : a group can not be part of another group (%s)',
Please login to merge, or discard this patch.
src/Karma/Configuration/Parser/IncludeParser.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
     private function checkFilenameIsValid($filename)
28 28
     {
29
-        if(! preg_match('~.*\.conf$~', $filename))
29
+        if( ! preg_match('~.*\.conf$~', $filename))
30 30
         {
31 31
             $this->triggerError("$filename is not a valid file name", 'Invalid dependency');
32 32
         }
Please login to merge, or discard this patch.
src/Karma/Configuration/Reader.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         $this->variables = $variables;
26 26
 
27 27
         $this->externalReader = null;
28
-        if(! empty($externalVariables))
28
+        if( ! empty($externalVariables))
29 29
         {
30 30
             $this->externalReader = new Reader($externalVariables, array(), $groups);
31 31
         }
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 
59 59
         if(in_array($environment, $this->groupNames))
60 60
         {
61
-            if(! isset($this->defaultEnvironmentsForGroups[$environment]))
61
+            if( ! isset($this->defaultEnvironmentsForGroups[$environment]))
62 62
             {
63 63
                 throw new \RuntimeException(sprintf(
64 64
                    'Group can not be used as environment (try with group %s detected)',
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 
102 102
     private function accessVariable($variableName)
103 103
     {
104
-        if(! array_key_exists($variableName, $this->variables))
104
+        if( ! array_key_exists($variableName, $this->variables))
105 105
         {
106 106
             throw new \RuntimeException(sprintf(
107 107
                 'Unknown variable %s',
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 
129 129
     private function processExternal($variable, $environment)
130 130
     {
131
-        if(! $this->externalReader instanceof Reader)
131
+        if( ! $this->externalReader instanceof Reader)
132 132
         {
133 133
             throw new \RuntimeException(sprintf(
134 134
                 'There is no external variables. %s can not be resolve for environment %s',
Please login to merge, or discard this patch.
src/Karma/Display/CliTable.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
         $lines = array();
68 68
         $lines[] = $separatorRow;
69 69
 
70
-        if(! empty($this->headers))
70
+        if( ! empty($this->headers))
71 71
         {
72 72
             $lines[] = $this->renderLine($this->headers);
73 73
             $lines[] = $separatorRow;
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
             return;
91 91
         }
92 92
 
93
-        if(! empty($this->headers))
93
+        if( ! empty($this->headers))
94 94
         {
95 95
             array_unshift($this->headers, '');
96 96
         }
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 
109 109
         $this->columnsSize = array_pad(array(), $this->nbColumns, -1);
110 110
 
111
-        if(! empty($this->headers))
111
+        if( ! empty($this->headers))
112 112
         {
113 113
             $this->updateColumnsSize(array($this->headers));
114 114
         }
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
     {
133 133
         foreach($newValues as $row)
134 134
         {
135
-            if(! is_array($row))
135
+            if( ! is_array($row))
136 136
             {
137 137
                 throw new \InvalidArgumentException('Rows must be arrays');
138 138
             }
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 
183 183
     private function stripTags($value)
184 184
     {
185
-        return preg_replace ('/<[^>]*>/', '', $value);
185
+        return preg_replace('/<[^>]*>/', '', $value);
186 186
     }
187 187
 
188 188
     private function renderLine(array $row)
Please login to merge, or discard this patch.