IncludeParser::checkFilenameIsValid() - Code Metrics - Inspection of "bump to php 7.4 and phpunit 9" - Niktux/karma - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — nln-php7 ( 311875...6680df )

by Nicolas

created 2020-09-14 10:18 UTC

IncludeParser::checkFilenameIsValid() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php

declare(strict_types = 1);

namespace Karma\Configuration\Parser;

class IncludeParser extends AbstractSectionParser
{
    private array

        $files;

    public function __construct()
    {
        parent::__construct();

        $this->files = [];
    }

    protected function parseLine(string $line): void
    {
        $this->checkFilenameIsValid($line);

        $this->files[] = $line;
    }

    private function checkFilenameIsValid(string $filename): void
    {
        if(! preg_match('~.*\.conf$~', $filename))
        {
            $this->triggerError("$filename is not a valid file name", 'Invalid dependency');
        }
    }

    public function getCollectedFiles(): array
    {
        return $this->files;
    }
}


1		<?php
2
3		declare(strict_types = 1);
4
5		namespace Karma\Configuration\Parser;
6
7		class IncludeParser extends AbstractSectionParser
8		{
9		private array
		0 ignored issues – show Bug introduced 2020-09-14 10:29 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_ARRAY, expecting T_FUNCTION or T_CONST Loading history...
10		$files;
11
12	280	public function __construct()
13		{
14	280	parent::__construct();
15
16	280	$this->files = [];
17	280	}
18
19	211	protected function parseLine(string $line): void
20		{
21	211	$this->checkFilenameIsValid($line);
22
23	210	$this->files[] = $line;
24	210	}
25
26	211	private function checkFilenameIsValid(string $filename): void
27		{
28	211	if(! preg_match('~.*\.conf$~', $filename))
29		{
30	1	$this->triggerError("$filename is not a valid file name", 'Invalid dependency');
31		}
32	210	}
33
34	248	public function getCollectedFiles(): array
35		{
36	248	return $this->files;
37		}
38		}
39

Niktux / karma

Push — nln-php7 ( 311875...6680df )

IncludeParser::checkFilenameIsValid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like