ExternalParser::parseLine() - Code Metrics - Inspection of "draft" - Niktux/karma - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 57-formatter-per-extension ( 73b3c8 )

by Nicolas

created 2015-12-04 15:31 UTC

ExternalParser::parseLine() A

↳ Parent: ExternalParser

Complexity

Conditions	3
Paths	3

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	21
rs	9.3143
cc	3
eloc	11
nc	3
nop	1

<?php

namespace Karma\Configuration\Parser;

use Karma\Configuration\Parser;

class ExternalParser extends AbstractSectionParser
{
    private
        $parser,

        $variables,
        $filesStatus;
    
    public function __construct(Parser $parser)
    {
        parent::__construct();

        $this->parser = $parser;
        $this->variables = array();
        $this->filesStatus = array();
    }
    
    public function parseLine($line)
    {
        if($this->isACommentLine($line))
        {
            return true;
        }
                
        $file = trim($line);
        
        $found = false;
        if($this->parser->getFileSystem()->has($file))
        {
            $found = true;
            $this->variables = $this->parser->parse($file);
        }
        
        $this->filesStatus[$file] = array(
            'found' => $found,
            'referencedFrom' => $this->currentFilePath,
        );
    }
    
    public function getExternalVariables()
    {
        return $this->variables;
    }
    
    public function getExternalFilesStatus()
    {
        return $this->filesStatus;
    }
}

1			<?php
2
3			namespace Karma\Configuration\Parser;
4
5			use Karma\Configuration\Parser;
6
7			class ExternalParser extends AbstractSectionParser
8			{
9			private
10			$parser,
			0 ignored issues – show Coding Style introduced 2015-12-04 15:18 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history...
11			$variables,
12			$filesStatus;
13
14			public function __construct(Parser $parser)
15			{
16			parent::__construct();
17
18			$this->parser = $parser;
19			$this->variables = array();
20			$this->filesStatus = array();
21			}
22
23			public function parseLine($line)
24			{
25			if($this->isACommentLine($line))
26			{
27			return true;
28			}
29
30			$file = trim($line);
31
32			$found = false;
33			if($this->parser->getFileSystem()->has($file))
34			{
35			$found = true;
36			$this->variables = $this->parser->parse($file);
37			}
38
39			$this->filesStatus[$file] = array(
40			'found' => $found,
41			'referencedFrom' => $this->currentFilePath,
42			);
43			}
44
45			public function getExternalVariables()
46			{
47			return $this->variables;
48			}
49
50			public function getExternalFilesStatus()
51			{
52			return $this->filesStatus;
53			}
54			}

Niktux / karma

Push — 57-formatter-per-extension ( 73b3c8 )

ExternalParser::parseLine() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like