Validator::validate() - Code Metrics - Inspection of "Add support for custom formats + uuid format" - Nicofuma/SwaggerBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8)

by Tristan

created 2016-09-12 09:19 UTC

Validator::validate() A

↳ Parent: Validator

Complexity

Conditions	4
Paths	3

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	6
cts	6
cp	1
rs	9.2
c	0
b	0
f	0
cc	4
eloc	6
nc	3
nop	1
crap	4

<?php

namespace Nicofuma\SwaggerBundle\Validator;

use FR3D\SwaggerAssertions\PhpUnit\SymfonyAssertsTrait;
use FR3D\SwaggerAssertions\SchemaManager;
use JsonSchema\Constraints\Factory;
use Symfony\Component\HttpFoundation\Request;

class Validator
{
    use SymfonyAssertsTrait;

    /** @var SchemaManager */
    private $schemaManager;

    /** @var bool */
    private $strict;

    /** @var Factory */
    private $constraintsFactory;

    public function __construct(Factory $constraintsFactory, SchemaManager $schemaManager, $strict)
    {
        $this->schemaManager = $schemaManager;
        $this->strict = $strict;
        $this->constraintsFactory = $constraintsFactory;
    }

    public function validate(Request $request)
    {
        try {
            $this->assertRequestMatch($request, $this->schemaManager);
        } catch (\RuntimeException $e) {
            if ($this->strict || $e->getMessage() !== 'Request URI does not match with any swagger path definition') {
                throw $e;
            }
        }
    }

    /**
     * @return SchemaManager
     */
    public function getSchemaManager()
    {
        return $this->schemaManager;
    }

    /**
     * {@inheritdoc}
     */
    protected function getValidator()
    {
        return new \JsonSchema\Validator($this->constraintsFactory);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		namespace Nicofuma\SwaggerBundle\Validator;
4
5		use FR3D\SwaggerAssertions\PhpUnit\SymfonyAssertsTrait;
6		use FR3D\SwaggerAssertions\SchemaManager;
7		use JsonSchema\Constraints\Factory;
8		use Symfony\Component\HttpFoundation\Request;
9
10		class Validator
11		{
12		use SymfonyAssertsTrait;
13
14		/** @var SchemaManager */
15		private $schemaManager;
16
17		/** @var bool */
18		private $strict;
19
20		/** @var Factory */
21		private $constraintsFactory;
22
23	4	public function __construct(Factory $constraintsFactory, SchemaManager $schemaManager, $strict)
24		{
25	4	$this->schemaManager = $schemaManager;
26	4	$this->strict = $strict;
27	4	$this->constraintsFactory = $constraintsFactory;
28	4	}
29
30	4	public function validate(Request $request)
31		{
32		try {
33	4	$this->assertRequestMatch($request, $this->schemaManager);
34	4	} catch (\RuntimeException $e) {
35	3	if ($this->strict \|\| $e->getMessage() !== 'Request URI does not match with any swagger path definition') {
36	2	throw $e;
37		}
38		}
39	2	}
40
41		/**
42		* @return SchemaManager
43		*/
44		public function getSchemaManager()
45		{
46		return $this->schemaManager;
47		}
48
49		/**
50		* {@inheritdoc}
51		*/
52	2	protected function getValidator()
53		{
54	2	return new \JsonSchema\Validator($this->constraintsFactory);
		0 ignored issues – show Documentation introduced 2016-09-12 09:28 UTC by Report Bug Copy Issue Report `$this->constraintsFactory` is of type `object<JsonSchema\Constraints\Factory>`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
55		}
56		}
57

Nicofuma / SwaggerBundle

Pull Request — master (#8)

Validator::validate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like