Nicklas\Comment\Modules\Question

Complexity

Total Complexity

8

Size/Duplication

Total Lines	123
Duplicated Lines	8.94 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

52.5%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getQuestions()	0	23	3
A	getQuestion()	0	18	1
A	getPopularTags()	0	17	2
A	controlAuthority()	11	11	2

<?php

namespace Nicklas\Comment\Modules;

/**
 * A database driven model.
 */
class Question extends ActiveRecordModelExtender
{

        /**
     * @var string $tableName name of the database table.
     */
    protected $tableName = "ramverk1_questions";

    /**
     * Columns in the table.
     *
     * @var integer $id primary key auto incremented.
     */
    public $id;
    public $user;

    public $title;
    public $tags;

    public $created;
    public $status; # default is active


    /**
     * Returns post with markdown and gravatar
     * @param string $sql
     * @param array $param

There is no parameter named $param. Did you maybe mean $params?

     *
     * @return array
     */
    public function getQuestions($sql = null, $params = null)
    {
        if ($sql == null) {

It seems like you are loosely comparing $sql of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            $questions = $this->findAll();
        }
        if ($sql != null) {

It seems like you are loosely comparing $sql of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            $questions = $this->findAllWhere("$sql", $params);
        }

        return array_map(function ($question) {

            // Find users email
            $user = new User($this->db);
            $user->find("name", $question->user);

            // Start setting attributes
            $question->img = $this->gravatar($user->email);
            $question->title = $this->getMD($question->title);
            $question->tags = explode(',', $question->tags);

            return $question;
        }, $questions);

The variable $questions does not seem to be defined for all execution paths leading up to this point.

    }

    /**
    * Returns one question with it's own question text and other answers
    * @param int $id
    *
     * @return object
    */
    public function getQuestion($id)
    {
        $question = $this->find("id", $id);

        // Add attributes from Post class
        $post = new Post($this->db);

        $question->question = $post->getPost("questionId = ? AND type = ?", [$question->id, "question"]);
        $question->answers = $post->getAllPosts("questionId = ? AND type = ?", [$question->id, "answer"]);
        $question->answersCount = count($question->answers);

        // Start setting up own attributes
        $question->title = $this->getMD($question->title);
        $question->tags = explode(',', $question->tags);


        return $question;
    }

    /**
     * Returns array of tags, keys are name, value is the integer of how many.
     *
     * @return array
    */
    public function getPopularTags()
    {
        $question = $this->findAll();

        $tagsMultiArray = array_map(function ($question) {
            return explode(',', $question->tags);
        }, $question);

        // Merge multi array, count values, sort high to low
        $tagArr = array_count_values(call_user_func_array("array_merge", $tagsMultiArray));
        arsort($tagArr);

        if (array_key_exists('', $tagArr)) {
            unset($tagArr[""]);
        }
        return $tagArr;
    }




    /**
     * Check if a post belongs to user
     *
     *
     * @return boolean
     */
    public function controlAuthority($name)

This method seems to be duplicated in your project.

    {
        $user = new User($this->db);
        $user->find("name", $name);

        // IF AUTHORITY == admin, then continue
        if ($user->authority != "admin") {
            return ($user->name == $this->user);
        }
        return true;
    }
}