CreateUserForm::__construct() - Code Metrics - Inspection of "Better file structure for HTMLforms | added reset..." - Nicklas766/Comment - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 48da91...4d2acf )

by Nicklas

created 2017-10-15 14:02 UTC

CreateUserForm::__construct() A

↳ Parent: CreateUserForm

Complexity

Conditions	1
Paths	1

Size

Total Lines	55
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	55
rs	9.7692
c	0
b	0
f	0
cc	1
eloc	37
nc	1
nop	1

How to fix Long Method

<?php

namespace Nicklas\Comment\HTMLForm\User;

use \Anax\HTMLForm\FormModel;
use \Anax\DI\DIInterface;
use \Nicklas\Comment\Modules\User;

/**
 * Example of FormModel implementation.
 */
class CreateUserForm extends FormModel
{
    /**
     * Constructor injects with DI container.
     *
     * @param Anax\DI\DIInterface $di a service container
     */
    public function __construct(DIInterface $di)
    {
        parent::__construct($di);
        $this->form->create(
            [
                "id" => __CLASS__,
                "br-after-label" => false,
                "use_fieldset" => false,
                "class" => "login-widget",
            ],
            [
                "name" => [
                    "type"        => "text",
                    "validation" => ["not_empty"],
                    "placeholder" => "name",
                    "label" => false,
                ],

                "email" => [
                    "type"        => "text",
                    "placeholder" => "email",
                    "label" => false,
                ],
                "question" => [
                    "type"        => "text",
                    "placeholder" => "Din favoriträtt",
                    "validation" => ["not_empty"],
                    "label" => false,
                ],

                "password" => [
                    "type"        => "password",
                    "validation" => ["not_empty"],
                    "placeholder" => "password",
                    "label" => false
                ],

                "password-again" => [
                    "type"        => "password",
                    "validation" => [
                        "match" => "password"
                    ],
                    "placeholder" => "password",
                    "label" => false
                ],

                "submit" => [
                    "label" => false,
                    "type" => "submit",
                    "value" => "Create user",
                    "callback" => [$this, "callbackSubmit"]
                ],
            ]
        );
    }



    /**
     * Callback for submit-button which should return true if it could
     * carry out its work and false if something failed.
     *
     * @return boolean true if okey, false if something went wrong.
     */
    public function callbackSubmit()
    {
        // Get values from the submitted form
        $name       = $this->form->value("name");
        $email       = $this->form->value("email");
        $question       = $this->form->value("question");
        $password      = $this->form->value("password");
        $passwordAgain = $this->form->value("password-again");

        // Check password matches
        if ($password !== $passwordAgain) {
            $this->form->rememberValues();
            $this->form->addOutput("Password did not match.");
            return false;
        }

        if (strpos($name, '%') !== false) {
            $this->form->addOutput("% is not allowed");
            return false;
        }

         $user = new User();
         $user->setDb($this->di->get("db"));

        if ($user->userExists($name)) {
             $this->form->addOutput("User already exists");
             return false;
        }

          $user->name = $name;
          $user->email = $email;
          $user->question = $question;
          $user->setPassword($password);
          $user->save();

          $this->di->get('session')->set("user", $name); # set user in session
          $this->di->get("response")->redirect("user/profile");
    }
}


1			<?php
2
3			namespace Nicklas\Comment\HTMLForm\User;
4
5			use \Anax\HTMLForm\FormModel;
6			use \Anax\DI\DIInterface;
7			use \Nicklas\Comment\Modules\User;
8
9			/**
10			* Example of FormModel implementation.
11			*/
12			class CreateUserForm extends FormModel
13			{
14			/**
15			* Constructor injects with DI container.
16			*
17			* @param Anax\DI\DIInterface $di a service container
18			*/
19			public function __construct(DIInterface $di)
20			{
21			parent::__construct($di);
22			$this->form->create(
23			[
24			"id" => __CLASS__,
25			"br-after-label" => false,
26			"use_fieldset" => false,
27			"class" => "login-widget",
28			],
29			[
30			"name" => [
31			"type" => "text",
32			"validation" => ["not_empty"],
33			"placeholder" => "name",
34			"label" => false,
35			],
36
37			"email" => [
38			"type" => "text",
39			"placeholder" => "email",
40			"label" => false,
41			],
42			"question" => [
43			"type" => "text",
44			"placeholder" => "Din favoriträtt",
45			"validation" => ["not_empty"],
46			"label" => false,
47			],
48
49			"password" => [
50			"type" => "password",
51			"validation" => ["not_empty"],
52			"placeholder" => "password",
53			"label" => false
54			],
55
56			"password-again" => [
57			"type" => "password",
58			"validation" => [
59			"match" => "password"
60			],
61			"placeholder" => "password",
62			"label" => false
63			],
64
65			"submit" => [
66			"label" => false,
67			"type" => "submit",
68			"value" => "Create user",
69			"callback" => [$this, "callbackSubmit"]
70			],
71			]
72			);
73			}
74
75
76
77			/**
78			* Callback for submit-button which should return true if it could
79			* carry out its work and false if something failed.
80			*
81			* @return boolean true if okey, false if something went wrong.
82			*/
83			public function callbackSubmit()
84			{
85			// Get values from the submitted form
86			$name = $this->form->value("name");
87			$email = $this->form->value("email");
88			$question = $this->form->value("question");
89			$password = $this->form->value("password");
90			$passwordAgain = $this->form->value("password-again");
91
92			// Check password matches
93			if ($password !== $passwordAgain) {
94			$this->form->rememberValues();
95			$this->form->addOutput("Password did not match.");
96			return false;
97			}
98
99			if (strpos($name, '%') !== false) {
100			$this->form->addOutput("% is not allowed");
101			return false;
102			}
103
104			$user = new User();
105			$user->setDb($this->di->get("db"));
106
107			if ($user->userExists($name)) {
108			$this->form->addOutput("User already exists");
109			return false;
110			}
111
112			$user->name = $name;
113			$user->email = $email;
114			$user->question = $question;
115			$user->setPassword($password);
116			$user->save();
117
118			$this->di->get('session')->set("user", $name); # set user in session
119			$this->di->get("response")->redirect("user/profile");
120			}
121			}
122

Nicklas766 / Comment

Push — master ( 48da91...4d2acf )

CreateUserForm::__construct() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like