Comment::getPost() - Code Metrics - Inspection of "New modules structure, build will fail, this needs..." - Nicklas766/Comment - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 7e1229...8260e2 )

by Nicklas

created 2017-10-18 07:59 UTC

Comment::getPost() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	23
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	23
ccs	13
cts	13
cp	1
rs	9.0856
c	0
b	0
f	0
cc	2
eloc	12
nc	2
nop	1
crap	2

<?php

namespace Nicklas\Comment\Modules;

/**
 * A database driven model.
 */
class Comment extends ActiveRecordModelExtender
{

        /**
     * @var string $tableName name of the database table.
     */
    protected $tableName = "ramverk1_comments";

    /**
     * Columns in the table.
     *
     * @var integer $id primary key auto incremented.
     */
    public $id;
    public $type; # question/answer/comment
    public $parentId; # All posts have different ids

    public $title;
    public $tags;
    public $text;

    public $created;

    public $di;


    /**
     * Constructor injects with DI container.
     *
     */
    public function __construct($di = null)
    {
        $this->di = $di;
    }
    /**
     * Returns post with markdown and gravatar
     * @param string $sql
     * @param array $param
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return array
     */
    public function getComments($sql, $params)
    {
        $posts = $this->findAllWhere("$sql", $params);

        return array_map(function ($post) {
            $user = new User();
            $user->setDb($this->di->get("db"));
            $user->find("name", $post->user);


            $post->comments = $this->getPosts("parentId = ? AND type = ?", [$post->id, "comment"]);

            $post->tags = explode(',', $post->tags);

            $post->img = $this->gravatar($user->email);
            $post->markdown = $this->getMD($post->text);

            return $post;
        }, $posts);
    }
}


1		<?php
2
3		namespace Nicklas\Comment\Modules;
4
5		/**
6		* A database driven model.
7		*/
8		class Comment extends ActiveRecordModelExtender
9		{
10
11		/**
12		* @var string $tableName name of the database table.
13		*/
14		protected $tableName = "ramverk1_comments";
15
16		/**
17		* Columns in the table.
18		*
19		* @var integer $id primary key auto incremented.
20		*/
21		public $id;
22		public $type; # question/answer/comment
23		public $parentId; # All posts have different ids
24
25		public $title;
26		public $tags;
27		public $text;
28
29		public $created;
30
31		public $di;
32
33
34		/**
35		* Constructor injects with DI container.
36		*
37		*/
38		public function __construct($di = null)
39		{
40		$this->di = $di;
41		}
42		/**
43		* Returns post with markdown and gravatar
44		* @param string $sql
45		* @param array $param
		0 ignored issues – show Documentation introduced 2017-10-15 11:21 UTC by Report Bug Copy Issue Report There is no parameter named `$param`. Did you maybe mean `$params`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
46		*
47	5	* @return array
48		*/
49	5	public function getComments($sql, $params)
50	5	{
51		$posts = $this->findAllWhere("$sql", $params);
52
53		return array_map(function ($post) {
54		$user = new User();
55		$user->setDb($this->di->get("db"));
56		$user->find("name", $post->user);
57
58	4
59		$post->comments = $this->getPosts("parentId = ? AND type = ?", [$post->id, "comment"]);
		0 ignored issues – show Bug introduced 2017-10-18 08:02 UTC by Report Bug Copy Issue Report The method `getPosts()` does not seem to exist on `object<Nicklas\Comment\Modules\Comment>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
60	4	$post->tags = explode(',', $post->tags);
61
62	4	$post->img = $this->gravatar($user->email);
63	4	$post->markdown = $this->getMD($post->text);
64	4
65	4	return $post;
66		}, $posts);
67		}
68		}
69

Nicklas766 / Comment

Push — master ( 7e1229...8260e2 )

Comment::getPost() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like