Post - Code Metrics - Inspection of "New modules structure, build will fail, this needs..." - Nicklas766/Comment - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 7e1229...8260e2 )

by Nicklas

created 2017-10-18 07:59 UTC

Post A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	107
Duplicated Lines	11.21 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	3
dl	12
loc	107
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getAllPosts()	0	23	1
A	getPost()	0	18	1
A	controlAuthority()	12	12	2

How to fix Duplicated Code

<?php

namespace Nicklas\Comment\Modules;

/**
 * A database driven model.
 */
class Post extends ActiveRecordModelExtender
{

        /**
     * @var string $tableName name of the database table.
     */
    protected $tableName = "ramverk1_posts";

    /**
     * Columns in the table.
     *
     * @var integer $id primary key auto incremented.
     */
    public $id;
    public $user;
    public $questionId; # Connection to new Question()

    public $type; # question/answer
    public $text;

    public $created;

    public $di;


    /**
     * Constructor injects with DI container.
     *
     */
    public function __construct($di = null)
    {
        $this->di = $di;
    }
    /**
     * Returns post with markdown and gravatar
     * @param string $sql
     * @param array $param
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return array
     */
    public function getAllPosts($sql, $params)
    {
        $posts = $this->findAllWhere("$sql", $params);

        return array_map(function ($post) {

            // Get e-mail for Post
            $user = new User();
            $user->setDb($this->di->get("db"));
            $user->find("name", $post->user);
            $post->img = $this->gravatar($user->email);

            // Get comments for Post
            $comment = new Comment();
            $comment->setDb($this->di->get("db"));
            $post->comments = $comment->getComments("parentId = ?", [$post->id]);

            // Get text
            $post->markdown = $this->getMD($post->text);

            return $post;
        }, $posts);
    }

    /**
     * return question/answer, three attributes are set, comments connected to them is an array.
     *
     * @return object
    */
    public function getPost($sql, $params)
    {
        $post = $this->findWhere("$sql", $params);


        // Get e-mail for question
        $user = new User();
        $user->setDb($this->di->get("db"));
        $user->find("name", $post->user);
        $post->img = $this->gravatar($user->email);

        // Start setting attributes
        $post->img = $this->gravatar($user->email);
        $post->markdown = $this->getMD($post->text);
        $post->comments = $comment->getComments("parentId = ?", [$post->id]);


        return $post;
    }

    /**
     * Check if a post belongs to user
     *
     *
     * @return boolean
     */
    public function controlAuthority($name)

    {
        $user = new User();
        $user->setDb($this->di->get("db"));
        $user->find("name", $name);

        // IF AUTHORITY == admin, then continue
        if ($user->authority != "admin") {
            return ($user->name == $this->user);
        }
        return true;
    }
}


1		<?php
2
3		namespace Nicklas\Comment\Modules;
4
5		/**
6		* A database driven model.
7		*/
8		class Post extends ActiveRecordModelExtender
9		{
10
11		/**
12		* @var string $tableName name of the database table.
13		*/
14		protected $tableName = "ramverk1_posts";
15
16		/**
17		* Columns in the table.
18		*
19		* @var integer $id primary key auto incremented.
20		*/
21		public $id;
22		public $user;
23		public $questionId; # Connection to new Question()
24
25		public $type; # question/answer
26		public $text;
27
28		public $created;
29
30		public $di;
31
32
33		/**
34		* Constructor injects with DI container.
35		*
36		*/
37		public function __construct($di = null)
38		{
39		$this->di = $di;
40		}
41		/**
42		* Returns post with markdown and gravatar
43		* @param string $sql
44		* @param array $param
		0 ignored issues – show Documentation introduced 2017-10-18 08:02 UTC by Report Bug Copy Issue Report There is no parameter named `$param`. Did you maybe mean `$params`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
45		*
46		* @return array
47		*/
48		public function getAllPosts($sql, $params)
49		{
50		$posts = $this->findAllWhere("$sql", $params);
51
52		return array_map(function ($post) {
53
54		// Get e-mail for Post
55		$user = new User();
56		$user->setDb($this->di->get("db"));
57		$user->find("name", $post->user);
58		$post->img = $this->gravatar($user->email);
59
60		// Get comments for Post
61		$comment = new Comment();
62		$comment->setDb($this->di->get("db"));
63		$post->comments = $comment->getComments("parentId = ?", [$post->id]);
64
65		// Get text
66		$post->markdown = $this->getMD($post->text);
67
68		return $post;
69		}, $posts);
70		}
71
72		/**
73		* return question/answer, three attributes are set, comments connected to them is an array.
74		*
75		* @return object
76		*/
77		public function getPost($sql, $params)
78		{
79		$post = $this->findWhere("$sql", $params);
80
81
82		// Get e-mail for question
83		$user = new User();
84		$user->setDb($this->di->get("db"));
85		$user->find("name", $post->user);
86		$post->img = $this->gravatar($user->email);
87
88		// Start setting attributes
89		$post->img = $this->gravatar($user->email);
90		$post->markdown = $this->getMD($post->text);
91		$post->comments = $comment->getComments("parentId = ?", [$post->id]);
		0 ignored issues – show Bug introduced 2017-10-18 08:02 UTC by Report Bug Copy Issue Report The variable `$comment` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
92
93		return $post;
94		}
95
96		/**
97		* Check if a post belongs to user
98		*
99		*
100		* @return boolean
101		*/
102	View Code Duplication	public function controlAuthority($name)
		0 ignored issues – show Duplication introduced 2017-10-18 08:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
103		{
104		$user = new User();
105		$user->setDb($this->di->get("db"));
106		$user->find("name", $name);
107
108		// IF AUTHORITY == admin, then continue
109		if ($user->authority != "admin") {
110		return ($user->name == $this->user);
111		}
112		return true;
113		}
114		}
115

Nicklas766 / Comment

Push — master ( 7e1229...8260e2 )

Post A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like