AdminController::getUsersIndex() - Code Metrics - Inspection of "More phpunit tests, mainly for pagerender function..." - Nicklas766/Comment - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 819cbf...086d7c )

by Nicklas

created 2017-10-05 09:10 UTC

AdminController::getUsersIndex() A

↳ Parent: AdminController

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	0
crap	1

<?php

namespace Nicklas\Comment;

use \Nicklas\Comment\HTMLForm\EditUserForm;
use \Nicklas\Comment\HTMLForm\CreateUserForm2;

/**
 * A controller class.
 */
class AdminController extends UserController
{

    /**
     * Get all users
     *
     *
     * @return array
     */
    public function getUsers()
    {
        $user = new User();
        $user->setDb($this->di->get("db"));
        $users = $user->findAll();

        return array_map(function ($user) {
            $user->setGravatar($user->email);

            return $user;
        }, $users);
    }

    /**
     * check if user is logged in
     *
     * @return void
     */
    public function checkIsAdmin()
    {
        $this->checkIsLogin();

        $user = new User();
        $user->setDb($this->di->get("db"));
        $user = $user->find("name", $this->di->get("session")->get("user"));

        if ($user->authority != "admin") {
            $views = [
                ["admin/fail", [], "main"]
            ];
            $this->renderPage($views, "Not authorized");
        }
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getUsersIndex()
    {
        $views = [
            ["admin/navbar", [], "main"],
            ["admin/crud/view-all", ["users" => $this->getUsers()], "main"]
        ];

        $this->di->get("pageRenderComment")->renderPage([
            "views" => $views,
            "title" => "A collection of items"
        ]);
    }


    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getPostAdminEditUser($id)

    {
        $form = new EditUserForm($this->di, $id);
        $form->check();

        $views = [
            ["admin/navbar", [], "main"],
            ["admin/crud/edit", ["form" => $form->getHTML()], "main"]
        ];

        $this->renderPage($views, "A login page");
    }

    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getPostAdminCreateUser()

    {
        $form = new CreateUserForm2($this->di);
        $form->check();

        $views = [
            ["admin/navbar", [], "main"],
            ["admin/crud/edit", ["form" => $form->getHTML()], "main"]
        ];

        $this->renderPage($views, "A login page");
    }
}


1			<?php
2
3			namespace Nicklas\Comment;
4
5			use \Nicklas\Comment\HTMLForm\EditUserForm;
6			use \Nicklas\Comment\HTMLForm\CreateUserForm2;
7
8			/**
9			* A controller class.
10			*/
11			class AdminController extends UserController
12			{
13
14			/**
15			* Get all users
16			*
17			*
18			* @return array
19			*/
20	2		public function getUsers()
21			{
22	2		$user = new User();
23	2		$user->setDb($this->di->get("db"));
24	2		$users = $user->findAll();
25
26	2		return array_map(function ($user) {
27	2		$user->setGravatar($user->email);
28
29	2		return $user;
30	2		}, $users);
31			}
32
33			/**
34			* check if user is logged in
35			*
36			* @return void
37			*/
38	1		public function checkIsAdmin()
39			{
40	1		$this->checkIsLogin();
41
42	1		$user = new User();
43	1		$user->setDb($this->di->get("db"));
44	1		$user = $user->find("name", $this->di->get("session")->get("user"));
45
46	1		if ($user->authority != "admin") {
47			$views = [
48	1		["admin/fail", [], "main"]
49	1		];
50	1		$this->renderPage($views, "Not authorized");
51	1		}
52	1		}
53
54
55			/**
56			* Description.
57			*
58			* @param datatype $variable Description
			0 ignored issues – show Bug introduced 2017-10-04 08:37 UTC by Report Bug Copy Issue Report There is no parameter named `$variable`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
59			*
60			* @throws Exception
61			*
62			* @return void
63			*/
64	1		public function getUsersIndex()
65			{
66			$views = [
67	1		["admin/navbar", [], "main"],
68	1		["admin/crud/view-all", ["users" => $this->getUsers()], "main"]
69	1		];
70
71	1		$this->di->get("pageRenderComment")->renderPage([
72	1		"views" => $views,
73			"title" => "A collection of items"
74	1		]);
75	1		}
76
77
78			/**
79			* Description.
80			*
81			* @param datatype $variable Description
			0 ignored issues – show Bug introduced 2017-10-04 08:37 UTC by Report Bug Copy Issue Report There is no parameter named `$variable`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
82			*
83			* @throws Exception
84			*
85			* @return void
86			*/
87	1	View Code Duplication	public function getPostAdminEditUser($id)
			0 ignored issues – show Duplication introduced 2017-10-04 08:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88			{
89	1		$form = new EditUserForm($this->di, $id);
90	1		$form->check();
91
92			$views = [
93	1		["admin/navbar", [], "main"],
94	1		["admin/crud/edit", ["form" => $form->getHTML()], "main"]
95	1		];
96
97	1		$this->renderPage($views, "A login page");
98	1		}
99
100			/**
101			* Description.
102			*
103			* @param datatype $variable Description
			0 ignored issues – show Bug introduced 2017-10-04 08:37 UTC by Report Bug Copy Issue Report There is no parameter named `$variable`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
104			*
105			* @throws Exception
106			*
107			* @return void
108			*/
109		View Code Duplication	public function getPostAdminCreateUser()
			0 ignored issues – show Duplication introduced 2017-10-04 08:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
110			{
111			$form = new CreateUserForm2($this->di);
112			$form->check();
113
114			$views = [
115			["admin/navbar", [], "main"],
116			["admin/crud/edit", ["form" => $form->getHTML()], "main"]
117			];
118
119			$this->renderPage($views, "A login page");
120			}
121			}
122

Nicklas766 / Comment

Push — master ( 819cbf...086d7c )

AdminController::getUsersIndex() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like