User - Code Metrics - Inspection of "100% code coverage for modules" - Nicklas766/Comment - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8ffaa6...f544e7 )

by Nicklas

created 2017-10-18 12:22 UTC

User A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	119
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	1
dl	0
loc	119
ccs	23
cts	23
cp	1
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Size	Complexity
A	userExists()	5	2
A	setGravatar()	4	1
A	getGravatar()	5	1
A	setPassword()	4	1
A	verifyPassword()	5	1
A	verifyQuestion()	5	1
A	controlAuthority()	9	2

<?php

namespace Nicklas\Comment\Modules;

/**
 * A database driven model.
 */
class User extends ActiveRecordModelExtender
{

        /**
     * @var string $tableName name of the database table.
     */
    protected $tableName = "ramverk1_users";

    /**
     * Columns in the table.
     *
     * @var integer $id primary key auto incremented.
     */
    public $id;
    public $name;
    public $email;
    public $pass;
    public $authority = "user";
    public $question;

    /**
     * Check if user exists
     *
     * @param string $name
     *
     * @return boolean true if user exists in database else false
     */
    public function userExists($name)
    {
        $user = $this->find("name", $name);
        return !$user ? false : true;
    }
    /**
     * Returns gravatar link
     *
     * @param string $email
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return string as gravatar link
     */
    public function setGravatar()
    {
        $this->img = $this->gravatar($this->email);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Returns gravatar link
     *
     * @param string $name
     *
     * @return string as gravatar link
     */
    public function getGravatar($name)
    {
        $this->find("name", $name);
        return $this->gravatar($this->email);
    }




    /**
     * Set the pass.
     *
     * @param string $pass the pass to use.
     *
     * @return void
     */
    public function setPassword($pass)
    {
        $this->pass = password_hash($pass, PASSWORD_DEFAULT);
    }

    /**
     * Verify the name and the pass, if successful the object contains
     * all details from the database row.
     *
     * @param string $name  name to check.
     * @param string $pass the pass to use.
     *
     * @return boolean true if name and pass matches, else false.
     */
    public function verifyPassword($name, $pass)
    {
        $this->find("name", $name);
        return password_verify($pass, $this->pass);
    }

    /**
     * Verify the name and the anaswer, if successful the object contains
     * all details from the database row.
     *
     * @param string $name  name to check.
     * @param string $answer the answer.
     *
     * @return boolean true if name and pass matches, else false.
     */
    public function verifyQuestion($name, $answer)
    {
        $this->find("name", $name);
        return ($this->question == $answer);
    }


    /**
    * Check if a post belongs to user
    *
    *
    * @return boolean
    */
    public function controlAuthority($loggedUser, $name)
    {
        $this->find("name", $loggedUser);
        // IF AUTHORITY == admin, then continue
        if ($this->authority != "admin") {
            return ($this->name == $name);
        }
        return true;
    }
}


1		<?php
2
3		namespace Nicklas\Comment\Modules;
4
5		/**
6		* A database driven model.
7		*/
8		class User extends ActiveRecordModelExtender
9		{
10
11		/**
12		* @var string $tableName name of the database table.
13		*/
14		protected $tableName = "ramverk1_users";
15
16		/**
17		* Columns in the table.
18		*
19		* @var integer $id primary key auto incremented.
20		*/
21		public $id;
22		public $name;
23		public $email;
24		public $pass;
25		public $authority = "user";
26		public $question;
27
28		/**
29		* Check if user exists
30		*
31		* @param string $name
32		*
33		* @return boolean true if user exists in database else false
34		*/
35	1	public function userExists($name)
36		{
37	1	$user = $this->find("name", $name);
38	1	return !$user ? false : true;
39		}
40		/**
41		* Returns gravatar link
42		*
43		* @param string $email
		0 ignored issues – show Bug introduced 2017-10-04 08:37 UTC by Report Bug Copy Issue Report There is no parameter named `$email`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
44		*
45		* @return string as gravatar link
46		*/
47	5	public function setGravatar()
48		{
49	5	$this->img = $this->gravatar($this->email);
		0 ignored issues – show Bug introduced 2017-10-04 08:37 UTC by Report Bug Copy Issue Report The property `img` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
50	5	}
51
52		/**
53		* Returns gravatar link
54		*
55		* @param string $name
56		*
57		* @return string as gravatar link
58		*/
59	4	public function getGravatar($name)
60		{
61	4	$this->find("name", $name);
62	4	return $this->gravatar($this->email);
63		}
64
65
66
67
68		/**
69		* Set the pass.
70		*
71		* @param string $pass the pass to use.
72		*
73		* @return void
74		*/
75	5	public function setPassword($pass)
76		{
77	5	$this->pass = password_hash($pass, PASSWORD_DEFAULT);
78	5	}
79
80		/**
81		* Verify the name and the pass, if successful the object contains
82		* all details from the database row.
83		*
84		* @param string $name name to check.
85		* @param string $pass the pass to use.
86		*
87		* @return boolean true if name and pass matches, else false.
88		*/
89	3	public function verifyPassword($name, $pass)
90		{
91	3	$this->find("name", $name);
92	3	return password_verify($pass, $this->pass);
93		}
94
95		/**
96		* Verify the name and the anaswer, if successful the object contains
97		* all details from the database row.
98		*
99		* @param string $name name to check.
100		* @param string $answer the answer.
101		*
102		* @return boolean true if name and pass matches, else false.
103		*/
104	1	public function verifyQuestion($name, $answer)
105		{
106	1	$this->find("name", $name);
107	1	return ($this->question == $answer);
108		}
109
110
111		/**
112		* Check if a post belongs to user
113		*
114		*
115		* @return boolean
116		*/
117	1	public function controlAuthority($loggedUser, $name)
118		{
119	1	$this->find("name", $loggedUser);
120		// IF AUTHORITY == admin, then continue
121	1	if ($this->authority != "admin") {
122	1	return ($this->name == $name);
123		}
124	1	return true;
125		}
126		}
127

Nicklas766 / Comment

Push — master ( 8ffaa6...f544e7 )

User A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like