UserController::getPostCreateUser() - Code Metrics - Inspection of "GET functions for users, more phpunit tests for us..." - Nicklas766/Comment - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a87104...0a436d )

by Nicklas

created 2017-10-19 08:39 UTC

UserController::getPostCreateUser() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	8

Duplication

Lines	14
Ratio	100 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes

Metric	Value
dl	14
loc	14
ccs	9
cts	9
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	0
crap	1

<?php

namespace Nicklas\Comment;

// MODULES
use \Nicklas\Comment\Modules\User;

/**
 * A controller class.
 */
class UserController extends ProfileController
{

    /**
     * Create page for all users overview
     *
     * @return void
     */
    public function getAllUsersIndex()

    {
        $user = new Users($this->di->get("db"));
        $users = $user->getUsers();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $views = [
            ["user/pre/create", ["form" => $form->getHTML()], "main"]

        ];

        $this->di->get("pageRenderComment")->renderPage([
            "views" => $views,
            "title" => "Create User"
        ]);
    }
}


1		<?php
2
3		namespace Nicklas\Comment;
4
5		// MODULES
6		use \Nicklas\Comment\Modules\User;
7
8		/**
9		* A controller class.
10		*/
11		class UserController extends ProfileController
12		{
13
14		/**
15		* Create page for all users overview
16		*
17		* @return void
18		*/
19	View Code Duplication	public function getAllUsersIndex()
		0 ignored issues – show Duplication introduced 2017-10-19 08:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20		{
21		$user = new Users($this->di->get("db"));
22		$users = $user->getUsers();
		0 ignored issues – show Unused Code introduced 2017-10-19 08:41 UTC by Report Bug Copy Issue Report `$users` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
23		$views = [
24		["user/pre/create", ["form" => $form->getHTML()], "main"]
		0 ignored issues – show Bug introduced 2017-10-19 08:41 UTC by Report Bug Copy Issue Report The variable `$form` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
25		];
26
27		$this->di->get("pageRenderComment")->renderPage([
28		"views" => $views,
29		"title" => "Create User"
30		]);
31		}
32		}
33

Nicklas766 / Comment

Push — master ( a87104...0a436d )

UserController::getPostCreateUser() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like