EditCommentForm::callbackSubmit() - Code Metrics - Inspection of "New edit comment/post routes and HTMLforms" - Nicklas766/Comment - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d84616...0f723a )

by Nicklas

created 2017-10-22 18:58 UTC

EditCommentForm::callbackSubmit() B

↳ Parent: EditCommentForm

Complexity

Conditions	4
Paths	4

Size

Total Lines	26
Code Lines	16

Duplication

Lines	26
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	26
loc	26
ccs	0
cts	16
cp	0
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	16
nc	4
nop	0
crap	20

<?php

namespace Nicklas\Comment\HTMLForm\Comment;

use \Anax\HTMLForm\FormModel;
use \Anax\DI\DIInterface;
use \Nicklas\Comment\Modules\User;
use \Nicklas\Comment\Modules\Comment;

/**
 * Form to update an item.
 */
class EditCommentForm extends FormModel

{
    /**
     * Constructor injects with DI container and the id to update.
     *
     * @param Anax\DI\DIInterface $di a service container
     * @param integer             $id to update
     */
    public function __construct(DIInterface $di, $id)
    {
        parent::__construct($di);
        $this->comment = new Comment($di->get("db"));
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->comment->find("id", $id);
        if ($this->comment->id == null) {
            $di->get("response")->redirect("question");
        }
        $this->form->create(
            [
                "id" => __CLASS__,
                "legend" => "Här kan du uppdatera din kommentar"
            ],
            [
                "text" => [
                    "type" => "textarea",
                    "validation" => ["not_empty"],
                    "value" => $this->comment->text,
                ],

                "submit" => [
                    "type" => "submit",
                    "value" => "Spara",
                    "callback" => [$this, "callbackSubmit"]
                ],
            ]
        );
    }




    /**
     * Callback for submit-button which should return true if it could
     * carry out its work and false if something failed.
     *
     * @return void
     */
    public function callbackSubmit()
    {
        // Get values from the submitted form
        $text = $this->form->value("text");

        if (!$this->di->get('session')->has("user")) {
            $this->form->addOutput("Du behöver logga in");
            return false;
        }

        $user = new User($this->di->get("db"));
        if ($user->controlAuthority($this->di->get('session')->get("user"), $this->comment->user) != true) {

            $this->form->addOutput("Du får inte redigera denna.");
            return false;
        }

        if ($text == "") {
            $this->form->addOutput("Du skrev aldrig något. Skriv gärna något.");
            return false;
        }

        $this->comment->text = $text;
        $this->comment->save();
        $this->form->addOutput("Du har uppdaterat kommentaren");
        return true;
    }
}


1		<?php
2
3		namespace Nicklas\Comment\HTMLForm\Comment;
4
5		use \Anax\HTMLForm\FormModel;
6		use \Anax\DI\DIInterface;
7		use \Nicklas\Comment\Modules\User;
8		use \Nicklas\Comment\Modules\Comment;
9
10		/**
11		* Form to update an item.
12		*/
13	View Code Duplication	class EditCommentForm extends FormModel
		0 ignored issues – show Duplication introduced 2017-10-22 19:00 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		{
15		/**
16		* Constructor injects with DI container and the id to update.
17		*
18		* @param Anax\DI\DIInterface $di a service container
19		* @param integer $id to update
20		*/
21		public function __construct(DIInterface $di, $id)
22		{
23		parent::__construct($di);
24		$this->comment = new Comment($di->get("db"));
		0 ignored issues – show Bug introduced 2017-10-22 19:00 UTC by Report Bug Copy Issue Report The property `comment` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25		$this->comment->find("id", $id);
26		if ($this->comment->id == null) {
27		$di->get("response")->redirect("question");
28		}
29		$this->form->create(
30		[
31		"id" => __CLASS__,
32		"legend" => "Här kan du uppdatera din kommentar"
33		],
34		[
35		"text" => [
36		"type" => "textarea",
37		"validation" => ["not_empty"],
38		"value" => $this->comment->text,
39		],
40
41		"submit" => [
42		"type" => "submit",
43		"value" => "Spara",
44		"callback" => [$this, "callbackSubmit"]
45		],
46		]
47		);
48		}
49
50
51
52
53		/**
54		* Callback for submit-button which should return true if it could
55		* carry out its work and false if something failed.
56		*
57		* @return void
58		*/
59		public function callbackSubmit()
60		{
61		// Get values from the submitted form
62		$text = $this->form->value("text");
63
64		if (!$this->di->get('session')->has("user")) {
65		$this->form->addOutput("Du behöver logga in");
66		return false;
67		}
68
69		$user = new User($this->di->get("db"));
70		if ($user->controlAuthority($this->di->get('session')->get("user"), $this->comment->user) != true) {
		0 ignored issues – show Coding Style Best Practice introduced 2017-10-22 19:00 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `!==` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
71		$this->form->addOutput("Du får inte redigera denna.");
72		return false;
73		}
74
75		if ($text == "") {
76		$this->form->addOutput("Du skrev aldrig något. Skriv gärna något.");
77		return false;
78		}
79
80		$this->comment->text = $text;
81		$this->comment->save();
82		$this->form->addOutput("Du har uppdaterat kommentaren");
83		return true;
84		}
85		}
86

Nicklas766 / Comment

Push — master ( d84616...0f723a )

EditCommentForm::callbackSubmit() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like