Post::getAllPosts() - Code Metrics - Inspection of "new sql setup" - Nicklas766/Comment - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 7c8781...44e581 )

by Nicklas

created 2017-10-23 15:42 UTC

Post::getAllPosts() A

↳ Parent: Post

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	0
cts	3
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2
crap	2

<?php

namespace Nicklas\Comment\Modules;

/**
 * A database driven model.
 */
class Post extends ActiveRecordModelExtender
{

        /**
     * @var string $tableName name of the database table.
     */
    protected $tableName = "coffee_posts";

    /**
     * Columns in the table.
     *
     * @var integer $id primary key auto incremented.
     */
    public $id;
    public $user;
    public $questionId; # Connection to new Question()
    public $accepted; # default "no"

    public $type; # question/answer
    public $text;

    public $created;

    public $di;


    /**
     * Set ups the question
     * @param object $post
     *
     * @return object
     */
    public function setupPost($post)
    {

        $user    = new User($this->db);
        $comment = new Comment($this->db);
        $vote    = new Vote($this->db);

        $post->img      = $user->getGravatar($post->user);
        $post->comments = $comment->getComments("parentId = ?", [$post->id]);
        $post->vote     = $vote->getVote("parentId = ? AND parentType = ?", [$post->id, "post"]);
        $post->markdown = $this->getMD($post->text);

        return $post;
    }

    /**
     * Returns post with markdown and gravatar
     * @param string $sql
     * @param array $param
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return objects[]
     */
    public function getAllPosts($sql, $params)
    {
        $posts = $this->findAllWhere("$sql", $params);

        // array_reverse so latest order question gets returned
        return array_map(array($this, 'setupPost'), $posts);
    }

    /**
     * return question/answer, three attributes are set, comments connected to them is an array.
     * @param string $sql
     * @param array $param
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return object
    */
    public function getPost($sql, $params)
    {
        $post = $this->findWhere("$sql", $params);
        return $post->setupPost($post);

    }
}


1			<?php
2
3			namespace Nicklas\Comment\Modules;
4
5			/**
6			* A database driven model.
7			*/
8			class Post extends ActiveRecordModelExtender
9			{
10
11			/**
12			* @var string $tableName name of the database table.
13			*/
14			protected $tableName = "coffee_posts";
15
16			/**
17			* Columns in the table.
18			*
19			* @var integer $id primary key auto incremented.
20			*/
21			public $id;
22			public $user;
23			public $questionId; # Connection to new Question()
24			public $accepted; # default "no"
25
26			public $type; # question/answer
27			public $text;
28
29			public $created;
30
31			public $di;
32
33
34			/**
35			* Set ups the question
36			* @param object $post
37			*
38			* @return object
39			*/
40			public function setupPost($post)
41			{
42
43			$user = new User($this->db);
44			$comment = new Comment($this->db);
45			$vote = new Vote($this->db);
46
47			$post->img = $user->getGravatar($post->user);
48			$post->comments = $comment->getComments("parentId = ?", [$post->id]);
49			$post->vote = $vote->getVote("parentId = ? AND parentType = ?", [$post->id, "post"]);
50			$post->markdown = $this->getMD($post->text);
51
52			return $post;
53			}
54
55			/**
56			* Returns post with markdown and gravatar
57			* @param string $sql
58			* @param array $param
			0 ignored issues – show Documentation introduced 2017-10-18 08:02 UTC by Report Bug Copy Issue Report There is no parameter named `$param`. Did you maybe mean `$params`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
59			*
60			* @return objects[]
61			*/
62			public function getAllPosts($sql, $params)
63			{
64			$posts = $this->findAllWhere("$sql", $params);
65
66			// array_reverse so latest order question gets returned
67			return array_map(array($this, 'setupPost'), $posts);
68			}
69
70			/**
71			* return question/answer, three attributes are set, comments connected to them is an array.
72			* @param string $sql
73			* @param array $param
			0 ignored issues – show Documentation introduced 2017-10-19 08:41 UTC by Report Bug Copy Issue Report There is no parameter named `$param`. Did you maybe mean `$params`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
74			*
75			* @return object
76			*/
77			public function getPost($sql, $params)
78			{
79			$post = $this->findWhere("$sql", $params);
80			return $post->setupPost($post);
			0 ignored issues – show Bug introduced 2017-10-21 15:02 UTC by Report Bug Copy Issue Report The method `setupPost` cannot be called on `$post` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
81			}
82			}
83

Nicklas766 / Comment

Push — master ( 7c8781...44e581 )

Post::getAllPosts() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like