Comment::getComments() - Code Metrics - Inspection of "new sql setup" - Nicklas766/Comment - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 7c8781...44e581 )

by Nicklas

created 2017-10-23 15:42 UTC

Comment::getComments() A

↳ Parent: Comment

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1.512

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	2
cts	10
cp	0.2
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	2
crap	1.512

<?php

namespace Nicklas\Comment\Modules;

/**
 * A database driven model.
 */
class Comment extends ActiveRecordModelExtender
{

        /**
     * @var string $tableName name of the database table.
     */
    protected $tableName = "coffee_comments";

    /**
     * Columns in the table.
     *
     * @var integer $id primary key auto incremented.
     */
    public $id;
    public $user; # question/answer/comment
    public $parentId; # All posts have different ids

    public $text;

    public $created;

    /**
     * Returns post with markdown and gravatar
     * @param string $sql
     * @param array $param
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return array
     */
    public function getComments($sql, $params)
    {
        $comments = $this->findAllWhere("$sql", $params);

        return array_map(function ($comment) {
            $user = new User($this->db);
            $comment->img = $user->getGravatar($comment->user);
            $comment->markdown = $this->getMD($comment->text);

            // Get votes for Post
            $vote = new Vote($this->db);
            $comment->vote = $vote->getVote("parentId = ? AND parentType = ?", [$comment->id, "comment"]);

            return $comment;
        }, $comments);
    }
}


1		<?php
2
3		namespace Nicklas\Comment\Modules;
4
5		/**
6		* A database driven model.
7		*/
8		class Comment extends ActiveRecordModelExtender
9		{
10
11		/**
12		* @var string $tableName name of the database table.
13		*/
14		protected $tableName = "coffee_comments";
15
16		/**
17		* Columns in the table.
18		*
19		* @var integer $id primary key auto incremented.
20		*/
21		public $id;
22		public $user; # question/answer/comment
23		public $parentId; # All posts have different ids
24
25		public $text;
26
27		public $created;
28
29		/**
30		* Returns post with markdown and gravatar
31		* @param string $sql
32		* @param array $param
		0 ignored issues – show Documentation introduced 2017-10-15 11:21 UTC by Report Bug Copy Issue Report There is no parameter named `$param`. Did you maybe mean `$params`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
33		*
34		* @return array
35		*/
36	1	public function getComments($sql, $params)
37		{
38	1	$comments = $this->findAllWhere("$sql", $params);
39
40		return array_map(function ($comment) {
41		$user = new User($this->db);
42		$comment->img = $user->getGravatar($comment->user);
43		$comment->markdown = $this->getMD($comment->text);
44
45		// Get votes for Post
46		$vote = new Vote($this->db);
47		$comment->vote = $vote->getVote("parentId = ? AND parentType = ?", [$comment->id, "comment"]);
48
49		return $comment;
50		}, $comments);
51		}
52		}
53

Nicklas766 / Comment

Push — master ( 7c8781...44e581 )

Comment::getComments() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like