Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class Post extends ActiveRecordModelExtender |
||
9 | { |
||
10 | |||
11 | /** |
||
12 | * @var string $tableName name of the database table. |
||
13 | */ |
||
14 | protected $tableName = "ramverk1_posts"; |
||
15 | |||
16 | /** |
||
17 | * Columns in the table. |
||
18 | * |
||
19 | * @var integer $id primary key auto incremented. |
||
20 | */ |
||
21 | public $id; |
||
22 | public $user; |
||
23 | public $questionId; # Connection to new Question() |
||
24 | public $accepted; # default "no" |
||
25 | |||
26 | public $type; # question/answer |
||
27 | public $text; |
||
28 | |||
29 | public $created; |
||
30 | |||
31 | public $di; |
||
32 | |||
33 | |||
34 | |||
35 | /** |
||
36 | * Returns post with markdown and gravatar |
||
37 | * @param string $sql |
||
38 | * @param array $param |
||
|
|||
39 | * |
||
40 | * @return array |
||
41 | */ |
||
42 | 9 | View Code Duplication | public function getAllPosts($sql, $params) |
67 | |||
68 | /** |
||
69 | * return question/answer, three attributes are set, comments connected to them is an array. |
||
70 | * |
||
71 | * @return object |
||
72 | */ |
||
73 | 7 | View Code Duplication | public function getPost($sql, $params) |
95 | } |
||
96 |
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit.
Consider the following example. The parameter
$ireland
is not defined by the methodfinale(...)
.The most likely cause is that the parameter was changed, but the annotation was not.