Nicklas\Comment\Modules\User

Complexity

Total Complexity

15

Size/Duplication

Total Lines	219
Duplicated Lines	5.02 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
B	getReputation()	0	31	1
B	setupUser()	0	30	1
A	getAllUsers()	11	11	3
A	getUser()	0	6	1
A	userExists()	0	5	2
A	setGravatar()	0	4	1
A	getGravatar()	0	5	1
A	setPassword()	0	4	1
A	verifyPassword()	0	5	1
A	verifyQuestion()	0	5	1
A	controlAuthority()	0	9	2

<?php

namespace Nicklas\Comment\Modules;

/**
 * A database driven model.
 */
class User extends ActiveRecordModelExtender
{

        /**
     * @var string $tableName name of the database table.
     */
    protected $tableName = "ramverk1_users";

    /**
     * Columns in the table.
     *
     * @var integer $id primary key auto incremented.
     */
    public $id;
    public $name;
    public $email;
    public $pass;
    public $authority = "user";
    public $question;

    public function getReputation($user)
    {
        // Get all the vote->scores connected to users posts
        $questionPoints = array_reduce($user->questions, function ($carry, $item) {
            $carry += $item->question->vote->score;
            return $carry;
        });

        $postPoints = array_reduce($user->posts, function ($carry, $item) {
            $carry += $item->vote->score;
            return $carry;
        });

        $commentPoints = array_reduce($user->comments, function ($carry, $item) {
            $carry += $item->vote->score;
            return $carry;
        });

        $points =
        ($questionPoints * 2) +
        ($postPoints     * 3) +
        ($commentPoints  * 1);

        // Algorithm for reputation points
        $reputation =
        (count($user->questions) * 2)   +
        (count($user->posts)     * 3)   +
        (count($user->comments)  * 1)   + $points;

         return $reputation;
    }


    /**
     * Sets up user
     * @param object $user
     * @param array $param

There is no parameter named $param. Was it maybe removed?

     *
     * @return object
     */
    public function setupUser($user)
    {
        $question = new Question($this->db);
        $post     = new Post($this->db);
        $comment  = new Comment($this->db);
        $vote     = new Vote($this->db);

        // Basic setup for user
        $user->img        = $this->getGravatar($user->name);

        // Get all posts/votes user made
        $user->questions  = $question->getQuestions("user = ?", $user->name);
        $user->comments   = $comment->getComments("user = ?", $user->name);
        $user->posts      = $post->getAllPosts("user = ? AND type = ?", [$user->name, "answer"]);
        $user->votes      = $vote->getVote("user = ?", [$user->name]);

        // Amount of posts
        $user->postAmount = count($user->questions) + count($user->posts) + count($user->comments);

        // Algorithm for reputation points
        $user->reputation = $this->getReputation($user);

        // Get all the questions connected to answers
        $user->answeredQuestions = array_map(function ($answer) {
            $question = new Question($this->db);
            return $question->getQuestion($answer->questionId);
        }, $user->posts);

        return $user;
    }

    /**
     * Returns post with markdown and gravatar
     * @param string $sql
     * @param array $param

There is no parameter named $param. Did you maybe mean $params?

     *
     * @return array
     */
    public function getAllUsers($sql = null, $params = null)

This method seems to be duplicated in your project.

    {
        if ($sql == null) {

It seems like you are loosely comparing $sql of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            $users = $this->findAll();
        }
        if ($sql != null) {

It seems like you are loosely comparing $sql of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            $users = $this->findAllWhere($sql, $params);
        }

        return array_map(array($this, 'setupUser'), $users);

The variable $users does not seem to be defined for all execution paths leading up to this point.

    }

    /**
     * return question/answer, three attributes are set, comments connected to them is an array.
     *
     * @return object
    */
    public function getUser($name)
    {
        $user = $this->find("name", $name);
        $user = $this->setupUser($user);

$user is of type array, but the function expects a object.

        return $user;
    }


    /**
     * Check if user exists
     *
     * @param string $name
     *
     * @return boolean true if user exists in database else false
     */
    public function userExists($name)
    {
        $user = $this->find("name", $name);
        return !$user ? false : true;
    }
    /**
     * Returns gravatar link
     *
     * @param string $email

There is no parameter named $email. Was it maybe removed?

     *
     * @return string as gravatar link
     */
    public function setGravatar()
    {
        $this->img = $this->gravatar($this->email);

The property img does not exist. Did you maybe forget to declare it?

    }

    /**
     * Returns gravatar link
     *
     * @param string $name
     *
     * @return string as gravatar link
     */
    public function getGravatar($name)
    {
        $this->find("name", $name);
        return $this->gravatar($this->email);
    }

    /**
     * Set the pass.
     *
     * @param string $pass the pass to use.
     *
     * @return void
     */
    public function setPassword($pass)
    {
        $this->pass = password_hash($pass, PASSWORD_DEFAULT);
    }

    /**
     * Verify the name and the pass, if successful the object contains
     * all details from the database row.
     *
     * @param string $name  name to check.
     * @param string $pass the pass to use.
     *
     * @return boolean true if name and pass matches, else false.
     */
    public function verifyPassword($name, $pass)
    {
        $this->find("name", $name);
        return password_verify($pass, $this->pass);
    }

    /**
     * Verify the name and the anaswer, if successful the object contains
     * all details from the database row.
     *
     * @param string $name  name to check.
     * @param string $answer the answer.
     *
     * @return boolean true if name and pass matches, else false.
     */
    public function verifyQuestion($name, $answer)
    {
        $this->find("name", $name);
        return ($this->question == $answer);
    }


    /**
    * Check if a post belongs to user
    *
    *
    * @return boolean
    */
    public function controlAuthority($loggedUser, $name)
    {
        $this->find("name", $loggedUser);
        // IF AUTHORITY == admin, then continue
        if ($this->authority != "admin") {
            return ($this->name == $name);
        }
        return true;
    }
}