Comment::getPosts() - Code Metrics - Inspection of "comments now have types, (question, answer, commen..." - Nicklas766/Comment - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 086d7c...48da91 )

by Nicklas

created 2017-10-15 11:18 UTC

Comment::getPosts() A

↳ Parent: Comment

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	2

<?php

namespace Nicklas\Comment;

/**
 * A database driven model.
 */
class Comment extends ActiveRecordModelExtender
{

        /**
     * @var string $tableName name of the database table.
     */
    protected $tableName = "ramverk1_comments";

    /**
     * Columns in the table.
     *
     * @var integer $id primary key auto incremented.
     */
    public $id;
    public $di;


    public $text;

    public $parentId; # All posts have different ids
    public $type; # question/answer/comment

    public $created;
    public $status; # default is active




    /**
     * HA EN FOREACH I En FOREACH FÖR ATT HA COMMENTS CONNECTED
     *

        */

    /**
     * Constructor injects with DI container.
     *
     */
    public function __construct($di = null)
    {
        $this->di = $di;
    }
    /**
     * Returns post with markdown and gravatar
     * @param string $sql
     * @param array $param
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return array
     */
    public function getPosts($sql, $params)
    {
        $posts = $this->findAllWhere("$sql", $params);

        return array_map(function ($post) {
            $user = new User();
            $user->setDb($this->di->get("db"));
            $user->find("name", $post->user);

            $post->img = $this->gravatar($user->email);
            $post->markdown = $this->getMD($post->text);

            return $post;
        }, $posts);
    }

    /**
     * return question/answer, three attributes are set, comments connected to them is an array.
     *
     * @return object
    */
        public function getPost($id)
        {
            $post = $this->find("id", $id);

            // Get user who posted
            $user = new User();
            $user->setDb($this->di->get("db"));
            $user->find("name", $post->user);

            // Start setting attributes
            $post->comments = $this->getPosts("parentId = ? AND type = ?", [$id, "comment"]);
            $post->img = $this->gravatar($user->email);
            $post->markdown = $this->getMD($post->text);

            return $post;
        }



    /**
     * Check if a post belongs to user
     *
     *
     * @return boolean
     */
    public function controlAuthority($name)
    {
        $user = new User();
        $user->setDb($this->di->get("db"));
        $user->find("name", $name);

        // IF AUTHORITY == admin, then continue
        if ($user->authority != "admin") {
            return ($user->name == $this->user);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        return true;
    }
}


1			<?php
2
3			namespace Nicklas\Comment;
4
5			/**
6			* A database driven model.
7			*/
8			class Comment extends ActiveRecordModelExtender
9			{
10
11			/**
12			* @var string $tableName name of the database table.
13			*/
14			protected $tableName = "ramverk1_comments";
15
16			/**
17			* Columns in the table.
18			*
19			* @var integer $id primary key auto incremented.
20			*/
21			public $id;
22			public $di;
23
24
25			public $text;
26
27			public $parentId; # All posts have different ids
28			public $type; # question/answer/comment
29
30			public $created;
31			public $status; # default is active
32
33
34
35
36			/**
37			* HA EN FOREACH I En FOREACH FÖR ATT HA COMMENTS CONNECTED
38			*
39
40			*/
41
42			/**
43			* Constructor injects with DI container.
44			*
45			*/
46			public function __construct($di = null)
47			{
48			$this->di = $di;
49			}
50			/**
51			* Returns post with markdown and gravatar
52			* @param string $sql
53			* @param array $param
			0 ignored issues – show Documentation introduced 2017-10-15 11:21 UTC by Report Bug Copy Issue Report There is no parameter named `$param`. Did you maybe mean `$params`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
54			*
55			* @return array
56			*/
57			public function getPosts($sql, $params)
58			{
59			$posts = $this->findAllWhere("$sql", $params);
60
61			return array_map(function ($post) {
62			$user = new User();
63			$user->setDb($this->di->get("db"));
64			$user->find("name", $post->user);
65
66			$post->img = $this->gravatar($user->email);
67			$post->markdown = $this->getMD($post->text);
68
69			return $post;
70			}, $posts);
71			}
72
73			/**
74			* return question/answer, three attributes are set, comments connected to them is an array.
75			*
76			* @return object
77			*/
78			public function getPost($id)
79			{
80			$post = $this->find("id", $id);
81
82			// Get user who posted
83			$user = new User();
84			$user->setDb($this->di->get("db"));
85			$user->find("name", $post->user);
86
87			// Start setting attributes
88			$post->comments = $this->getPosts("parentId = ? AND type = ?", [$id, "comment"]);
89			$post->img = $this->gravatar($user->email);
90			$post->markdown = $this->getMD($post->text);
91
92			return $post;
93			}
94
95
96
97			/**
98			* Check if a post belongs to user
99			*
100			*
101			* @return boolean
102			*/
103			public function controlAuthority($name)
104			{
105			$user = new User();
106			$user->setDb($this->di->get("db"));
107			$user->find("name", $name);
108
109			// IF AUTHORITY == admin, then continue
110			if ($user->authority != "admin") {
111			return ($user->name == $this->user);
			0 ignored issues – show Bug introduced 2017-10-15 11:21 UTC by Report Bug Copy Issue Report The property `user` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
112			}
113			return true;
114			}
115			}
116

Nicklas766 / Comment

Push — master ( 086d7c...48da91 )

Comment::getPosts() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like