ProfileController::getUserDetails() - Code Metrics - Inspection of "Add comments via post route question/comment/id |..." - Nicklas766/Comment - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f544e7...a87104 )

by Nicklas

created 2017-10-18 17:27 UTC

ProfileController::getUserDetails() A

↳ Parent: ProfileController

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	1
crap	1

<?php

namespace Nicklas\Comment;

use \Nicklas\Comment\HTMLForm\Profile\EditProfileForm;
use \Nicklas\Comment\HTMLForm\Profile\UpdateProfileSecurityForm;
use \Nicklas\Comment\Modules\User;

/**
 * A controller class.
 */
class ProfileController extends UserController
{

    /**
     * Get details on item to load form with.
     *
     * @param integer $id get details on item with id.
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return object true if okey, false if something went wrong.
     */
    public function getUserDetails($name)
    {
        $user = new User($this->di->get("db"));
        $user->find("name", $name);
        $user->setGravatar();
        return $user;
    }

    /**
     * Render profile page
     *
     * @return void
     */
    public function renderProfile()
    {
        $this->checkIsLogin();

        $name = $this->di->get('session')->get("user");
        $user = $this->getUserDetails($name);


        $views = [
            ["user/profile/profile", ["user" => $user], "main"]
        ];

        if ($user->authority == "admin") {
            $views = [
                ["admin/navbar", [], "main"],
                ["user/profile/profile", ["user" => $user], "main"]
            ];
        }

        $this->di->get("pageRenderComment")->renderPage([
            "views" =>  $views,
            "title" => "$user->name"
        ]);
    }

    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getPostEditUser()

    {
        $name = $this->di->get('session')->get("user");
        $user = $this->getUserDetails($name);

        $form       = new EditProfileForm($this->di, $name);
        $form->check();

        $views = [
            ["user/profile/edit", ["form" => $form->getHTML(), "user" => $user], "main"]
        ];

        $this->di->get("pageRenderComment")->renderPage([
            "views" =>  $views,
            "title" => "Edit Profile"
        ]);
    }

    /**
     * Description.
     *
     * @param datatype $variable Description
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @throws Exception
     *
     * @return void
     */
    public function getPostEditSecurity()

    {
        $name = $this->di->get('session')->get("user");
        $user = $this->getUserDetails($name);

        $form       = new UpdateProfileSecurityForm($this->di);
        $form->check();

        $views = [
            ["user/profile/edit", ["form" => $form->getHTML(), "user" => $user], "main"]
        ];

        $this->di->get("pageRenderComment")->renderPage([
            "views" =>  $views,
            "title" => "Edit Profile"
        ]);
    }
}


1			<?php
2
3			namespace Nicklas\Comment;
4
5			use \Nicklas\Comment\HTMLForm\Profile\EditProfileForm;
6			use \Nicklas\Comment\HTMLForm\Profile\UpdateProfileSecurityForm;
7			use \Nicklas\Comment\Modules\User;
8
9			/**
10			* A controller class.
11			*/
12			class ProfileController extends UserController
13			{
14
15			/**
16			* Get details on item to load form with.
17			*
18			* @param integer $id get details on item with id.
			0 ignored issues – show Bug introduced 2017-10-04 08:37 UTC by Report Bug Copy Issue Report There is no parameter named `$id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
19			*
20			* @return object true if okey, false if something went wrong.
21			*/
22	2		public function getUserDetails($name)
23			{
24	2		$user = new User($this->di->get("db"));
25	2		$user->find("name", $name);
26	2		$user->setGravatar();
27	2		return $user;
28			}
29
30			/**
31			* Render profile page
32			*
33			* @return void
34			*/
35	1		public function renderProfile()
36			{
37	1		$this->checkIsLogin();
38
39	1		$name = $this->di->get('session')->get("user");
40	1		$user = $this->getUserDetails($name);
41
42
43			$views = [
44	1		["user/profile/profile", ["user" => $user], "main"]
45	1		];
46
47	1		if ($user->authority == "admin") {
48			$views = [
49			["admin/navbar", [], "main"],
50			["user/profile/profile", ["user" => $user], "main"]
51			];
52			}
53
54	1		$this->di->get("pageRenderComment")->renderPage([
55	1		"views" => $views,
56	1		"title" => "$user->name"
57	1		]);
58	1		}
59
60			/**
61			* Description.
62			*
63			* @param datatype $variable Description
			0 ignored issues – show Bug introduced 2017-10-04 08:37 UTC by Report Bug Copy Issue Report There is no parameter named `$variable`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
64			*
65			* @throws Exception
66			*
67			* @return void
68			*/
69	1	View Code Duplication	public function getPostEditUser()
			0 ignored issues – show Duplication introduced 2017-10-15 14:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70			{
71	1		$name = $this->di->get('session')->get("user");
72	1		$user = $this->getUserDetails($name);
73
74	1		$form = new EditProfileForm($this->di, $name);
75	1		$form->check();
76
77			$views = [
78	1		["user/profile/edit", ["form" => $form->getHTML(), "user" => $user], "main"]
79	1		];
80
81	1		$this->di->get("pageRenderComment")->renderPage([
82	1		"views" => $views,
83			"title" => "Edit Profile"
84	1		]);
85	1		}
86
87			/**
88			* Description.
89			*
90			* @param datatype $variable Description
			0 ignored issues – show Bug introduced 2017-10-04 08:37 UTC by Report Bug Copy Issue Report There is no parameter named `$variable`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
91			*
92			* @throws Exception
93			*
94			* @return void
95			*/
96		View Code Duplication	public function getPostEditSecurity()
			0 ignored issues – show Duplication introduced 2017-10-15 14:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
97			{
98			$name = $this->di->get('session')->get("user");
99			$user = $this->getUserDetails($name);
100
101			$form = new UpdateProfileSecurityForm($this->di);
102			$form->check();
103
104			$views = [
105			["user/profile/edit", ["form" => $form->getHTML(), "user" => $user], "main"]
106			];
107
108			$this->di->get("pageRenderComment")->renderPage([
109			"views" => $views,
110			"title" => "Edit Profile"
111			]);
112			}
113			}
114

Nicklas766 / Comment

Push — master ( f544e7...a87104 )

ProfileController::getUserDetails() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like