Nicklas\Comment\Modules\Vote

Complexity

Total Complexity

11

Size/Duplication

Total Lines	122
Duplicated Lines	22.95 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

95.45%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getVote()	0	14	1
B	saveVote()	0	28	4
A	like()	14	14	3
A	dislike()	14	14	3

<?php

namespace Nicklas\Comment\Modules;

/**
 * A database driven model.
 */
class Vote extends ActiveRecordModelExtender
{

        /**
     * @var string $tableName name of the database table.
     */
    protected $tableName = "coffee_votes";

    /**
     * Columns in the table.
     *
     * @var integer $id primary key auto incremented.
     */
    public $id;
    public $user; # question/answer/comment
    public $parentId; # All posts have different ids
    public $parentType; # post or comment
    public $upVote;
    public $downVote;


    /**
     * Return a vote
     * @param string $sql
     * @param array $params
     *
     * @return object
     */
    public function getVote($sql, $params)
    {
        $likes = $this->findAllWhere("$sql", $params);

        // Return users of the ones who have upvoted.
        $score = array_reduce($likes, function ($carry, $item) {
            $carry += $item->upVote - $item->downVote;
            return $carry;
        });

        $this->likes = $likes;

The property likes does not exist. Did you maybe forget to declare it?

        $this->score = $score;

The property score does not exist. Did you maybe forget to declare it?

        return $this;
    }

    /**
     * Checks if vote already exists, then either create new or update
     * @param array $params

There is no parameter named $params. Was it maybe removed?

     *
     * @return bool
     */
    public function saveVote($user, $parentId, $parentType, $voteType = "like")
    {
        $vote = $this->findAllWhere("parentId = ? AND parentType = ? AND user = ?", [$parentId, $parentType, $user])[0];

        if ($vote != null) {
            $vote->setDb($this->db);
        }

        if ($vote == null) {
            $vote = $this;
        }

        $vote->user = $user;
        $vote->parentId = $parentId;
        $vote->parentType = $parentType;
        $vote->upVote = 1;
        $vote->downVote = null;

        if ($voteType == "downVote") {
            $vote->upVote = null;
            $vote->downVote = 1;
        }



        $vote->save();
        return true;
    }

    /**
     * Control if user has already liked or not
     * @param string $user
     * @param array $params

There is no parameter named $params. Was it maybe removed?

     *
     * @return bool
     */
    public function like($user, $parentId, $parentType)

This method seems to be duplicated in your project.

    {
        $likes = $this->findAllWhere("parentId = ? AND parentType = ?", [$parentId, $parentType]);
        // Return users of the ones who have upvoted.
        $users = array_map(function ($like) {
            return $like->upVote != null ? $like->user : "";
        }, $likes);

        if (in_array($user, $users)) {
            return false;
        }
        $this->saveVote($user, $parentId, $parentType);
        return true;
    }

    /**
     * Control if user has already liked or not
     * @param string $user
     * @param array $params

There is no parameter named $params. Was it maybe removed?

     *
     * @return bool
     */
    public function dislike($user, $parentId, $parentType)

This method seems to be duplicated in your project.

    {
        $likes = $this->findAllWhere("parentId = ? AND parentType = ?", [$parentId, $parentType]);
        // Return users of the ones who have downvoted.
        $users = array_map(function ($like) {
            return $like->downVote != null ? $like->user : "";
        }, $likes);

        if (in_array($user, $users)) {
            return false;
        }
        $this->saveVote($user, $parentId, $parentType, "downVote");
        return true;
    }
}