Nicklas\Comment\HTMLForm\Comment\EditPostForm

Complexity

Total Complexity

6

Size/Duplication

Total Lines	69
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	28	28	2
B	callbackSubmit()	26	26	4

<?php

namespace Nicklas\Comment\HTMLForm\Comment;

use \Anax\HTMLForm\FormModel;
use \Anax\DI\DIInterface;
use \Nicklas\Comment\Modules\User;
use \Nicklas\Comment\Modules\Post;

/**
 * Example of FormModel implementation.
 */
class EditPostForm extends FormModel

This class seems to be duplicated in your project.

{
    /**
     * Constructor injects with DI container.
     *
     * @param Anax\DI\DIInterface $di a service container
     */
    public function __construct(DIInterface $di, $id)
    {
        parent::__construct($di);
        $this->post     = new Post($di->get("db"));

The property post does not exist. Did you maybe forget to declare it?

        $this->post->find("id", $id);
        if ($this->post->id == null) {
            $di->get("response")->redirect("question");
        }
        $this->form->create(
            [
                "id" => __CLASS__,
                "legend" => "Här kan du uppdatera din post"
            ],
            [
                "text" => [
                    "type"  => "textarea",
                    "value" => $this->post->text,
                    "label" => "Här kan du skriva din fråga",
                    "placeholder" => "Din fråga"
                ],
                "submit" => [
                    "type" => "submit",
                    "value" => "Spara",
                    "callback" => [$this, "callbackSubmit"]
                ],
            ]
        );
    }

    /**
     * Callback for submit-button which should return true if it could
     * carry out its work and false if something failed.
     *
     * @return boolean true if okey, false if something went wrong.
     */
    public function callbackSubmit()
    {
        // Get values from the submitted form
        $text = $this->form->value("text");

        if (!$this->di->get('session')->has("user")) {
            $this->form->addOutput("Du behöver logga in");
            return false;
        }

        $user = new User($this->di->get("db"));
        if ($user->controlAuthority($this->di->get('session')->get("user"), $this->post->user) != true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison !== instead.

            $this->form->addOutput("Du får inte redigera denna.");
            return false;
        }

        if ($text == "") {
            $this->form->addOutput("Du skrev aldrig något. Skriv gärna något.");
            return false;
        }

        $this->post->text = $text;
        $this->post->save();
        $this->form->addOutput("Du har uppdaterat inlägget");
        return true;
    }
}