Nickbur / Sunrise-CMS

engine/library/Session.php

<?php
/* 	Divine CMS - Open source CMS for widespread use.
    Copyright (c) 2019 Mykola Burakov (burakov.work@gmail.com)

    See SOURCE.txt for other and additional information.

    This file is part of Divine CMS.

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program. If not, see <http://www.gnu.org/licenses/>. */

namespace Divine\Engine\Library;

class Session implements \SessionHandlerInterface
{
    // public $data = array();
    // public $expire;

    public function __construct($registry)
    {
        // доступ к БД
        $this->dbhProperties = $registry->get('dbhProperties');

The property dbhProperties does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        bdump($this->dbhProperties);

        // $expire = ini_get('session.gc_maxlifetime');

        // Устанавливает пользовательские обработчики хранения сессии
        // https://www.php.net/manual/ru/function.session-set-save-handler.php
        session_set_save_handler(new \RememberMe\RememberMeSessionHandler($this->dbhProperties), true);

        // if (!session_id()) {

        // https://www.php.net/manual/en/session.configuration.php#ini.session.cookie-secure
        ini_set('session.cookie_secure', '1');

        // https://www.php.net/manual/en/session.configuration.php#ini.session.cookie-httponly
        ini_set('session.cookie_httponly', '1');

        // https://www.php.net/manual/ru/function.session-set-cookie-params.php
        // session_set_cookie_params(0, '/');

        // стартуем сессию
        session_start();
        // }
    }

    // public function __construct($registry)
    // {
    //     $this->db = $registry->get('db');
    //     $this->expire = ini_get('session.gc_maxlifetime');
    // }

    public function start($key = 'default', $value = '')

The parameter $key is not used and could be removed.

The parameter $value is not used and could be removed.

    {
        // по-умолчанию передается пустое значение
        // if ($value) {
        // $this->session_id = $value;
        // если в куках уже существует значение
        // } elseif (isset($_COOKIE[$key])) {
        // делаем session_id таким же
        // $this->session_id = $_COOKIE[$key];
        // если в куках значения нет, то создаем новое значение методом createSessionId()
        // } else {
        $this->session_id = $this->createSessionId();

The property session_id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        // }

        // if (!isset($_SESSION[$this->session_id])) {
        //     $_SESSION[$this->session_id] = array();
        // }

        // $this->data = &$_SESSION[$this->session_id];

        // https://opencartforum.com/topic/82248-nastroyki-sessii/?do=findComment&comment=935102
        // if ($key != 'PHPSESSID') {
        //     setcookie(
        //         $key,
        //         $this->session_id,
        //         time() + ini_get('session.cookie_lifetime'),
        //         ini_get('session.cookie_path'),
        //         ini_get('session.cookie_domain'),
        //         ini_get('session.cookie_secure'),
        //         ini_get('session.cookie_httponly')
        //     );
        // }

        return $this->session_id;
    }

    public function open($path, $name)
    {
        return parent::open($path, $name);
    }

    public function close()
    {
        return parent::close();
    }

    public function read($session_id)
    {
        return parent::read($session_id);
    }

    // public function read($session_id)
    // {
    //     $query = $this->db->query("
    //         SELECT data 
    //         FROM session 
    //         WHERE session_id = '" . $this->db->escape($session_id) . "' 
    //             AND expire > '" . $this->db->escape(date('Y-m-d H:i:s', time())) . "'
    //     ");

    //     if ($query->num_rows) {
    //         return json_decode($query->row['data'], true);
    //     } else {
    //         return false;
    //     }
    // }

    public function write($session_id, $data)
    {
        return parent::write($session_id, $data);
    }

    // public function write($session_id, $data)
    // {
    //     if ($session_id) {
    //         $this->db->query("
    //             REPLACE INTO session 
    //             SET session_id = '" . $this->db->escape($session_id) . "', 
    //                 data = '" . $this->db->escape(json_encode($data)) . "', 
    //                 expire = '" . $this->db->escape(date('Y-m-d H:i:s', time() + $this->expire)) . "'
    //         ");
    //     }

    //     return true;
    // }

    public function destroy($session_id)
    {
        return parent::destroy($session_id);
    }

    // public function destroy($key = 'default')
    // {
    //     if (isset($_SESSION[$key])) {
    //         unset($_SESSION[$key]);
    //     }

    //     setcookie(
    //         $key,
    //         '',
    //         time() - 42000,
    //         ini_get('session.cookie_path'),
    //         ini_get('session.cookie_domain')
    //     );
    // }

    // public function destroy($session_id)
    // {
    //     $this->db->query("
    //         DELETE FROM session 
    //         WHERE session_id = '" . $this->db->escape($session_id) . "'
    //     ");

    //     return true;
    // }

    public function gc($maxlifetime)
    {
        return parent::gc($maxlifetime);
    }

    // public function gc($expire)
    // {
    //     $this->db->query("
    //         DELETE FROM session 
    //         WHERE expire < '" . $this->db->escape(date('Y-m-d H:i:s', time())) . "'
    //     ");

    //     return true;
    // }

    public function create_sid()

Method name "Session::create_sid" is not in camel caps format

    {
        $id = substr(bin2hex(openssl_random_pseudo_bytes(48)), 0, 48);

        return $id;
    }

    public function createSessionId()
    {
        $id = substr(bin2hex(openssl_random_pseudo_bytes(26)), 0, 26);

        return $id;
    }

    public function getSessionId()
    {
        return $this->session_id;
    }
}