Nickbur / Sunrise-CMS

engine/library/Log.php

<?php
/* 	Divine CMS - Open source CMS for widespread use.
    Copyright (c) 2019 Mykola Burakov (burakov.work@gmail.com)

    See SOURCE.txt for other and additional information.

    This file is part of Divine CMS.

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program. If not, see <http://www.gnu.org/licenses/>. */

namespace Divine\Engine\Library;

class Log
{
    private $handle;

    public function __construct($filename)

Expected 2 blank lines before function; 1 found

    {
        $this->handle = fopen($_SERVER['DOCUMENT_ROOT'] . '/storage/logs/' . $filename, 'a');
    }

    public function write($message)
    {
        fwrite($this->handle, date('Y-m-d G:i:s') . ' - ' . print_r($message, true) . "\n");

It seems like $this->handle can also be of type boolean; however, parameter $handle of fwrite() does only seem to accept resource, maybe add an additional type check?

    }

    public function __destruct()
    {
        fclose($this->handle);

It seems like $this->handle can also be of type boolean; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

    }
}