Issues in article.php (develop) - Issues in develop - Nickbur/Sunrise-CMS - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2407)

application/model/blog/article.php (28 issues)

Labels

Severity

<?php

/* 	Divine CMS - Open source CMS for widespread use.
    Copyright (c) 2019 Mykola Burakov ([email protected])

    See SOURCE.txt for other and additional information.

    This file is part of Divine CMS.

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program. If not, see <http://www.gnu.org/licenses/>. */

class ModelBlogArticle extends \Divine\Engine\Core\Model
namespace YourVendor;

class YourClass { }
{
    public function updateViewed($article_id)

    {
        $this->db->query("
            UPDATE article SET viewed = (viewed + 1) 
            WHERE article_id = '" . (int)$article_id . "'
        ");
    }

    public function getArticle($article_id)
    {
        if ($this->customer->isLogged()) {
            $customer_group_id = $this->customer->getGroupId();

        } else {
            $customer_group_id = $this->config->get('config_customer_group_id');
        }

        $query = $this->db->query("
            SELECT DISTINCT *, pd.name AS name, p.image, (SELECT COUNT(*) AS total 
                FROM review_article r2 
                WHERE r2.article_id = p.article_id 
                AND r2.status = '1' 
                GROUP BY r2.article_id) AS reviews, p.sort_order 
            FROM article p 
            LEFT JOIN article_description pd ON (p.article_id = pd.article_id) 
            WHERE p.article_id = '" . (int)$article_id . "' 
                AND pd.language_id = '" . (int)$this->config->get('config_language_id') . "' 
                AND p.status = '1'
        ");

        if ($query->num_rows) {
            return array(
                'meta_title'       => $query->row['meta_title'],
                'noindex'          => $query->row['noindex'],
                'meta_h1'          => $query->row['meta_h1'],
                'article_id'       => $query->row['article_id'],
                'name'             => $query->row['name'],
                'description'      => $query->row['description'],
                'meta_description' => $query->row['meta_description'],
                'image'            => $query->row['image'],
                'reviews'          => $query->row['reviews'],
                'sort_order'       => $query->row['sort_order'],
                'article_review'   => $query->row['article_review'],
                'status'           => $query->row['status'],
                'gstatus'           => $query->row['gstatus'],
                'date_added'       => $query->row['date_added'],
                'date_modified'    => $query->row['date_modified'],
                'viewed'           => $query->row['viewed']
            );
        } else {
            return false;
        }
    }

    public function getArticles($data = array())
    {
        if ($this->customer->isLogged()) {
            $customer_group_id = $this->customer->getGroupId();
        } else {
            $customer_group_id = $this->config->get('config_customer_group_id');
        }

        $cache = md5(http_build_query($data));

        $article_data = $this->cache->get('article.' . (int)$this->config->get('config_language_id') . '.0.' . (int)$customer_group_id . '.' . $cache);

        if (!$article_data) {
            $sql = "
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                SELECT p.article_id 
                FROM article p 
                LEFT JOIN article_description pd ON (p.article_id = pd.article_id) 
            ";

            if (!empty($data['filter_category_id'])) {
                $sql .= " 
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    LEFT JOIN article_to_blog_category p2c ON (p.article_id = p2c.article_id)
                ";
            }

            $sql .= " 
                WHERE pd.language_id = '" . (int)$this->config->get('config_language_id') . "' 
                    AND p.status = '1'
            ";

            if (!empty($data['filter_name']) || !empty($data['filter_tag'])) {
                $sql .= " AND (";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

                if (!empty($data['filter_name'])) {
                    if (!empty($data['filter_description'])) {
                        $sql .= "LCASE(pd.name) LIKE '%" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "%' OR MATCH(pd.description) AGAINST('" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "')";
                    } else {
                        $sql .= "LCASE(pd.name) LIKE '%" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "%'";
                    }
                }

                if (!empty($data['filter_name']) && !empty($data['filter_tag'])) {
                    $sql .= " OR ";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                }

                if (!empty($data['filter_tag'])) {
                    $sql .= "MATCH(pd.tag) AGAINST('" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_tag'])) . "')";
                }

                $sql .= ")";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.model) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.sku) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.upc) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.ean) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.jan) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.isbn) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.mpn) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }
            }

            if (!empty($data['filter_category_id'])) {
                if (!empty($data['filter_sub_category'])) {
                    $implode_data = array();

                    $implode_data[] = (int)$data['filter_category_id'];

                    $this->load->model('blog/category');

                    $categories = $this->model_blog_category->getCategoriesByParentId($data['filter_category_id']);

                    foreach ($categories as $blog_category_id) {
                        $implode_data[] = (int)$blog_category_id;
                    }

                    $sql .= " AND p2c.blog_category_id IN (" . implode(', ', $implode_data) . ")";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                } else {
                    $sql .= " AND p2c.blog_category_id = '" . (int)$data['filter_category_id'] . "'";
                }
            }

            $sql .= " GROUP BY p.article_id";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

            $sort_data = array(
                'pd.name',
                'p.viewed',
                'p.sort_order',
                'p.date_added'
            );

            if (isset($data['sort']) && in_array($data['sort'], $sort_data)) {
                if ($data['sort'] == 'pd.name' || $data['sort'] == 'p.model' || $data['sort'] == 'p.date_added') {
                    $sql .= " ORDER BY LCASE(" . $data['sort'] . ")";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                } else {
                    $sql .= " ORDER BY " . $data['sort'];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                }
            } else {
                $sql .= " ORDER BY p.sort_order";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }

            if (isset($data['order']) && ($data['order'] == 'DESC')) {
                $sql .= " DESC, LCASE(pd.name) DESC";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            } else {
                $sql .= " ASC, LCASE(pd.name) ASC";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }

            if (isset($data['start']) || isset($data['limit'])) {
                if ($data['start'] < 0) {
                    $data['start'] = 0;
                }

                if ($data['limit'] < 1) {
                    $data['limit'] = 20;
                }

                $sql .= " LIMIT " . (int)$data['start'] . "," . (int)$data['limit'];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }

            $article_data = array();

            $query = $this->db->query($sql);

            foreach ($query->rows as $result) {
                $article_data[$result['article_id']] = $this->getArticle($result['article_id']);
            }

            //$this->cache->set(
            //     'article.' . (int)$this->config->get('config_language_id') . '.0.' . (int)$customer_group_id . '.' . $cache,
            //     $article_data
            // );
        }

        return $article_data;
    }

    public function getLatestArticles($limit)
    {
        if ($this->customer->isLogged()) {
            $customer_group_id = $this->customer->getGroupId();
        } else {
            $customer_group_id = $this->config->get('config_customer_group_id');
        }

        $article_data = $this->cache->get('article.latest.' . (int)$this->config->get('config_language_id') . '.0.' . $customer_group_id . '.' . (int)$limit);

        if (!$article_data) {
            $query = $this->db->query(
                "
                SELECT p.article_id 
                FROM article p 
                WHERE p.status = '1'
                ORDER BY p.date_added DESC 
                LIMIT " . (int)$limit
            );

            foreach ($query->rows as $result) {
                $article_data[$result['article_id']] = $this->getArticle($result['article_id']);
            }

            $this->cache->set(
                'article.latest.' . (int)$this->config->get('config_language_id') . '.0.' . $customer_group_id . '.' . (int)$limit,
                $article_data
            );
        }

        return $article_data;
    }

    public function getPopularArticles($limit)
    {
        $article_data = array();

        $query = $this->db->query(
            "
            SELECT p.article_id 
            FROM article p 
            WHERE p.status = '1'
            ORDER BY p.viewed DESC, p.date_added DESC 
            LIMIT " . (int)$limit
        );

        foreach ($query->rows as $result) {
            $article_data[$result['article_id']] = $this->getArticle($result['article_id']);
        }

        return $article_data;
    }

    public function getArticleImages($article_id)
    {
        $query = $this->db->query("
            SELECT * 
            FROM article_image 
            WHERE article_id = '" . (int)$article_id . "' 
            ORDER BY sort_order ASC
        ");

        return $query->rows;
    }

    public function getArticleRelated($article_id)
    {
        $article_data = array();

        $query = $this->db->query("
            SELECT * FROM article_related pr 
            LEFT JOIN article p ON (pr.related_id = p.article_id) 
            WHERE pr.article_id = '" . (int)$article_id . "' 
                AND p.status = '1'
        ");

        foreach ($query->rows as $result) {
            $article_data[$result['related_id']] = $this->getArticle($result['related_id']);
        }

        return $article_data;
    }

    public function getArticleRelatedByProduct($data)
    {
        $article_data = array();

        $this->load->model('blog/article');

        $sql = "
            SELECT * 
            FROM product_related_article np 
            LEFT JOIN article p ON (np.article_id = p.article_id) 
            WHERE np.product_id = '" . (int)$data['product_id'] . "' 
                AND p.status = '1'
            LIMIT " . $data['limit'];

        $query = $this->db->query($sql);

        foreach ($query->rows as $result) {
            $article_data[$result['article_id']] = $this->model_blog_article->getArticle($result['article_id']);
        }

        return $article_data;
    }

    //category manuf
    public function getArticleRelatedByCategory($data)
    {
        $article_data = array();

        $query = $this->db->query(
            "
            SELECT * 
            FROM article_related_wb pr 
            LEFT JOIN article p ON (pr.article_id = p.article_id) 
            WHERE pr.category_id = '" . (int)$data['category_id'] . "' 
                AND p.status = '1'
            LIMIT " . (int)$data['limit']
        );

        foreach ($query->rows as $result) {
            $article_data[$result['article_id']] = $this->getArticle($result['article_id']);
        }

        return $article_data;
    }

    public function getArticleRelatedByManufacturer($data)
    {
        $article_data = array();

        $query = $this->db->query(
            "
            SELECT * 
            FROM article_related_mn pr 
            LEFT JOIN article p ON (pr.article_id = p.article_id) 
            WHERE pr.manufacturer_id = '" . (int)$data['manufacturer_id'] . "' 
                AND p.status = '1'
            LIMIT " . (int)$data['limit']
        );

        foreach ($query->rows as $result) {
            $article_data[$result['article_id']] = $this->getArticle($result['article_id']);
        }



        return $article_data;
    }
    //category manuf

    public function getArticleRelatedProduct($article_id)
    {
        $product_data = array();
        $this->load->model('catalog/product');
        $query = $this->db->query("
            SELECT * FROM article_related_product np 
            LEFT JOIN product p ON (np.product_id = p.product_id) 
            WHERE np.article_id = '" . (int)$article_id . "' 
                AND p.status = '1'
        ");

        foreach ($query->rows as $result) {
            $product_data[$result['product_id']] = $this->model_catalog_product->getProduct($result['product_id']);
        }

        return $product_data;
    }

    public function getArticleLayoutId($article_id)
    {
        $query = $this->db->query("
            SELECT * 
            FROM article_to_layout 
            WHERE article_id = '" . (int)$article_id . "'
        ");

        if ($query->num_rows) {
            return $query->row['layout_id'];
        } else {
            return  $this->config->get('config_layout_article');
        }
    }

    public function getCategories($article_id)
    {
        $query = $this->db->query("
            SELECT * 
            FROM article_to_blog_category 
            WHERE article_id = '" . (int)$article_id . "'
        ");

        return $query->rows;
    }

    public function getDownloads($article_id)
    {
        $query = $this->db->query("
            SELECT * 
            FROM article_to_download pd 
            LEFT JOIN download d ON(pd.download_id=d.download_id) 
            LEFT JOIN download_description dd ON(pd.download_id=dd.download_id) 
            WHERE article_id = '" . (int)$article_id . "' 
                AND dd.language_id = '" . (int)$this->config->get('config_language_id') . "'
        ");

        return $query->rows;
    }

    public function getDownload($article_id, $download_id)
    {
        $download = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        if ($download_id != 0) {
            $download = " AND d.download_id=" . (int)$download_id;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        $query = $this->db->query("
            SELECT * 
            FROM article_to_download pd 
            LEFT JOIN download d ON(pd.download_id=d.download_id) 
            LEFT JOIN download_description dd ON(pd.download_id=dd.download_id) 
            WHERE article_id = '" . (int)$article_id . "' " . $download . " 
                AND dd.language_id = '" . (int)$this->config->get('config_language_id') . "'
        ");

        return $query->row;
    }

    public function getTotalArticles($data = array())
    {
        if ($this->customer->isLogged()) {
            $customer_group_id = $this->customer->getGroupId();
        } else {
            $customer_group_id = $this->config->get('config_customer_group_id');
        }

        $cache = md5(http_build_query($data));

        $article_data = $this->cache->get('article.total.' . (int)$this->config->get('config_language_id') . '.0.' . (int)$customer_group_id . '.' . $cache);

        if (!$article_data) {
            $sql = "
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                SELECT COUNT(DISTINCT p.article_id) AS total 
                FROM article p 
                LEFT JOIN article_description pd ON (p.article_id = pd.article_id) 
            ";

            if (!empty($data['filter_blog_category_id'])) {
                $sql .= " 
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    LEFT JOIN article_to_blog_category p2c ON (p.article_id = p2c.article_id)
                ";
            }

            $sql .= " 
                WHERE pd.language_id = '" . (int)$this->config->get('config_language_id') . "' 
                AND p.status = '1'
            ";

            if (!empty($data['filter_name']) || !empty($data['filter_tag'])) {
                $sql .= " AND (";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

                if (!empty($data['filter_name'])) {
                    if (!empty($data['filter_description'])) {
                        $sql .= "
                            LCASE(pd.name) LIKE '%" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "%' 
                            OR MATCH(pd.description) 
                            AGAINST('" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "')
                        ";
                    } else {
                        $sql .= "
                            LCASE(pd.name) LIKE '%" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "%'
                        ";
                    }
                }

                if (!empty($data['filter_name']) && !empty($data['filter_tag'])) {
                    $sql .= " OR ";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                }

                if (!empty($data['filter_tag'])) {
                    $sql .= "MATCH(pd.tag) AGAINST('" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_tag'])) . "')";
                }

                $sql .= ")";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.model) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.sku) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.upc) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.ean) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.jan) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.isbn) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }

                if (!empty($data['filter_name'])) {
                    $sql .= " OR LCASE(p.mpn) = '" . $this->db->escape(\voku\helper\UTF8::strtolower($data['filter_name'])) . "'";
                }
            }

            if (!empty($data['filter_blog_category_id'])) {
                if (!empty($data['filter_sub_blog_category'])) {
                    $implode_data = array();

                    $implode_data[] = (int)$data['filter_blog_category_id'];

                    $this->load->model('blog/category');

                    $categories = $this->model_blog_category->getCategoriesByParentId($data['filter_category_id']);

                    foreach ($categories as $blog_category_id) {
                        $implode_data[] = (int)$blog_category_id;
                    }

                    $sql .= " AND p2c.blog_category_id IN (" . implode(', ', $implode_data) . ")";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                } else {
                    $sql .= " AND p2c.blog_category_id = '" . (int)$data['filter_blog_category_id'] . "'";
                }
            }

            $query = $this->db->query($sql);

            $article_data = $query->row['total'];

            $this->cache->set(
                'article.total.' . (int)$this->config->get('config_language_id') . '.0.' . (int)$customer_group_id . '.' . $cache,
                $article_data
            );
        }

        return $article_data;
    }
}

1			<?php
2
3			/* Divine CMS - Open source CMS for widespread use.
4			Copyright (c) 2019 Mykola Burakov ([email protected])
5
6			See SOURCE.txt for other and additional information.
7
8			This file is part of Divine CMS.
9
10			This program is free software: you can redistribute it and/or modify
11			it under the terms of the GNU General Public License as published by
12			the Free Software Foundation, either version 3 of the License, or
13			(at your option) any later version.
14
15			This program is distributed in the hope that it will be useful,
16			but WITHOUT ANY WARRANTY; without even the implied warranty of
17			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18			GNU General Public License for more details.
19
20			You should have received a copy of the GNU General Public License
21			along with this program. If not, see <http://www.gnu.org/licenses/>. */
22
23			class ModelBlogArticle extends \Divine\Engine\Core\Model
			0 ignored issues – show Coding Style Compatibility introduced 2019-07-29 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
24			{
25			public function updateViewed($article_id)
			0 ignored issues – show Coding Style introduced 2019-07-29 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 2 blank lines before function; 0 found Loading history...
26			{
27			$this->db->query("
28			UPDATE article SET viewed = (viewed + 1)
29			WHERE article_id = '" . (int)$article_id . "'
30			");
31			}
32
33			public function getArticle($article_id)
34			{
35			if ($this->customer->isLogged()) {
36			$customer_group_id = $this->customer->getGroupId();
			0 ignored issues – show Unused Code introduced 2019-07-29 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$customer_group_id` is dead and can be removed. Loading history...
37			} else {
Nickbur / Sunrise-CMS

Issues (2407)

application/model/blog/article.php (28 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like
