Nickbur / Sunrise-CMS

application/controller/extension/module/blog_popular.php

<?php

/* 	Divine CMS - Open source CMS for widespread use.
    Copyright (c) 2019 Mykola Burakov (burakov.work@gmail.com)

    See SOURCE.txt for other and additional information.

    This file is part of Divine CMS.

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program. If not, see <http://www.gnu.org/licenses/>. */

class ControllerExtensionModuleBlogPopular extends \Divine\Engine\Core\Controller

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function index($setting)

Expected 2 blank lines before function; 0 found

    {
        $this->load->language('extension/module/blog_popular');

        $data['heading_title'] = $this->language->get('heading_title');

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        $data['text_views'] = $this->language->get('text_views');
        $data['button_more'] = $this->language->get('button_more');

        $this->load->model('blog/article');

        

        $data['articles'] = array();

        $filter_data = array(
            'sort'  => 'p.viewed',
            'order' => 'DESC',
            'start' => 0,
            'limit' => $setting['limit']
        );

        $results = $this->model_blog_article->getArticles($filter_data);

        if ($results) {
            foreach ($results as $result) {
                if ($result['image']) {
                    $image = '/public_html/assets/images/' . $result['image'];
                } else {
                    $image = '/public_html/assets/images/no_image.png';
                }

                $data['configblog_review_status'] = $this->config->get('configblog_review_status');

                $data['articles'][] = array(
                    'article_id'  => $result['article_id'],
                    'thumb'       => $image,
                    'name'        => $result['name'],
                    'description' => \voku\helper\UTF8::substr(strip_tags(html_entity_decode($result['description'], ENT_QUOTES, 'UTF-8')), 0, $this->config->get('configblog_article_description_length')) . '..',

Are you sure voku\helper\UTF8::substr(strip_tags(html_entity_decode($result['description'], ENT_QUOTES, 'UTF-8')), 0, $this->config->get('configblog_article_description_length')) of type false|string can be used in concatenation?

                    'date_added'  => date($this->language->get('date_format_short'), strtotime($result['date_added'])),
                    'viewed'      => $result['viewed'],
                    'reviews'    => sprintf($this->language->get('text_reviews'), (int)$result['reviews']),
                    'href'        => $this->url->link('blog/article', 'article_id=' . $result['article_id']),
                );
            }

            return $this->load->view('extension/module/blog_popular', $data);
        }
    }
}