Nickbur / Sunrise-CMS

administration/model/localisation/currency.php

<?php

/* 	Divine CMS - Open source CMS for widespread use.
    Copyright (c) 2019 Mykola Burakov (burakov.work@gmail.com)

    See SOURCE.txt for other and additional information.

    This file is part of Divine CMS.

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program. If not, see <http://www.gnu.org/licenses/>. */

class ModelLocalisationCurrency extends \Divine\Engine\Core\Model

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function addCurrency($data)

Expected 2 blank lines before function; 0 found

    {
        $this->db->query("
			INSERT INTO currency 
			SET title = '" . $this->db->escape($data['title']) . "', 
				code = '" . $this->db->escape($data['code']) . "', 
				symbol_left = '" . $this->db->escape($data['symbol_left']) . "', 
				symbol_right = '" . $this->db->escape($data['symbol_right']) . "', 
				decimal_place = '" . $this->db->escape($data['decimal_place']) . "', 
				value = '" . $this->db->escape($data['value']) . "', 
				status = '" . (int)$data['status'] . "', 
				date_modified = NOW()
		");

        $currency_id = $this->db->getLastId();

        if ($this->config->get('config_currency_auto')) {
            $this->refresh(true);

The method refresh() does not exist on ModelLocalisationCurrency.

        }

        $this->cache->delete('currency');

        return $currency_id;
    }

    public function editCurrency($currency_id, $data)
    {
        $this->db->query("
			UPDATE currency 
			SET title = '" . $this->db->escape($data['title']) . "', 
				code = '" . $this->db->escape($data['code']) . "', 
				symbol_left = '" . $this->db->escape($data['symbol_left']) . "', 
				symbol_right = '" . $this->db->escape($data['symbol_right']) . "', 
				decimal_place = '" . $this->db->escape($data['decimal_place']) . "', 
				value = '" . $this->db->escape($data['value']) . "', 
				status = '" . (int)$data['status'] . "', 
				date_modified = NOW() 
			WHERE currency_id = '" . (int)$currency_id . "'
		");

        $this->cache->delete('currency');
    }

    public function deleteCurrency($currency_id)
    {
        $this->db->query("
			DELETE 
			FROM currency 
			WHERE currency_id = '" . (int)$currency_id . "'
		");

        $this->cache->delete('currency');
    }

    public function getCurrency($currency_id)
    {
        $query = $this->db->query("
			SELECT DISTINCT * 
			FROM currency 
			WHERE currency_id = '" . (int)$currency_id . "'
		");

        return $query->row;
    }

    public function getCurrencyByCode($currency)
    {
        $query = $this->db->query("
			SELECT DISTINCT * 
			FROM currency 
			WHERE code = '" . $this->db->escape($currency) . "'
		");

        return $query->row;
    }

    public function getCurrencies($data = array())
    {
        if ($data) {
            $sql = "

The string literal \n SELECT * \n FROM currency\n does not require double quotes, as per coding-style, please use single quotes.

				SELECT * 
				FROM currency
			";

            $sort_data = array(
                'title',
                'code',
                'value',
                'date_modified'
            );

            if (isset($data['sort']) && in_array($data['sort'], $sort_data)) {
                $sql .= " ORDER BY " . $data['sort'];

The string literal ORDER BY does not require double quotes, as per coding-style, please use single quotes.

            } else {
                $sql .= " ORDER BY title";

The string literal ORDER BY title does not require double quotes, as per coding-style, please use single quotes.

            }

            if (isset($data['order']) && ($data['order'] == 'DESC')) {
                $sql .= " DESC";

The string literal DESC does not require double quotes, as per coding-style, please use single quotes.

            } else {
                $sql .= " ASC";

The string literal ASC does not require double quotes, as per coding-style, please use single quotes.

            }

            if (isset($data['start']) || isset($data['limit'])) {
                if ($data['start'] < 0) {
                    $data['start'] = 0;
                }

                if ($data['limit'] < 1) {
                    $data['limit'] = 20;
                }

                $sql .= " LIMIT " . (int)$data['start'] . "," . (int)$data['limit'];

The string literal LIMIT does not require double quotes, as per coding-style, please use single quotes.

The string literal , does not require double quotes, as per coding-style, please use single quotes.

            }

            $query = $this->db->query($sql);

            return $query->rows;
        } else {
            $currency_data = $this->cache->get('currency');

            if (!$currency_data) {
                $currency_data = array();

                $query = $this->db->query("

The string literal \n SELECT * \n FROM currency ORDER BY title ASC\n does not require double quotes, as per coding-style, please use single quotes.

					SELECT * 
					FROM currency ORDER BY title ASC
				");

                foreach ($query->rows as $result) {
                    $currency_data[$result['code']] = array(
                        'currency_id'   => $result['currency_id'],
                        'title'         => $result['title'],
                        'code'          => $result['code'],
                        'symbol_left'   => $result['symbol_left'],
                        'symbol_right'  => $result['symbol_right'],
                        'decimal_place' => $result['decimal_place'],
                        'value'         => $result['value'],
                        'status'        => $result['status'],
                        'date_modified' => $result['date_modified']
                    );
                }

                $this->cache->set(
                    'currency',
                    $currency_data
                );
            }

            return $currency_data;
        }
    }

    public function refresh($force = false)
    {
        $data = array();

        if ($force) {
            $query = $this->db->query("
				SELECT * 
				FROM currency 
				WHERE code != '" . $this->db->escape($this->config->get('config_currency')) . "'
			");
        } else {
            $query = $this->db->query("
				SELECT * 
				FROM currency 
				WHERE code != '" . $this->db->escape($this->config->get('config_currency')) . "' 
					AND date_modified < '" .  $this->db->escape(date('Y-m-d H:i:s', strtotime('-1 day'))) . "'
			");
        }

        foreach ($query->rows as $result) {
            $data[] = $this->config->get('config_currency') . $result['code'] . '=X';
        }

        $curl = curl_init();

        curl_setopt($curl, CURLOPT_URL, 'http://download.finance.yahoo.com/d/quotes.csv?s=' . implode(',', $data) . '&f=sl1&e=.csv');

It seems like $curl can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        curl_setopt($curl, CURLOPT_RETURNTRANSFER, 1);
        curl_setopt($curl, CURLOPT_HEADER, false);
        curl_setopt($curl, CURLOPT_CONNECTTIMEOUT, 30);
        curl_setopt($curl, CURLOPT_TIMEOUT, 30);

        $content = curl_exec($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        curl_close($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        $lines = explode("\n", trim($content));

        foreach ($lines as $line) {
            $currency = \voku\helper\UTF8::substr($line, 4, 3);
            $value = \voku\helper\UTF8::substr($line, 11, 6);

            if ((float)$value) {
                $this->db->query("
					UPDATE currency 
					SET value = '" . (float)$value . "', 
						date_modified = '" .  $this->db->escape(date('Y-m-d H:i:s')) . "' 
					WHERE code = '" . $this->db->escape($currency) . "'
				");
            }
        }

        $this->db->query("
			UPDATE currency 
			SET value = '1.00000', 
				date_modified = '" .  $this->db->escape(date('Y-m-d H:i:s')) . "' 
			WHERE code = '" . $this->db->escape($this->config->get('config_currency')) . "'
		");

        $this->cache->delete('currency');
    }

    public function getTotalCurrencies()
    {
        $query = $this->db->query("

The string literal \n SELECT COUNT(*) AS total \n FROM currency\n does not require double quotes, as per coding-style, please use single quotes.

			SELECT COUNT(*) AS total 
			FROM currency
		");

        return $query->row['total'];
    }
}