Nickbur / Sunrise-CMS

administration/controller/extension/extension.php

<?php
/* 	Divine CMS - Open source CMS for widespread use.
    Copyright (c) 2019 Mykola Burakov (burakov.work@gmail.com)
    See SOURCE.txt for other and additional information.
    This file is part of Divine CMS.
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
    GNU General Public License for more details.
    You should have received a copy of the GNU General Public License
    along with this program. If not, see <http://www.gnu.org/licenses/>. */
class ControllerExtensionExtension extends \Divine\Engine\Core\Controller

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private $error = array();

The private property $error is not used, and could be removed.

    public function index()

Expected 2 blank lines before function; 1 found

    {
        $this->load->language('extension/extension');
        $this->document->setTitle($this->language->get('heading_title'));

        $data['breadcrumbs'] = array();

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        $data['breadcrumbs'][] = array(
            'text' => $this->language->get('text_home'),
            'href' => $this->url->link('common/dashboard', 'token=' . $this->session->data['token'], true)
        );

        $data['breadcrumbs'][] = array(
            'text' => $this->language->get('heading_title'),
            'href' => $this->url->link('extension/extension', 'token=' . $this->session->data['token'], true)
        );

        $data['heading_title'] = $this->language->get('heading_title');
        $data['text_list'] = $this->language->get('text_list');
        $data['text_type'] = $this->language->get('text_type');
        $data['text_filter'] = $this->language->get('text_filter');
        $data['text_loading'] = $this->language->get('text_loading');
        $data['text_confirm'] = $this->language->get('text_confirm');

        $data['token'] = $this->session->data['token'];

        if (isset($this->request->get['type'])) {
            $data['type'] = $this->request->get['type'];
        } else {
            $data['type'] = 'module';
        }

        $data['categories'] = array();

        $files = glob(SR_APPLICATION . 'controller/extension/extension/*.php', GLOB_BRACE);

        foreach ($files as $file) {
            $extension = basename($file, '.php');

            $this->load->language('extension/extension/' . $extension);

            if ($this->user->hasPermission('access', 'extension/extension/' . $extension)) {
                $files = glob(SR_APPLICATION . 'controller/{extension/' . $extension . ',' . $extension . '}/*.php', GLOB_BRACE);

                $data['categories'][] = array(
                    'code' => $extension,
                    'text' => $this->language->get('heading_title') . ' (' . count($files) . ')',

It seems like $files can also be of type false; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

                    'href' => $this->url->link('extension/extension/' . $extension, 'token=' . $this->session->data['token'], true)
                );
            }
        }

        $data['header'] = $this->load->controller('common/header');
        $data['column'] = $this->load->controller('common/column_left');
        $data['footer'] = $this->load->controller('common/footer');

        $this->response->setOutput($this->load->view('extension/extension', $data));
    }
}