Nickbur /
Sunrise-CMS
| Conditions | 31 |
| Paths | > 20000 |
| Total Lines | 282 |
| Code Lines | 182 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 126 | private function getList() |
||
| 127 | { |
||
| 128 | $this->load->model('tool/seomanager'); |
||
| 129 | |||
| 130 | if (isset($this->request->get['sort'])) { |
||
| 131 | $sort = $this->request->get['sort']; |
||
| 132 | } else { |
||
| 133 | $sort = 'ua.query'; |
||
| 134 | } |
||
| 135 | |||
| 136 | if (isset($this->request->get['order'])) { |
||
| 137 | $order = $this->request->get['order']; |
||
| 138 | } else { |
||
| 139 | $order = 'ASC'; |
||
| 140 | } |
||
| 141 | |||
| 142 | if (isset($this->request->get['page'])) { |
||
| 143 | $page = $this->request->get['page']; |
||
| 144 | } else { |
||
| 145 | $page = 1; |
||
| 146 | } |
||
| 147 | |||
| 148 | $url = ''; |
||
| 149 | |||
| 150 | if (isset($this->request->get['sort'])) { |
||
| 151 | $url .= '&sort=' . $this->request->get['sort']; |
||
| 152 | } |
||
| 153 | |||
| 154 | if (isset($this->request->get['order'])) { |
||
| 155 | $url .= '&order=' . $this->request->get['order']; |
||
| 156 | } |
||
| 157 | |||
| 158 | if (isset($this->request->get['page'])) { |
||
| 159 | $url .= '&page=' . $this->request->get['page']; |
||
| 160 | } |
||
| 161 | |||
| 162 | $data['breadcrumbs'] = array(); |
||
| 163 | |||
| 164 | $data['breadcrumbs'][] = array( |
||
| 165 | 'text' => $this->language->get('text_home'), |
||
| 166 | 'href' => $this->url->link('common/dashboard', 'token=' . $this->session->data['token'], true) |
||
| 167 | ); |
||
| 168 | |||
| 169 | $data['breadcrumbs'][] = array( |
||
| 170 | 'text' => $this->language->get('heading_title'), |
||
| 171 | 'href' => $this->url->link('tool/seomanager', 'token=' . $this->session->data['token'] . $url, true) |
||
| 172 | ); |
||
| 173 | |||
| 174 | //dop |
||
| 175 | $data['action'] = $this->url->link('tool/seomanager', 'token=' . $this->session->data['token'], true); |
||
| 176 | |||
| 177 | $data['cancel'] = $this->url->link('tool/seomanager', 'token=' . $this->session->data['token'], true); |
||
| 178 | |||
| 179 | $data['token'] = $this->session->data['token']; |
||
| 180 | |||
| 181 | $data['entry_name'] = $this->language->get('entry_name'); |
||
| 182 | $data['entry_html_h1'] = $this->language->get('entry_html_h1'); |
||
| 183 | $data['entry_meta_title'] = $this->language->get('entry_meta_title'); |
||
| 184 | $data['entry_meta_description'] = $this->language->get('entry_meta_description'); |
||
| 185 | |||
| 186 | if (isset($this->request->post['seomanager_html_h1_special'])) { |
||
| 187 | $data['seomanager_html_h1_special'] = $this->request->post['seomanager_html_h1_special']; |
||
| 188 | } else { |
||
| 189 | $data['seomanager_html_h1_special'] = $this->config->get('seomanager_html_h1_special'); |
||
| 190 | } |
||
| 191 | |||
| 192 | if (isset($this->request->post['seomanager_meta_title_special'])) { |
||
| 193 | $data['seomanager_meta_title_special'] = $this->request->post['seomanager_meta_title_special']; |
||
| 194 | } else { |
||
| 195 | $data['seomanager_meta_title_special'] = $this->config->get('seomanager_meta_title_special'); |
||
| 196 | } |
||
| 197 | |||
| 198 | if (isset($this->request->post['seomanager_meta_description_special'])) { |
||
| 199 | $data['seomanager_meta_description_special'] = $this->request->post['seomanager_meta_description_special']; |
||
| 200 | } else { |
||
| 201 | $data['seomanager_meta_description_special'] = $this->config->get('seomanager_meta_description_special'); |
||
| 202 | } |
||
| 203 | |||
| 204 | if (isset($this->request->post['seomanager_description_special'])) { |
||
| 205 | $data['seomanager_description_special'] = $this->request->post['seomanager_description_special']; |
||
| 206 | } else { |
||
| 207 | $data['seomanager_description_special'] = $this->config->get('seomanager_description_special'); |
||
| 208 | } |
||
| 209 | |||
| 210 | if (isset($this->request->post['seomanager_html_h1_bestseller'])) { |
||
| 211 | $data['seomanager_html_h1_bestseller'] = $this->request->post['seomanager_html_h1_bestseller']; |
||
| 212 | } else { |
||
| 213 | $data['seomanager_html_h1_bestseller'] = $this->config->get('seomanager_html_h1_bestseller'); |
||
| 214 | } |
||
| 215 | |||
| 216 | if (isset($this->request->post['seomanager_meta_title_bestseller'])) { |
||
| 217 | $data['seomanager_meta_title_bestseller'] = $this->request->post['seomanager_meta_title_bestseller']; |
||
| 218 | } else { |
||
| 219 | $data['seomanager_meta_title_bestseller'] = $this->config->get('seomanager_meta_title_bestseller'); |
||
| 220 | } |
||
| 221 | |||
| 222 | if (isset($this->request->post['seomanager_meta_description_bestseller'])) { |
||
| 223 | $data['seomanager_meta_description_bestseller'] = $this->request->post['seomanager_meta_description_bestseller']; |
||
| 224 | } else { |
||
| 225 | $data['seomanager_meta_description_bestseller'] = $this->config->get('seomanager_meta_description_bestseller'); |
||
| 226 | } |
||
| 227 | |||
| 228 | if (isset($this->request->post['seomanager_description_bestseller'])) { |
||
| 229 | $data['seomanager_description_bestseller'] = $this->request->post['seomanager_description_bestseller']; |
||
| 230 | } else { |
||
| 231 | $data['seomanager_description_bestseller'] = $this->config->get('seomanager_description_bestseller'); |
||
| 232 | } |
||
| 233 | |||
| 234 | if (isset($this->request->post['seomanager_html_h1_latest'])) { |
||
| 235 | $data['seomanager_html_h1_latest'] = $this->request->post['seomanager_html_h1_latest']; |
||
| 236 | } else { |
||
| 237 | $data['seomanager_html_h1_latest'] = $this->config->get('seomanager_html_h1_latest'); |
||
| 238 | } |
||
| 239 | |||
| 240 | if (isset($this->request->post['seomanager_meta_title_latest'])) { |
||
| 241 | $data['seomanager_meta_title_latest'] = $this->request->post['seomanager_meta_title_latest']; |
||
| 242 | } else { |
||
| 243 | $data['seomanager_meta_title_latest'] = $this->config->get('seomanager_meta_title_latest'); |
||
| 244 | } |
||
| 245 | |||
| 246 | if (isset($this->request->post['seomanager_meta_description_latest'])) { |
||
| 247 | $data['seomanager_meta_description_latest'] = $this->request->post['seomanager_meta_description_latest']; |
||
| 248 | } else { |
||
| 249 | $data['seomanager_meta_description_latest'] = $this->config->get('seomanager_meta_description_latest'); |
||
| 250 | } |
||
| 251 | |||
| 252 | if (isset($this->request->post['seomanager_description_latest'])) { |
||
| 253 | $data['seomanager_description_latest'] = $this->request->post['seomanager_description_latest']; |
||
| 254 | } else { |
||
| 255 | $data['seomanager_description_latest'] = $this->config->get('seomanager_description_latest'); |
||
| 256 | } |
||
| 257 | |||
| 258 | if (isset($this->request->post['seomanager_html_h1_mostviewed'])) { |
||
| 259 | $data['seomanager_html_h1_mostviewed'] = $this->request->post['seomanager_html_h1_mostviewed']; |
||
| 260 | } else { |
||
| 261 | $data['seomanager_html_h1_mostviewed'] = $this->config->get('seomanager_html_h1_mostviewed'); |
||
| 262 | } |
||
| 263 | |||
| 264 | if (isset($this->request->post['seomanager_meta_title_mostviewed'])) { |
||
| 265 | $data['seomanager_meta_title_mostviewed'] = $this->request->post['seomanager_meta_title_mostviewed']; |
||
| 266 | } else { |
||
| 267 | $data['seomanager_meta_title_mostviewed'] = $this->config->get('seomanager_meta_title_mostviewed'); |
||
| 268 | } |
||
| 269 | |||
| 270 | if (isset($this->request->post['seomanager_meta_description_mostviewed'])) { |
||
| 271 | $data['seomanager_meta_description_mostviewed'] = $this->request->post['seomanager_meta_description_mostviewed']; |
||
| 272 | } else { |
||
| 273 | $data['seomanager_meta_description_mostviewed'] = $this->config->get('seomanager_meta_description_mostviewed'); |
||
| 274 | } |
||
| 275 | |||
| 276 | if (isset($this->request->post['seomanager_description_mostviewed'])) { |
||
| 277 | $data['seomanager_description_mostviewed'] = $this->request->post['seomanager_description_mostviewed']; |
||
| 278 | } else { |
||
| 279 | $data['seomanager_description_mostviewed'] = $this->config->get('seomanager_description_mostviewed'); |
||
| 280 | } |
||
| 281 | |||
| 282 | //dop |
||
| 283 | |||
| 284 | $data['insert'] = $this->url->link('tool/seomanager/insert', 'token=' . $this->session->data['token'] . $url, true); |
||
| 285 | $data['delete'] = $this->url->link('tool/seomanager/delete', 'token=' . $this->session->data['token'] . $url, true); |
||
| 286 | $data['save'] = $this->url->link('tool/seomanager/update', 'token=' . $this->session->data['token'] . $url, true); |
||
| 287 | $data['clear'] = $this->url->link('tool/seomanager/clear', 'token=' . $this->session->data['token'] . $url, true); |
||
| 288 | |||
| 289 | $data['url_aliases'] = array(); |
||
| 290 | |||
| 291 | $filterdata = array( |
||
| 292 | 'sort' => $sort, |
||
| 293 | 'order' => $order, |
||
| 294 | 'start' => ($page - 1) * $this->config->get('config_limit_admin'), |
||
| 295 | 'limit' => $this->config->get('config_limit_admin') |
||
| 296 | ); |
||
| 297 | |||
| 298 | $url_alias_total = $this->model_tool_seomanager->getTotalUrlAalias(); |
||
| 299 | |||
| 300 | $results = $this->model_tool_seomanager->getUrlAaliases($filterdata); |
||
| 301 | |||
| 302 | foreach ($results as $result) { |
||
| 303 | $data['url_aliases'][] = array( |
||
| 304 | 'url_alias_id' => $result['url_alias_id'], |
||
| 305 | 'query' => $result['query'], |
||
| 306 | 'keyword' => $result['keyword'], |
||
| 307 | 'selected' => isset($this->request->post['selected']) && in_array($result['url_alias_id'], $this->request->post['selected']), |
||
| 308 | 'action_text' => $this->language->get('text_edit') |
||
| 309 | ); |
||
| 310 | } |
||
| 311 | |||
| 312 | $data['heading_title'] = $this->language->get('heading_title'); |
||
| 313 | |||
| 314 | $data['text_no_results'] = $this->language->get('text_no_results'); |
||
| 315 | |||
| 316 | $data['column_query'] = $this->language->get('column_query'); |
||
| 317 | $data['column_keyword'] = $this->language->get('column_keyword'); |
||
| 318 | $data['column_action'] = $this->language->get('column_action'); |
||
| 319 | |||
| 320 | $data['button_insert'] = $this->language->get('button_insert'); |
||
| 321 | $data['button_delete'] = $this->language->get('button_delete'); |
||
| 322 | $data['button_save'] = $this->language->get('button_save'); |
||
| 323 | $data['button_cancel'] = $this->language->get('button_cancel'); |
||
| 324 | $data['button_clear_cache'] = $this->language->get('button_clear_cache'); |
||
| 325 | $data['button_edit'] = $this->language->get('button_edit'); |
||
| 326 | |||
| 327 | $data['entry_name'] = $this->language->get('entry_name'); |
||
| 328 | $data['entry_html_h1'] = $this->language->get('entry_html_h1'); |
||
| 329 | $data['entry_meta_title'] = $this->language->get('entry_meta_title'); |
||
| 330 | $data['entry_meta_description'] = $this->language->get('entry_meta_description'); |
||
| 331 | $data['entry_description'] = $this->language->get('entry_description'); |
||
| 332 | |||
| 333 | $data['tab_seourl'] = $this->language->get('tab_seourl'); |
||
| 334 | $data['tab_meta'] = $this->language->get('tab_meta'); |
||
| 335 | $data['tab_special'] = $this->language->get('tab_special'); |
||
| 336 | $data['tab_bestseller'] = $this->language->get('tab_bestseller'); |
||
| 337 | $data['tab_latest'] = $this->language->get('tab_latest'); |
||
| 338 | $data['tab_mostviewed'] = $this->language->get('tab_mostviewed'); |
||
| 339 | |||
| 340 | if (isset($this->error['warning'])) { |
||
| 341 | $data['error_warning'] = $this->error['warning']; |
||
| 342 | } else { |
||
| 343 | $data['error_warning'] = ''; |
||
| 344 | } |
||
| 345 | |||
| 346 | if (isset($this->session->data['success'])) { |
||
| 347 | $data['success'] = $this->session->data['success']; |
||
| 348 | |||
| 349 | unset($this->session->data['success']); |
||
| 350 | } else { |
||
| 351 | $data['success'] = ''; |
||
| 352 | } |
||
| 353 | |||
| 354 | $url = ''; |
||
| 355 | |||
| 356 | if ($order == 'ASC') { |
||
| 357 | $url .= '&order=DESC'; |
||
| 358 | } else { |
||
| 359 | $url .= '&order=ASC'; |
||
| 360 | } |
||
| 361 | |||
| 362 | if (isset($this->request->get['page'])) { |
||
| 363 | $url .= '&page=' . $this->request->get['page']; |
||
| 364 | } |
||
| 365 | |||
| 366 | $data['breadcrumbs'] = array(); |
||
| 367 | |||
| 368 | $data['breadcrumbs'][] = array( |
||
| 369 | 'text' => $this->language->get('text_home'), |
||
| 370 | 'href' => $this->url->link('common/dashboard', 'token=' . $this->session->data['token'], true) |
||
| 371 | ); |
||
| 372 | |||
| 373 | $data['breadcrumbs'][] = array( |
||
| 374 | 'text' => $this->language->get('heading_title'), |
||
| 375 | 'href' => $this->url->link('tool/seomanager', 'token=' . $this->session->data['token'] . $url, true) |
||
| 376 | ); |
||
| 377 | |||
| 378 | $data['sort_query'] = $this->url->link('tool/seomanager', 'token=' . $this->session->data['token'] . '&sort=ua.query' . $url, true); |
||
| 379 | $data['sort_keyword'] = $this->url->link('tool/seomanager', 'token=' . $this->session->data['token'] . '&sort=ua.keyword' . $url, true); |
||
| 380 | |||
| 381 | $url = ''; |
||
| 382 | |||
| 383 | if (isset($this->request->get['sort'])) { |
||
| 384 | $url .= '&sort=' . $this->request->get['sort']; |
||
| 385 | } |
||
| 386 | |||
| 387 | if (isset($this->request->get['order'])) { |
||
| 388 | $url .= '&order=' . $this->request->get['order']; |
||
| 389 | } |
||
| 390 | |||
| 391 | $pagination = new \Divine\Engine\Library\Pagination(); |
||
| 392 | $pagination->total = $url_alias_total; |
||
| 393 | $pagination->page = $page; |
||
| 394 | $pagination->limit = $this->config->get('config_limit_admin'); |
||
| 395 | $pagination->text = $this->language->get('text_pagination'); |
||
| 396 | $pagination->url = $this->url->link('tool/seomanager', 'token=' . $this->session->data['token'] . $url . '&page={page}', true); |
||
| 397 | |||
| 398 | $data['pagination'] = $pagination->render(); |
||
| 399 | |||
| 400 | $data['sort'] = $sort; |
||
| 401 | $data['order'] = $order; |
||
| 402 | |||
| 403 | $data['header'] = $this->load->controller('common/header'); |
||
| 404 | $data['column'] = $this->load->controller('common/column_left'); |
||
| 405 | $data['footer'] = $this->load->controller('common/footer'); |
||
| 406 | |||
| 407 | $this->response->setOutput($this->load->view('tool/seomanager', $data)); |
||
| 408 | } |
||
| 446 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.