Nickbur /
Sunrise-CMS
| Conditions | 30 |
| Paths | > 20000 |
| Total Lines | 227 |
| Code Lines | 142 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 175 | protected function getList() |
||
| 176 | { |
||
| 177 | if (isset($this->request->get['filter_name'])) { |
||
| 178 | $filter_name = $this->request->get['filter_name']; |
||
| 179 | } else { |
||
| 180 | $filter_name = null; |
||
| 181 | } |
||
| 182 | |||
| 183 | if (isset($this->request->get['filter_code'])) { |
||
| 184 | $filter_code = $this->request->get['filter_code']; |
||
| 185 | } else { |
||
| 186 | $filter_code = null; |
||
| 187 | } |
||
| 188 | |||
| 189 | if (isset($this->request->get['filter_date_added'])) { |
||
| 190 | $filter_date_added = $this->request->get['filter_date_added']; |
||
| 191 | } else { |
||
| 192 | $filter_date_added = null; |
||
| 193 | } |
||
| 194 | |||
| 195 | if (isset($this->request->get['sort'])) { |
||
| 196 | $sort = $this->request->get['sort']; |
||
| 197 | } else { |
||
| 198 | $sort = 'name'; |
||
| 199 | } |
||
| 200 | |||
| 201 | if (isset($this->request->get['order'])) { |
||
| 202 | $order = $this->request->get['order']; |
||
| 203 | } else { |
||
| 204 | $order = 'ASC'; |
||
| 205 | } |
||
| 206 | |||
| 207 | if (isset($this->request->get['page'])) { |
||
| 208 | $page = $this->request->get['page']; |
||
| 209 | } else { |
||
| 210 | $page = 1; |
||
| 211 | } |
||
| 212 | |||
| 213 | $url = ''; |
||
| 214 | |||
| 215 | if (isset($this->request->get['filter_name'])) { |
||
| 216 | $url .= '&filter_name=' . urlencode(html_entity_decode($this->request->get['filter_name'], ENT_QUOTES, 'UTF-8')); |
||
| 217 | } |
||
| 218 | |||
| 219 | if (isset($this->request->get['filter_code'])) { |
||
| 220 | $url .= '&filter_code=' . $this->request->get['filter_code']; |
||
| 221 | } |
||
| 222 | |||
| 223 | if (isset($this->request->get['filter_date_added'])) { |
||
| 224 | $url .= '&filter_date_added=' . $this->request->get['filter_date_added']; |
||
| 225 | } |
||
| 226 | |||
| 227 | if (isset($this->request->get['sort'])) { |
||
| 228 | $url .= '&sort=' . $this->request->get['sort']; |
||
| 229 | } |
||
| 230 | |||
| 231 | if (isset($this->request->get['sort'])) { |
||
| 232 | $url .= '&sort=' . $this->request->get['sort']; |
||
| 233 | } |
||
| 234 | |||
| 235 | if (isset($this->request->get['order'])) { |
||
| 236 | $url .= '&order=' . $this->request->get['order']; |
||
| 237 | } |
||
| 238 | |||
| 239 | if (isset($this->request->get['page'])) { |
||
| 240 | $url .= '&page=' . $this->request->get['page']; |
||
| 241 | } |
||
| 242 | |||
| 243 | $data['breadcrumbs'] = array(); |
||
| 244 | |||
| 245 | $data['breadcrumbs'][] = array( |
||
| 246 | 'text' => $this->language->get('text_home'), |
||
| 247 | 'href' => $this->url->link('common/dashboard', 'token=' . $this->session->data['token'], true) |
||
| 248 | ); |
||
| 249 | |||
| 250 | $data['breadcrumbs'][] = array( |
||
| 251 | 'text' => $this->language->get('heading_title'), |
||
| 252 | 'href' => $this->url->link('marketing/marketing', 'token=' . $this->session->data['token'] . $url, true) |
||
| 253 | ); |
||
| 254 | |||
| 255 | $data['add'] = $this->url->link('marketing/marketing/add', 'token=' . $this->session->data['token'] . $url, true); |
||
| 256 | $data['delete'] = $this->url->link('marketing/marketing/delete', 'token=' . $this->session->data['token'] . $url, true); |
||
| 257 | |||
| 258 | $data['marketings'] = array(); |
||
| 259 | |||
| 260 | $filter_data = array( |
||
| 261 | 'filter_name' => $filter_name, |
||
| 262 | 'filter_code' => $filter_code, |
||
| 263 | 'filter_date_added' => $filter_date_added, |
||
| 264 | 'sort' => $sort, |
||
| 265 | 'order' => $order, |
||
| 266 | 'start' => ($page - 1) * $this->config->get('config_limit_admin'), |
||
| 267 | 'limit' => $this->config->get('config_limit_admin') |
||
| 268 | ); |
||
| 269 | |||
| 270 | $marketing_total = $this->model_marketing_marketing->getTotalMarketings($filter_data); |
||
| 271 | |||
| 272 | $results = $this->model_marketing_marketing->getMarketings($filter_data); |
||
| 273 | |||
| 274 | foreach ($results as $result) { |
||
| 275 | $data['marketings'][] = array( |
||
| 276 | 'marketing_id' => $result['marketing_id'], |
||
| 277 | 'name' => $result['name'], |
||
| 278 | 'code' => $result['code'], |
||
| 279 | 'clicks' => $result['clicks'], |
||
| 280 | 'orders' => $result['orders'], |
||
| 281 | 'date_added' => date($this->language->get('date_format_short'), strtotime($result['date_added'])), |
||
| 282 | 'edit' => $this->url->link('marketing/marketing/edit', 'token=' . $this->session->data['token'] . '&marketing_id=' . $result['marketing_id'] . $url, true) |
||
| 283 | ); |
||
| 284 | } |
||
| 285 | |||
| 286 | $data['heading_title'] = $this->language->get('heading_title'); |
||
| 287 | |||
| 288 | $data['text_list'] = $this->language->get('text_list'); |
||
| 289 | $data['text_no_results'] = $this->language->get('text_no_results'); |
||
| 290 | $data['text_confirm'] = $this->language->get('text_confirm'); |
||
| 291 | |||
| 292 | $data['column_name'] = $this->language->get('column_name'); |
||
| 293 | $data['column_code'] = $this->language->get('column_code'); |
||
| 294 | $data['column_clicks'] = $this->language->get('column_clicks'); |
||
| 295 | $data['column_orders'] = $this->language->get('column_orders'); |
||
| 296 | $data['column_date_added'] = $this->language->get('column_date_added'); |
||
| 297 | $data['column_action'] = $this->language->get('column_action'); |
||
| 298 | |||
| 299 | $data['entry_name'] = $this->language->get('entry_name'); |
||
| 300 | $data['entry_code'] = $this->language->get('entry_code'); |
||
| 301 | $data['entry_date_added'] = $this->language->get('entry_date_added'); |
||
| 302 | |||
| 303 | $data['button_add'] = $this->language->get('button_add'); |
||
| 304 | $data['button_edit'] = $this->language->get('button_edit'); |
||
| 305 | $data['button_delete'] = $this->language->get('button_delete'); |
||
| 306 | $data['button_filter'] = $this->language->get('button_filter'); |
||
| 307 | |||
| 308 | $data['token'] = $this->session->data['token']; |
||
| 309 | |||
| 310 | if (isset($this->error['warning'])) { |
||
| 311 | $data['error_warning'] = $this->error['warning']; |
||
| 312 | } else { |
||
| 313 | $data['error_warning'] = ''; |
||
| 314 | } |
||
| 315 | |||
| 316 | if (isset($this->session->data['success'])) { |
||
| 317 | $data['success'] = $this->session->data['success']; |
||
| 318 | |||
| 319 | unset($this->session->data['success']); |
||
| 320 | } else { |
||
| 321 | $data['success'] = ''; |
||
| 322 | } |
||
| 323 | |||
| 324 | if (isset($this->request->post['selected'])) { |
||
| 325 | $data['selected'] = (array)$this->request->post['selected']; |
||
| 326 | } else { |
||
| 327 | $data['selected'] = array(); |
||
| 328 | } |
||
| 329 | |||
| 330 | $url = ''; |
||
| 331 | |||
| 332 | if (isset($this->request->get['filter_name'])) { |
||
| 333 | $url .= '&filter_name=' . urlencode(html_entity_decode($this->request->get['filter_name'], ENT_QUOTES, 'UTF-8')); |
||
| 334 | } |
||
| 335 | |||
| 336 | if (isset($this->request->get['filter_code'])) { |
||
| 337 | $url .= '&filter_code=' . $this->request->get['filter_code']; |
||
| 338 | } |
||
| 339 | |||
| 340 | if (isset($this->request->get['filter_date_added'])) { |
||
| 341 | $url .= '&filter_date_added=' . $this->request->get['filter_date_added']; |
||
| 342 | } |
||
| 343 | |||
| 344 | if ($order == 'ASC') { |
||
| 345 | $url .= '&order=DESC'; |
||
| 346 | } else { |
||
| 347 | $url .= '&order=ASC'; |
||
| 348 | } |
||
| 349 | |||
| 350 | if (isset($this->request->get['page'])) { |
||
| 351 | $url .= '&page=' . $this->request->get['page']; |
||
| 352 | } |
||
| 353 | |||
| 354 | $data['sort_name'] = $this->url->link('marketing/marketing', 'token=' . $this->session->data['token'] . '&sort=m.name' . $url, true); |
||
| 355 | $data['sort_code'] = $this->url->link('marketing/marketing', 'token=' . $this->session->data['token'] . '&sort=m.code' . $url, true); |
||
| 356 | $data['sort_date_added'] = $this->url->link('marketing/marketing', 'token=' . $this->session->data['token'] . '&sort=m.date_added' . $url, true); |
||
| 357 | |||
| 358 | $url = ''; |
||
| 359 | |||
| 360 | if (isset($this->request->get['filter_name'])) { |
||
| 361 | $url .= '&filter_name=' . urlencode(html_entity_decode($this->request->get['filter_name'], ENT_QUOTES, 'UTF-8')); |
||
| 362 | } |
||
| 363 | |||
| 364 | if (isset($this->request->get['filter_code'])) { |
||
| 365 | $url .= '&filter_code=' . $this->request->get['filter_code']; |
||
| 366 | } |
||
| 367 | |||
| 368 | if (isset($this->request->get['filter_date_added'])) { |
||
| 369 | $url .= '&filter_date_added=' . $this->request->get['filter_date_added']; |
||
| 370 | } |
||
| 371 | |||
| 372 | if (isset($this->request->get['sort'])) { |
||
| 373 | $url .= '&sort=' . $this->request->get['sort']; |
||
| 374 | } |
||
| 375 | |||
| 376 | if (isset($this->request->get['order'])) { |
||
| 377 | $url .= '&order=' . $this->request->get['order']; |
||
| 378 | } |
||
| 379 | |||
| 380 | $pagination = new \Divine\Engine\Library\Pagination(); |
||
| 381 | $pagination->total = $marketing_total; |
||
| 382 | $pagination->page = $page; |
||
| 383 | $pagination->limit = $this->config->get('config_limit_admin'); |
||
| 384 | $pagination->url = $this->url->link('marketing/marketing', 'token=' . $this->session->data['token'] . $url . '&page={page}', true); |
||
| 385 | |||
| 386 | $data['pagination'] = $pagination->render(); |
||
| 387 | |||
| 388 | $data['results'] = sprintf($this->language->get('text_pagination'), ($marketing_total) ? (($page - 1) * $this->config->get('config_limit_admin')) + 1 : 0, ((($page - 1) * $this->config->get('config_limit_admin')) > ($marketing_total - $this->config->get('config_limit_admin'))) ? $marketing_total : ((($page - 1) * $this->config->get('config_limit_admin')) + $this->config->get('config_limit_admin')), $marketing_total, ceil($marketing_total / $this->config->get('config_limit_admin'))); |
||
| 389 | |||
| 390 | $data['filter_name'] = $filter_name; |
||
| 391 | $data['filter_code'] = $filter_code; |
||
| 392 | $data['filter_date_added'] = $filter_date_added; |
||
| 393 | |||
| 394 | $data['sort'] = $sort; |
||
| 395 | $data['order'] = $order; |
||
| 396 | |||
| 397 | $data['header'] = $this->load->controller('common/header'); |
||
| 398 | $data['column'] = $this->load->controller('common/column_left'); |
||
| 399 | $data['footer'] = $this->load->controller('common/footer'); |
||
| 400 | |||
| 401 | $this->response->setOutput($this->load->view('marketing/marketing_list', $data)); |
||
| 402 | } |
||
| 562 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.