Nickbur /
Sunrise-CMS
| Conditions | 22 |
| Paths | > 20000 |
| Total Lines | 143 |
| Code Lines | 95 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 27 | public function index() |
||
| 28 | { |
||
| 29 | $this->load->language('extension/module/featured_article'); |
||
| 30 | |||
| 31 | $this->document->setTitle($this->language->get('heading_title')); |
||
| 32 | |||
| 33 | $this->load->model('extension/module'); |
||
| 34 | |||
| 35 | if (($this->request->server['REQUEST_METHOD'] == 'POST') && $this->validate()) { |
||
| 36 | if (!isset($this->request->get['module_id'])) { |
||
| 37 | $this->model_extension_module->addModule('featured_article', $this->request->post); |
||
| 38 | } else { |
||
| 39 | $this->model_extension_module->editModule($this->request->get['module_id'], $this->request->post); |
||
| 40 | } |
||
| 41 | |||
| 42 | $this->cache->delete('product'); |
||
| 43 | |||
| 44 | $this->session->data['success'] = $this->language->get('text_success'); |
||
| 45 | |||
| 46 | $this->response->redirect($this->url->link('extension/extension', 'token=' . $this->session->data['token'] . '&type=module', true)); |
||
| 47 | } |
||
| 48 | |||
| 49 | $data['heading_title'] = $this->language->get('heading_title'); |
||
| 50 | |||
| 51 | $data['text_edit'] = $this->language->get('text_edit'); |
||
| 52 | $data['text_enabled'] = $this->language->get('text_enabled'); |
||
| 53 | $data['text_disabled'] = $this->language->get('text_disabled'); |
||
| 54 | $data['text_help'] = $this->language->get('text_help'); |
||
| 55 | |||
| 56 | $data['entry_name'] = $this->language->get('entry_name'); |
||
| 57 | $data['entry_limit'] = $this->language->get('entry_limit'); |
||
| 58 | $data['entry_width'] = $this->language->get('entry_width'); |
||
| 59 | $data['entry_height'] = $this->language->get('entry_height'); |
||
| 60 | $data['entry_status'] = $this->language->get('entry_status'); |
||
| 61 | |||
| 62 | $data['button_save'] = $this->language->get('button_save'); |
||
| 63 | $data['button_cancel'] = $this->language->get('button_cancel'); |
||
| 64 | |||
| 65 | if (isset($this->error['warning'])) { |
||
| 66 | $data['error_warning'] = $this->error['warning']; |
||
| 67 | } else { |
||
| 68 | $data['error_warning'] = ''; |
||
| 69 | } |
||
| 70 | |||
| 71 | if (isset($this->error['name'])) { |
||
| 72 | $data['error_name'] = $this->error['name']; |
||
| 73 | } else { |
||
| 74 | $data['error_name'] = ''; |
||
| 75 | } |
||
| 76 | |||
| 77 | if (isset($this->error['width'])) { |
||
| 78 | $data['error_width'] = $this->error['width']; |
||
| 79 | } else { |
||
| 80 | $data['error_width'] = ''; |
||
| 81 | } |
||
| 82 | |||
| 83 | if (isset($this->error['height'])) { |
||
| 84 | $data['error_height'] = $this->error['height']; |
||
| 85 | } else { |
||
| 86 | $data['error_height'] = ''; |
||
| 87 | } |
||
| 88 | |||
| 89 | $data['breadcrumbs'] = array(); |
||
| 90 | |||
| 91 | $data['breadcrumbs'][] = array( |
||
| 92 | 'text' => $this->language->get('text_home'), |
||
| 93 | 'href' => $this->url->link('common/dashboard', 'token=' . $this->session->data['token'], true) |
||
| 94 | ); |
||
| 95 | |||
| 96 | $data['breadcrumbs'][] = array( |
||
| 97 | 'text' => $this->language->get('text_extension'), |
||
| 98 | 'href' => $this->url->link('extension/extension', 'token=' . $this->session->data['token'] . '&type=module', true) |
||
| 99 | ); |
||
| 100 | |||
| 101 | if (!isset($this->request->get['module_id'])) { |
||
| 102 | $data['breadcrumbs'][] = array( |
||
| 103 | 'text' => $this->language->get('heading_title'), |
||
| 104 | 'href' => $this->url->link('extension/module/featured_article', 'token=' . $this->session->data['token'], true) |
||
| 105 | ); |
||
| 106 | } else { |
||
| 107 | $data['breadcrumbs'][] = array( |
||
| 108 | 'text' => $this->language->get('heading_title'), |
||
| 109 | 'href' => $this->url->link('extension/module/featured_article', 'token=' . $this->session->data['token'] . '&module_id=' . $this->request->get['module_id'], true) |
||
| 110 | ); |
||
| 111 | } |
||
| 112 | |||
| 113 | if (!isset($this->request->get['module_id'])) { |
||
| 114 | $data['action'] = $this->url->link('extension/module/featured_article', 'token=' . $this->session->data['token'], true); |
||
| 115 | } else { |
||
| 116 | $data['action'] = $this->url->link('extension/module/featured_article', 'token=' . $this->session->data['token'] . '&module_id=' . $this->request->get['module_id'], true); |
||
| 117 | } |
||
| 118 | |||
| 119 | $data['cancel'] = $this->url->link('extension/extension', 'token=' . $this->session->data['token'] . '&type=module', true); |
||
| 120 | |||
| 121 | if (isset($this->request->get['module_id']) && ($this->request->server['REQUEST_METHOD'] != 'POST')) { |
||
| 122 | $module_info = $this->model_extension_module->getModule($this->request->get['module_id']); |
||
| 123 | } |
||
| 124 | |||
| 125 | if (isset($this->request->post['name'])) { |
||
| 126 | $data['name'] = $this->request->post['name']; |
||
| 127 | } elseif (!empty($module_info)) { |
||
| 128 | $data['name'] = $module_info['name']; |
||
| 129 | } else { |
||
| 130 | $data['name'] = ''; |
||
| 131 | } |
||
| 132 | |||
| 133 | if (isset($this->request->post['limit'])) { |
||
| 134 | $data['limit'] = $this->request->post['limit']; |
||
| 135 | } elseif (!empty($module_info)) { |
||
| 136 | $data['limit'] = $module_info['limit']; |
||
| 137 | } else { |
||
| 138 | $data['limit'] = 5; |
||
| 139 | } |
||
| 140 | |||
| 141 | if (isset($this->request->post['width'])) { |
||
| 142 | $data['width'] = $this->request->post['width']; |
||
| 143 | } elseif (!empty($module_info)) { |
||
| 144 | $data['width'] = $module_info['width']; |
||
| 145 | } else { |
||
| 146 | $data['width'] = 200; |
||
| 147 | } |
||
| 148 | |||
| 149 | if (isset($this->request->post['height'])) { |
||
| 150 | $data['height'] = $this->request->post['height']; |
||
| 151 | } elseif (!empty($module_info)) { |
||
| 152 | $data['height'] = $module_info['height']; |
||
| 153 | } else { |
||
| 154 | $data['height'] = 200; |
||
| 155 | } |
||
| 156 | |||
| 157 | if (isset($this->request->post['status'])) { |
||
| 158 | $data['status'] = $this->request->post['status']; |
||
| 159 | } elseif (!empty($module_info)) { |
||
| 160 | $data['status'] = $module_info['status']; |
||
| 161 | } else { |
||
| 162 | $data['status'] = ''; |
||
| 163 | } |
||
| 164 | |||
| 165 | $data['header'] = $this->load->controller('common/header'); |
||
| 166 | $data['column'] = $this->load->controller('common/column_left'); |
||
| 167 | $data['footer'] = $this->load->controller('common/footer'); |
||
| 168 | |||
| 169 | $this->response->setOutput($this->load->view('extension/module/featured_article', $data)); |
||
| 170 | } |
||
| 193 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.