Nickbur /
Sunrise-CMS
| Conditions | 7 |
| Paths | 32 |
| Total Lines | 74 |
| Code Lines | 47 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | public function index() |
||
| 26 | { |
||
| 27 | $this->load->language('checkout/success'); |
||
| 28 | |||
| 29 | if (isset($this->session->data['order_id']) && (! empty($this->session->data['order_id']))) { |
||
| 30 | $this->session->data['last_order_id'] = $this->session->data['order_id']; |
||
| 31 | } |
||
| 32 | |||
| 33 | if (isset($this->session->data['order_id'])) { |
||
| 34 | $this->cart->clear(); |
||
| 35 | |||
| 36 | unset($this->session->data['shipping_method']); |
||
| 37 | unset($this->session->data['shipping_methods']); |
||
| 38 | unset($this->session->data['payment_method']); |
||
| 39 | unset($this->session->data['payment_methods']); |
||
| 40 | unset($this->session->data['guest']); |
||
| 41 | unset($this->session->data['comment']); |
||
| 42 | unset($this->session->data['order_id']); |
||
| 43 | unset($this->session->data['reward']); |
||
| 44 | unset($this->session->data['totals']); |
||
| 45 | } |
||
| 46 | |||
| 47 | if (! empty($this->session->data['last_order_id'])) { |
||
| 48 | $this->document->setTitle(sprintf($this->language->get('heading_title_customer'), $this->session->data['last_order_id'])); |
||
| 49 | } else { |
||
| 50 | $this->document->setTitle($this->language->get('heading_title')); |
||
| 51 | } |
||
| 52 | |||
| 53 | $data['breadcrumbs'] = array(); |
||
| 54 | |||
| 55 | $data['breadcrumbs'][] = array( |
||
| 56 | 'text' => $this->language->get('text_home'), |
||
| 57 | 'href' => $this->url->link('common/home') |
||
| 58 | ); |
||
| 59 | |||
| 60 | $data['breadcrumbs'][] = array( |
||
| 61 | 'text' => $this->language->get('text_basket'), |
||
| 62 | 'href' => $this->url->link('checkout/cart') |
||
| 63 | ); |
||
| 64 | |||
| 65 | $data['breadcrumbs'][] = array( |
||
| 66 | 'text' => $this->language->get('text_checkout'), |
||
| 67 | 'href' => $this->url->link('checkout/checkout', '', true) |
||
| 68 | ); |
||
| 69 | |||
| 70 | $data['breadcrumbs'][] = array( |
||
| 71 | 'text' => $this->language->get('text_success'), |
||
| 72 | 'href' => $this->url->link('checkout/success') |
||
| 73 | ); |
||
| 74 | |||
| 75 | if (! empty($this->session->data['last_order_id'])) { |
||
| 76 | $data['heading_title'] = sprintf($this->language->get('heading_title_customer'), $this->session->data['last_order_id']); |
||
| 77 | } else { |
||
| 78 | $data['heading_title'] = $this->language->get('heading_title'); |
||
| 79 | } |
||
| 80 | |||
| 81 | if ($this->customer->isLogged()) { |
||
| 82 | $data['text_message'] = sprintf($this->language->get('text_customer'), $this->url->link('account/order/info&order_id=' . $this->session->data['last_order_id'], '', true), $this->url->link('account/account', '', true), $this->url->link('account/order', '', true), $this->url->link('information/contact'), $this->url->link('product/special'), $this->session->data['last_order_id'], $this->url->link('account/download', '', true)); |
||
| 83 | } else { |
||
| 84 | $data['text_message'] = sprintf($this->language->get('text_guest'), $this->url->link('information/contact'), $this->session->data['last_order_id']); |
||
| 85 | } |
||
| 86 | |||
| 87 | $data['button_continue'] = $this->language->get('button_continue'); |
||
| 88 | |||
| 89 | $data['continue'] = $this->url->link('common/home'); |
||
| 90 | |||
| 91 | $data['column'] = $this->load->controller('common/column'); |
||
| 92 | |||
| 93 | $data['content_top'] = $this->load->controller('common/content_top'); |
||
| 94 | $data['content_bottom'] = $this->load->controller('common/content_bottom'); |
||
| 95 | $data['footer'] = $this->load->controller('common/footer'); |
||
| 96 | $data['header'] = $this->load->controller('common/header'); |
||
| 97 | |||
| 98 | $this->response->setOutput($this->load->view('common/success', $data)); |
||
| 99 | } |
||
| 101 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.