Nickbur /
Sunrise-CMS
| Conditions | 8 |
| Paths | 28 |
| Total Lines | 59 |
| Code Lines | 31 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | public function index() |
||
| 26 | { |
||
| 27 | $this->load->language('blog/menu'); |
||
| 28 | |||
| 29 | $configblog_name = $this->config->get('configblog_name'); |
||
| 30 | |||
| 31 | if (!empty($configblog_name)) { |
||
| 32 | $data['text_blog'] = $this->config->get('configblog_name'); |
||
| 33 | } else { |
||
| 34 | $data['text_blog'] = $this->language->get('text_blog'); |
||
| 35 | } |
||
| 36 | |||
| 37 | $data['text_go_to'] = $this->language->get('text_go_to'); |
||
| 38 | |||
| 39 | $data['blog'] = $this->url->link('blog/latest'); |
||
| 40 | |||
| 41 | // Menu |
||
| 42 | $this->load->model('blog/category'); |
||
| 43 | |||
| 44 | $this->load->model('blog/article'); |
||
| 45 | |||
| 46 | $data['categories'] = array(); |
||
| 47 | |||
| 48 | $categories = $this->model_blog_category->getCategories(0); |
||
| 49 | |||
| 50 | foreach ($categories as $category) { |
||
| 51 | if ($category['top']) { |
||
| 52 | // Level 2 |
||
| 53 | $children_data = array(); |
||
| 54 | |||
| 55 | $children = $this->model_blog_category->getCategories($category['blog_category_id']); |
||
| 56 | |||
| 57 | foreach ($children as $child) { |
||
| 58 | $filter_data = array( |
||
| 59 | 'filter_blog_category_id' => $child['blog_category_id'], |
||
| 60 | 'filter_sub_category' => true |
||
| 61 | ); |
||
| 62 | |||
| 63 | $children_data[] = array( |
||
| 64 | 'name' => $child['name'] . ($this->config->get('configblog_article_count') ? ' (' . $this->model_blog_article->getTotalArticles($filter_data) . ')' : ''), |
||
| 65 | 'href' => $this->url->link('blog/category', 'blog_category_id=' . $category['blog_category_id'] . '_' . $child['blog_category_id']) |
||
| 66 | ); |
||
| 67 | } |
||
| 68 | |||
| 69 | // Level 1 |
||
| 70 | $filter_data = array( |
||
| 71 | 'filter_blog_category_id' => $category['blog_category_id'] |
||
| 72 | ); |
||
| 73 | |||
| 74 | $data['categories'][] = array( |
||
| 75 | 'name' => $category['name'] . ($this->config->get('configblog_article_count') ? ' (' . $this->model_blog_article->getTotalArticles($filter_data) . ')' : ''), |
||
| 76 | 'children' => $children_data, |
||
| 77 | 'column' => $category['column'] ? $category['column'] : 1, |
||
| 78 | 'href' => $this->url->link('blog/category', 'blog_category_id=' . $category['blog_category_id']) |
||
| 79 | ); |
||
| 80 | } |
||
| 81 | } |
||
| 82 | |||
| 83 | return $this->load->view('blog/menu', $data); |
||
| 84 | } |
||
| 86 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.