| Conditions | 6 |
| Paths | 8 |
| Total Lines | 91 |
| Code Lines | 55 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | public function index() |
||
| 26 | { |
||
| 27 | if (!$this->customer->isLogged()) { |
||
| 28 | $this->session->data['redirect'] = $this->url->link('account/transaction', '', true); |
||
| 29 | |||
| 30 | $this->response->redirect($this->url->link('account/login', '', true)); |
||
| 31 | } |
||
| 32 | |||
| 33 | $this->load->language('account/transaction'); |
||
| 34 | |||
| 35 | $this->document->setTitle($this->language->get('heading_title')); |
||
| 36 | |||
| 37 | $data['breadcrumbs'] = array(); |
||
| 38 | |||
| 39 | $data['breadcrumbs'][] = array( |
||
| 40 | 'text' => $this->language->get('text_home'), |
||
| 41 | 'href' => $this->url->link('common/home') |
||
| 42 | ); |
||
| 43 | |||
| 44 | $data['breadcrumbs'][] = array( |
||
| 45 | 'text' => $this->language->get('text_account'), |
||
| 46 | 'href' => $this->url->link('account/account', '', true) |
||
| 47 | ); |
||
| 48 | |||
| 49 | $data['breadcrumbs'][] = array( |
||
| 50 | 'text' => $this->language->get('text_transaction'), |
||
| 51 | 'href' => $this->url->link('account/transaction', '', true) |
||
| 52 | ); |
||
| 53 | |||
| 54 | $this->load->model('account/transaction'); |
||
| 55 | |||
| 56 | $data['heading_title'] = $this->language->get('heading_title'); |
||
| 57 | |||
| 58 | $data['column_date_added'] = $this->language->get('column_date_added'); |
||
| 59 | $data['column_description'] = $this->language->get('column_description'); |
||
| 60 | $data['column_amount'] = sprintf($this->language->get('column_amount'), $this->config->get('config_currency')); |
||
| 61 | |||
| 62 | $data['text_total'] = $this->language->get('text_total'); |
||
| 63 | $data['text_empty'] = $this->language->get('text_empty'); |
||
| 64 | |||
| 65 | $data['button_continue'] = $this->language->get('button_continue'); |
||
| 66 | |||
| 67 | if (isset($this->request->get['page'])) { |
||
| 68 | $page = $this->request->get['page']; |
||
| 69 | } else { |
||
| 70 | $page = 1; |
||
| 71 | } |
||
| 72 | |||
| 73 | $data['transactions'] = array(); |
||
| 74 | |||
| 75 | $filter_data = array( |
||
| 76 | 'sort' => 'date_added', |
||
| 77 | 'order' => 'DESC', |
||
| 78 | 'start' => ($page - 1) * 10, |
||
| 79 | 'limit' => 10 |
||
| 80 | ); |
||
| 81 | |||
| 82 | $transaction_total = $this->model_account_transaction->getTotalTransactions(); |
||
| 83 | |||
| 84 | $results = $this->model_account_transaction->getTransactions($filter_data); |
||
| 85 | |||
| 86 | foreach ($results as $result) { |
||
| 87 | $data['transactions'][] = array( |
||
| 88 | 'amount' => $this->currency->format($result['amount'], $this->config->get('config_currency')), |
||
| 89 | 'description' => $result['description'], |
||
| 90 | 'date_added' => date($this->language->get('date_format_short'), strtotime($result['date_added'])) |
||
| 91 | ); |
||
| 92 | } |
||
| 93 | |||
| 94 | $pagination = new \Divine\Engine\Library\Pagination(); |
||
| 95 | $pagination->total = $transaction_total; |
||
| 96 | $pagination->page = $page; |
||
| 97 | $pagination->limit = 10; |
||
| 98 | $pagination->url = $this->url->link('account/transaction', 'page={page}', true); |
||
| 99 | |||
| 100 | $data['pagination'] = $pagination->render(); |
||
| 101 | |||
| 102 | $data['results'] = sprintf($this->language->get('text_pagination'), ($transaction_total) ? (($page - 1) * 10) + 1 : 0, ((($page - 1) * 10) > ($transaction_total - 10)) ? $transaction_total : ((($page - 1) * 10) + 10), $transaction_total, ceil($transaction_total / 10)); |
||
| 103 | |||
| 104 | $data['total'] = $this->currency->format($this->customer->getBalance(), $this->session->data['currency']); |
||
| 105 | |||
| 106 | $data['continue'] = $this->url->link('account/account', '', true); |
||
| 107 | |||
| 108 | $data['column'] = $this->load->controller('common/column'); |
||
| 109 | |||
| 110 | $data['content_top'] = $this->load->controller('common/content_top'); |
||
| 111 | $data['content_bottom'] = $this->load->controller('common/content_bottom'); |
||
| 112 | $data['footer'] = $this->load->controller('common/footer'); |
||
| 113 | $data['header'] = $this->load->controller('common/header'); |
||
| 114 | |||
| 115 | $this->response->setOutput($this->load->view('account/transaction', $data)); |
||
| 116 | } |
||
| 118 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.