Nickbur /
Sunrise-CMS
| Conditions | 3 |
| Paths | 4 |
| Total Lines | 63 |
| Code Lines | 35 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | public function index() |
||
| 26 | { |
||
| 27 | if (!$this->customer->isLogged()) { |
||
| 28 | $this->session->data['redirect'] = $this->url->link('account/newsletter', '', true); |
||
| 29 | |||
| 30 | $this->response->redirect($this->url->link('account/login', '', true)); |
||
| 31 | } |
||
| 32 | |||
| 33 | $this->load->language('account/newsletter'); |
||
| 34 | |||
| 35 | $this->document->setTitle($this->language->get('heading_title')); |
||
| 36 | |||
| 37 | if ($this->request->server['REQUEST_METHOD'] == 'POST') { |
||
| 38 | $this->load->model('account/customer'); |
||
| 39 | |||
| 40 | $this->model_account_customer->editNewsletter($this->request->post['newsletter']); |
||
| 41 | |||
| 42 | $this->session->data['success'] = $this->language->get('text_success'); |
||
| 43 | |||
| 44 | $this->response->redirect($this->url->link('account/account', '', true)); |
||
| 45 | } |
||
| 46 | |||
| 47 | $data['breadcrumbs'] = array(); |
||
| 48 | |||
| 49 | $data['breadcrumbs'][] = array( |
||
| 50 | 'text' => $this->language->get('text_home'), |
||
| 51 | 'href' => $this->url->link('common/home') |
||
| 52 | ); |
||
| 53 | |||
| 54 | $data['breadcrumbs'][] = array( |
||
| 55 | 'text' => $this->language->get('text_account'), |
||
| 56 | 'href' => $this->url->link('account/account', '', true) |
||
| 57 | ); |
||
| 58 | |||
| 59 | $data['breadcrumbs'][] = array( |
||
| 60 | 'text' => $this->language->get('text_newsletter'), |
||
| 61 | 'href' => $this->url->link('account/newsletter', '', true) |
||
| 62 | ); |
||
| 63 | |||
| 64 | $data['heading_title'] = $this->language->get('heading_title'); |
||
| 65 | |||
| 66 | $data['text_yes'] = $this->language->get('text_yes'); |
||
| 67 | $data['text_no'] = $this->language->get('text_no'); |
||
| 68 | |||
| 69 | $data['entry_newsletter'] = $this->language->get('entry_newsletter'); |
||
| 70 | |||
| 71 | $data['button_continue'] = $this->language->get('button_continue'); |
||
| 72 | $data['button_back'] = $this->language->get('button_back'); |
||
| 73 | |||
| 74 | $data['action'] = $this->url->link('account/newsletter', '', true); |
||
| 75 | |||
| 76 | $data['newsletter'] = $this->customer->getNewsletter(); |
||
| 77 | |||
| 78 | $data['back'] = $this->url->link('account/account', '', true); |
||
| 79 | |||
| 80 | $data['column'] = $this->load->controller('common/column'); |
||
| 81 | |||
| 82 | $data['content_top'] = $this->load->controller('common/content_top'); |
||
| 83 | $data['content_bottom'] = $this->load->controller('common/content_bottom'); |
||
| 84 | $data['footer'] = $this->load->controller('common/footer'); |
||
| 85 | $data['header'] = $this->load->controller('common/header'); |
||
| 86 | |||
| 87 | $this->response->setOutput($this->load->view('account/newsletter', $data)); |
||
| 88 | } |
||
| 90 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.