| Conditions | 2 |
| Paths | 2 |
| Total Lines | 55 |
| Code Lines | 34 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | public function index() |
||
| 26 | { |
||
| 27 | if ($this->customer->isLogged()) { |
||
| 28 | $this->customer->logout(); |
||
| 29 | |||
| 30 | unset($this->session->data['shipping_address']); |
||
| 31 | unset($this->session->data['shipping_method']); |
||
| 32 | unset($this->session->data['shipping_methods']); |
||
| 33 | unset($this->session->data['payment_address']); |
||
| 34 | unset($this->session->data['payment_method']); |
||
| 35 | unset($this->session->data['payment_methods']); |
||
| 36 | unset($this->session->data['comment']); |
||
| 37 | unset($this->session->data['order_id']); |
||
| 38 | unset($this->session->data['reward']); |
||
| 39 | |||
| 40 | $this->response->redirect($this->url->link('account/logout', '', true)); |
||
| 41 | } |
||
| 42 | |||
| 43 | $this->load->language('account/logout'); |
||
| 44 | |||
| 45 | $this->document->setTitle($this->language->get('heading_title')); |
||
| 46 | |||
| 47 | $data['breadcrumbs'] = array(); |
||
| 48 | |||
| 49 | $data['breadcrumbs'][] = array( |
||
| 50 | 'text' => $this->language->get('text_home'), |
||
| 51 | 'href' => $this->url->link('common/home') |
||
| 52 | ); |
||
| 53 | |||
| 54 | $data['breadcrumbs'][] = array( |
||
| 55 | 'text' => $this->language->get('text_account'), |
||
| 56 | 'href' => $this->url->link('account/account', '', true) |
||
| 57 | ); |
||
| 58 | |||
| 59 | $data['breadcrumbs'][] = array( |
||
| 60 | 'text' => $this->language->get('text_logout'), |
||
| 61 | 'href' => $this->url->link('account/logout', '', true) |
||
| 62 | ); |
||
| 63 | |||
| 64 | $data['heading_title'] = $this->language->get('heading_title'); |
||
| 65 | |||
| 66 | $data['text_message'] = $this->language->get('text_message'); |
||
| 67 | |||
| 68 | $data['button_continue'] = $this->language->get('button_continue'); |
||
| 69 | |||
| 70 | $data['continue'] = $this->url->link('common/home'); |
||
| 71 | |||
| 72 | $data['column'] = $this->load->controller('common/column'); |
||
| 73 | |||
| 74 | $data['content_top'] = $this->load->controller('common/content_top'); |
||
| 75 | $data['content_bottom'] = $this->load->controller('common/content_bottom'); |
||
| 76 | $data['footer'] = $this->load->controller('common/footer'); |
||
| 77 | $data['header'] = $this->load->controller('common/header'); |
||
| 78 | |||
| 79 | $this->response->setOutput($this->load->view('common/success', $data)); |
||
| 80 | } |
||
| 82 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.