Nickbur /
Sunrise-CMS
| Total Complexity | 101 |
| Total Lines | 533 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like ControllerUserUser often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ControllerUserUser, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | class ControllerUserUser extends \Divine\Engine\Core\Controller |
||
|
|
|||
| 24 | { |
||
| 25 | private $error = array(); |
||
| 26 | |||
| 27 | public function index() |
||
| 36 | } |
||
| 37 | |||
| 38 | public function add() |
||
| 39 | { |
||
| 40 | $this->load->language('user/user'); |
||
| 41 | |||
| 42 | $this->document->setTitle($this->language->get('heading_title')); |
||
| 43 | |||
| 44 | $this->load->model('user/user'); |
||
| 45 | |||
| 46 | if (($this->request->server['REQUEST_METHOD'] == 'POST') && $this->validateForm()) { |
||
| 47 | $this->model_user_user->addUser($this->request->post); |
||
| 48 | |||
| 49 | $this->session->data['success'] = $this->language->get('text_success'); |
||
| 50 | |||
| 51 | $url = ''; |
||
| 52 | |||
| 53 | if (isset($this->request->get['sort'])) { |
||
| 54 | $url .= '&sort=' . $this->request->get['sort']; |
||
| 55 | } |
||
| 56 | |||
| 57 | if (isset($this->request->get['order'])) { |
||
| 58 | $url .= '&order=' . $this->request->get['order']; |
||
| 59 | } |
||
| 60 | |||
| 61 | if (isset($this->request->get['page'])) { |
||
| 62 | $url .= '&page=' . $this->request->get['page']; |
||
| 63 | } |
||
| 64 | |||
| 65 | $this->response->redirect($this->url->link('user/user', 'token=' . $this->session->data['token'] . $url, true)); |
||
| 66 | } |
||
| 67 | |||
| 68 | $this->getForm(); |
||
| 69 | } |
||
| 70 | |||
| 71 | public function edit() |
||
| 72 | { |
||
| 73 | $this->load->language('user/user'); |
||
| 74 | |||
| 75 | $this->document->setTitle($this->language->get('heading_title')); |
||
| 76 | |||
| 77 | $this->load->model('user/user'); |
||
| 78 | |||
| 79 | if (($this->request->server['REQUEST_METHOD'] == 'POST') && $this->validateForm()) { |
||
| 80 | $this->model_user_user->editUser($this->request->get['user_id'], $this->request->post); |
||
| 81 | |||
| 82 | $this->session->data['success'] = $this->language->get('text_success'); |
||
| 83 | |||
| 84 | $url = ''; |
||
| 85 | |||
| 86 | if (isset($this->request->get['sort'])) { |
||
| 87 | $url .= '&sort=' . $this->request->get['sort']; |
||
| 88 | } |
||
| 89 | |||
| 90 | if (isset($this->request->get['order'])) { |
||
| 91 | $url .= '&order=' . $this->request->get['order']; |
||
| 92 | } |
||
| 93 | |||
| 94 | if (isset($this->request->get['page'])) { |
||
| 95 | $url .= '&page=' . $this->request->get['page']; |
||
| 96 | } |
||
| 97 | |||
| 98 | $this->response->redirect($this->url->link('user/user', 'token=' . $this->session->data['token'] . $url, true)); |
||
| 99 | } |
||
| 100 | |||
| 101 | $this->getForm(); |
||
| 102 | } |
||
| 103 | |||
| 104 | public function delete() |
||
| 105 | { |
||
| 106 | $this->load->language('user/user'); |
||
| 107 | |||
| 108 | $this->document->setTitle($this->language->get('heading_title')); |
||
| 109 | |||
| 110 | $this->load->model('user/user'); |
||
| 111 | |||
| 112 | if (isset($this->request->post['selected']) && $this->validateDelete()) { |
||
| 113 | foreach ($this->request->post['selected'] as $user_id) { |
||
| 114 | $this->model_user_user->deleteUser($user_id); |
||
| 115 | } |
||
| 116 | |||
| 117 | $this->session->data['success'] = $this->language->get('text_success'); |
||
| 118 | |||
| 119 | $url = ''; |
||
| 120 | |||
| 121 | if (isset($this->request->get['sort'])) { |
||
| 122 | $url .= '&sort=' . $this->request->get['sort']; |
||
| 123 | } |
||
| 124 | |||
| 125 | if (isset($this->request->get['order'])) { |
||
| 126 | $url .= '&order=' . $this->request->get['order']; |
||
| 127 | } |
||
| 128 | |||
| 129 | if (isset($this->request->get['page'])) { |
||
| 130 | $url .= '&page=' . $this->request->get['page']; |
||
| 131 | } |
||
| 132 | |||
| 133 | $this->response->redirect($this->url->link('user/user', 'token=' . $this->session->data['token'] . $url, true)); |
||
| 134 | } |
||
| 135 | |||
| 136 | $this->getList(); |
||
| 137 | } |
||
| 138 | |||
| 139 | protected function getList() |
||
| 140 | { |
||
| 141 | if (isset($this->request->get['sort'])) { |
||
| 142 | $sort = $this->request->get['sort']; |
||
| 143 | } else { |
||
| 144 | $sort = 'username'; |
||
| 145 | } |
||
| 146 | |||
| 147 | if (isset($this->request->get['order'])) { |
||
| 148 | $order = $this->request->get['order']; |
||
| 149 | } else { |
||
| 150 | $order = 'ASC'; |
||
| 151 | } |
||
| 152 | |||
| 153 | if (isset($this->request->get['page'])) { |
||
| 154 | $page = $this->request->get['page']; |
||
| 155 | } else { |
||
| 156 | $page = 1; |
||
| 157 | } |
||
| 158 | |||
| 159 | $url = ''; |
||
| 160 | |||
| 161 | if (isset($this->request->get['sort'])) { |
||
| 162 | $url .= '&sort=' . $this->request->get['sort']; |
||
| 163 | } |
||
| 164 | |||
| 165 | if (isset($this->request->get['order'])) { |
||
| 166 | $url .= '&order=' . $this->request->get['order']; |
||
| 167 | } |
||
| 168 | |||
| 169 | if (isset($this->request->get['page'])) { |
||
| 170 | $url .= '&page=' . $this->request->get['page']; |
||
| 171 | } |
||
| 172 | |||
| 173 | $data['breadcrumbs'] = array(); |
||
| 174 | |||
| 175 | $data['breadcrumbs'][] = array( |
||
| 176 | 'text' => $this->language->get('text_home'), |
||
| 177 | 'href' => $this->url->link('common/dashboard', 'token=' . $this->session->data['token'], true) |
||
| 178 | ); |
||
| 179 | |||
| 180 | $data['breadcrumbs'][] = array( |
||
| 181 | 'text' => $this->language->get('heading_title'), |
||
| 182 | 'href' => $this->url->link('user/user', 'token=' . $this->session->data['token'] . $url, true) |
||
| 183 | ); |
||
| 184 | |||
| 185 | $data['add'] = $this->url->link('user/user/add', 'token=' . $this->session->data['token'] . $url, true); |
||
| 186 | $data['delete'] = $this->url->link('user/user/delete', 'token=' . $this->session->data['token'] . $url, true); |
||
| 187 | |||
| 188 | $data['users'] = array(); |
||
| 189 | |||
| 190 | $filter_data = array( |
||
| 191 | 'sort' => $sort, |
||
| 192 | 'order' => $order, |
||
| 193 | 'start' => ($page - 1) * $this->config->get('config_limit_admin'), |
||
| 194 | 'limit' => $this->config->get('config_limit_admin') |
||
| 195 | ); |
||
| 196 | |||
| 197 | $user_total = $this->model_user_user->getTotalUsers(); |
||
| 198 | |||
| 199 | $results = $this->model_user_user->getUsers($filter_data); |
||
| 200 | |||
| 201 | foreach ($results as $result) { |
||
| 202 | $data['users'][] = array( |
||
| 203 | 'user_id' => $result['user_id'], |
||
| 204 | 'username' => $result['username'], |
||
| 205 | 'status' => ($result['status'] ? $this->language->get('text_enabled') : $this->language->get('text_disabled')), |
||
| 206 | 'date_added' => date($this->language->get('date_format_short'), strtotime($result['date_added'])), |
||
| 207 | 'edit' => $this->url->link('user/user/edit', 'token=' . $this->session->data['token'] . '&user_id=' . $result['user_id'] . $url, true) |
||
| 208 | ); |
||
| 209 | } |
||
| 210 | |||
| 211 | $data['heading_title'] = $this->language->get('heading_title'); |
||
| 212 | |||
| 213 | $data['text_list'] = $this->language->get('text_list'); |
||
| 214 | $data['text_no_results'] = $this->language->get('text_no_results'); |
||
| 215 | $data['text_confirm'] = $this->language->get('text_confirm'); |
||
| 216 | |||
| 217 | $data['column_username'] = $this->language->get('column_username'); |
||
| 218 | $data['column_status'] = $this->language->get('column_status'); |
||
| 219 | $data['column_date_added'] = $this->language->get('column_date_added'); |
||
| 220 | $data['column_action'] = $this->language->get('column_action'); |
||
| 221 | |||
| 222 | $data['button_add'] = $this->language->get('button_add'); |
||
| 223 | $data['button_edit'] = $this->language->get('button_edit'); |
||
| 224 | $data['button_delete'] = $this->language->get('button_delete'); |
||
| 225 | |||
| 226 | if (isset($this->error['warning'])) { |
||
| 227 | $data['error_warning'] = $this->error['warning']; |
||
| 228 | } else { |
||
| 229 | $data['error_warning'] = ''; |
||
| 230 | } |
||
| 231 | |||
| 232 | if (isset($this->session->data['success'])) { |
||
| 233 | $data['success'] = $this->session->data['success']; |
||
| 234 | |||
| 235 | unset($this->session->data['success']); |
||
| 236 | } else { |
||
| 237 | $data['success'] = ''; |
||
| 238 | } |
||
| 239 | |||
| 240 | if (isset($this->request->post['selected'])) { |
||
| 241 | $data['selected'] = (array)$this->request->post['selected']; |
||
| 242 | } else { |
||
| 243 | $data['selected'] = array(); |
||
| 244 | } |
||
| 245 | |||
| 246 | $url = ''; |
||
| 247 | |||
| 248 | if ($order == 'ASC') { |
||
| 249 | $url .= '&order=DESC'; |
||
| 250 | } else { |
||
| 251 | $url .= '&order=ASC'; |
||
| 252 | } |
||
| 253 | |||
| 254 | if (isset($this->request->get['page'])) { |
||
| 255 | $url .= '&page=' . $this->request->get['page']; |
||
| 256 | } |
||
| 257 | |||
| 258 | $data['sort_username'] = $this->url->link('user/user', 'token=' . $this->session->data['token'] . '&sort=username' . $url, true); |
||
| 259 | $data['sort_status'] = $this->url->link('user/user', 'token=' . $this->session->data['token'] . '&sort=status' . $url, true); |
||
| 260 | $data['sort_date_added'] = $this->url->link('user/user', 'token=' . $this->session->data['token'] . '&sort=date_added' . $url, true); |
||
| 261 | |||
| 262 | $url = ''; |
||
| 263 | |||
| 264 | if (isset($this->request->get['sort'])) { |
||
| 265 | $url .= '&sort=' . $this->request->get['sort']; |
||
| 266 | } |
||
| 267 | |||
| 268 | if (isset($this->request->get['order'])) { |
||
| 269 | $url .= '&order=' . $this->request->get['order']; |
||
| 270 | } |
||
| 271 | |||
| 272 | $pagination = new \Divine\Engine\Library\Pagination(); |
||
| 273 | $pagination->total = $user_total; |
||
| 274 | $pagination->page = $page; |
||
| 275 | $pagination->limit = $this->config->get('config_limit_admin'); |
||
| 276 | $pagination->url = $this->url->link('user/user', 'token=' . $this->session->data['token'] . $url . '&page={page}', true); |
||
| 277 | |||
| 278 | $data['pagination'] = $pagination->render(); |
||
| 279 | |||
| 280 | $data['results'] = sprintf($this->language->get('text_pagination'), ($user_total) ? (($page - 1) * $this->config->get('config_limit_admin')) + 1 : 0, ((($page - 1) * $this->config->get('config_limit_admin')) > ($user_total - $this->config->get('config_limit_admin'))) ? $user_total : ((($page - 1) * $this->config->get('config_limit_admin')) + $this->config->get('config_limit_admin')), $user_total, ceil($user_total / $this->config->get('config_limit_admin'))); |
||
| 281 | |||
| 282 | $data['sort'] = $sort; |
||
| 283 | $data['order'] = $order; |
||
| 284 | |||
| 285 | $data['header'] = $this->load->controller('common/header'); |
||
| 286 | $data['column'] = $this->load->controller('common/column_left'); |
||
| 287 | $data['footer'] = $this->load->controller('common/footer'); |
||
| 288 | |||
| 289 | $this->response->setOutput($this->load->view('user/user_list', $data)); |
||
| 290 | } |
||
| 291 | |||
| 292 | protected function getForm() |
||
| 482 | } |
||
| 483 | |||
| 484 | protected function validateForm() |
||
| 541 | } |
||
| 542 | |||
| 543 | protected function validateDelete() |
||
| 544 | { |
||
| 556 | } |
||
| 557 | } |
||
| 558 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.