ChannelCommand - Code Metrics - Inspection of "[FEATURE] Post new created channels" - NeoBlack/T3Bot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e98ea9...145cbe )

by Frank

created 2016-08-29 13:54 UTC

ChannelCommand A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	50
rs	10
wmc	2
lcom	0
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	process()	0	4	1
A	processChannelCreated()	0	12	1

<?php
/**
 * T3Bot.
 *
 * @author Frank Nägler <[email protected]>
 *
 * @link http://www.t3bot.de
 * @link http://wiki.typo3.org/T3Bot
 */

namespace T3Bot\Commands;

use T3Bot\Slack\Message;

/**
 * Class ChannelCommand.
 */
class ChannelCommand extends AbstractCommand
{
    /**
     * @var string
     */
    protected $commandName = 'channel';

    /**
     * @var array
     */
    protected $helpCommands = [
        'help' => 'shows this help'
    ];

    /**
     * @return bool|string
     *
     * @throws \Doctrine\DBAL\DBALException
     */
    public function process()
    {
        return false;
    }

    /**
     * @param array $data
     * @example $data:
     * [
     *  "type": "channel_created",
     *  "channel": {
     *      "id": "C024BE91L",
     *      "name": "fun",
     *      "created": 1360782804,
     *      "creator": "U024BE7LH"
     *  }
     * ]
     */
    public function processChannelCreated(array $data)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $channel = $data['channel'];
        $message = new Message();
        $message->setText(sprintf(
            '<@%s> open channel #%s, join it <#%s>',
            $channel['creator'],
            $channel['name'],
            $channel['id']
        ));
        $this->sendResponse($message, null, $GLOBALS['config']['slack']['channels']['channelCreated']);
    }
}


1			<?php
2			/**
3			* T3Bot.
4			*
5			* @author Frank Nägler <[email protected]>
6			*
7			* @link http://www.t3bot.de
8			* @link http://wiki.typo3.org/T3Bot
9			*/
10
11			namespace T3Bot\Commands;
12
13			use T3Bot\Slack\Message;
14
15			/**
16			* Class ChannelCommand.
17			*/
18			class ChannelCommand extends AbstractCommand
19			{
20			/**
21			* @var string
22			*/
23			protected $commandName = 'channel';
24
25			/**
26			* @var array
27			*/
28			protected $helpCommands = [
29			'help' => 'shows this help'
30			];
31
32			/**
33			* @return bool\|string
34			*
35			* @throws \Doctrine\DBAL\DBALException
36			*/
37			public function process()
38			{
39			return false;
40			}
41
42			/**
43			* @param array $data
44			* @example $data:
45			* [
46			* "type": "channel_created",
47			* "channel": {
48			* "id": "C024BE91L",
49			* "name": "fun",
50			* "created": 1360782804,
51			* "creator": "U024BE7LH"
52			* }
53			* ]
54			*/
55			public function processChannelCreated(array $data)
			0 ignored issues – show Coding Style introduced 2016-08-29 14:54 UTC by Report Bug Copy Issue Report `processChannelCreated` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
56			{
57			$channel = $data['channel'];
58			$message = new Message();
59			$message->setText(sprintf(
60			'<@%s> open channel #%s, join it <#%s>',
61			$channel['creator'],
62			$channel['name'],
63			$channel['id']
64			));
65			$this->sendResponse($message, null, $GLOBALS['config']['slack']['channels']['channelCreated']);
66			}
67			}
68

NeoBlack / T3Bot

Push — master ( e98ea9...145cbe )

ChannelCommand A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like