TellCommandTest::tearDown() - Code Metrics - Inspection of "[TASK] Update dependencies" - NeoBlack/T3Bot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 191869...afc708 )

by Frank

created 2017-07-22 20:36 UTC

TellCommandTest::tearDown() A

↳ Parent: TellCommandTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	0
dl	8
loc	8
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * T3Bot.
 *
 * @author Frank Nägler <[email protected]>
 *
 * @link http://www.t3bot.de
 * @link http://wiki.typo3.org/T3Bot
 */
namespace T3Bot\Tests\Unit\Commands;

use Doctrine\DBAL\Configuration;
use Doctrine\DBAL\DriverManager;
use React\EventLoop\LoopInterface;
use Slack\Payload;
use Slack\RealTimeClient;
use T3Bot\Commands\TellCommand;
use T3Bot\Tests\Unit\BaseCommandTestCase;

/**
 * Class TellCommandTest.
 */

/** @noinspection LongInheritanceChainInspection */
class TellCommandTest extends BaseCommandTestCase
{
    /**
     *
     */
    public function tearDown()

    {
        DriverManager::getConnection($GLOBALS['config']['db'], new Configuration())
            ->delete('notifications', [
                'to_user' => 'U12345'
            ]);
        parent::tearDown();
    }

    /**
     * @return array
     */
    public function tellDataProvider() : array
    {
        return [
            'tell <@U12345> about review:47640' => ['tell <@U12345> about review:47640', 'OK, I will tell <@U12345> about your message'],
            'tell <@U12345> about forge:23456' => ['tell <@U12345> about forge:23456', 'OK, I will tell <@U12345> about your message'],
            'tell <@U12345> you are so nice' => ['tell <@U12345> you are so nice', 'OK, I will tell <@U12345> about your message'],
        ];
    }

    /**
     * @test
     * @dataProvider tellDataProvider
     *
     * @param string $message
     * @param string $expectedMessage
     */
    public function processTellReturnsCorrectResponse($message, $expectedMessage)

    {
        $this->initCommandWithPayload(TellCommand::class, [
            'user' => 'U54321',
            'text' => $message,
        ]);
        $result = $this->command->process();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        static::assertEquals($expectedMessage, $result);
    }

    /**
     * @test
     */
    public function processPresenceChangeReturnsCorrectResponseForPresenceAway()
    {
        $loop = $this->getMock(LoopInterface::class);
        /** @var Payload $payload */
        $payload = new Payload([
            'user' => 'U12345',
            'presence' => 'away',
        ]);
        /** @var RealTimeClient $client */
        $client = $this->getMock(RealTimeClient::class, [], [$loop]);
        /** @var TellCommand|\PHPUnit_Framework_MockObject_MockObject $command */
        $command = $this->getMock(TellCommand::class, ['sendResponse'], [$payload, $client]);
        $command->expects(static::exactly(0))
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('sendResponse');
        $command->processPresenceChange('U12345', 'away');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @test
     * @dataProvider tellDataProvider
     */
    public function processPresenceChangeReturnsCorrectResponseForPresenceActive($message)
    {
        $this->initCommandWithPayload(TellCommand::class, [
            'user' => 'U54321',
            'text' => $message,
        ]);
        $this->command->process();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $loop = $this->getMock(LoopInterface::class);
        $payload = new Payload([
            'user' => 'U12345',
            'presence' => 'active',
        ]);
        $client = $this->getMock(RealTimeClient::class, [], [$loop]);
        /** @var TellCommand|\PHPUnit_Framework_MockObject_MockObject $command */
        $command = $this->getMock(TellCommand::class, ['sendResponse'], [$payload, $client]);
        $command
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->expects(static::exactly(1))
            ->method('sendResponse');
        $command->processPresenceChange('U12345', 'active');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


Push — master ( 191869...afc708 )

TellCommandTest::tearDown() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		/**
3		* T3Bot.
4		*
5		* @author Frank Nägler <[email protected]>
6		*
7		* @link http://www.t3bot.de
8		* @link http://wiki.typo3.org/T3Bot
9		*/
10		namespace T3Bot\Tests\Unit\Commands;
11
12		use Doctrine\DBAL\Configuration;
13		use Doctrine\DBAL\DriverManager;
14		use React\EventLoop\LoopInterface;
15		use Slack\Payload;
16		use Slack\RealTimeClient;
17		use T3Bot\Commands\TellCommand;
18		use T3Bot\Tests\Unit\BaseCommandTestCase;
19
20		/**
21		* Class TellCommandTest.
22		*/
23
24		/** @noinspection LongInheritanceChainInspection */
25		class TellCommandTest extends BaseCommandTestCase
26		{
27		/**
28		*
29		*/
30	View Code Duplication	public function tearDown()
		1 ignored issue – show Duplication introduced 2017-07-22 20:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		DriverManager::getConnection($GLOBALS['config']['db'], new Configuration())
33		->delete('notifications', [
34		'to_user' => 'U12345'
35		]);
36		parent::tearDown();
37		}
38
39		/**
40		* @return array
41		*/
42		public function tellDataProvider() : array
43		{
44		return [
45		'tell <@U12345> about review:47640' => ['tell <@U12345> about review:47640', 'OK, I will tell <@U12345> about your message'],
46		'tell <@U12345> about forge:23456' => ['tell <@U12345> about forge:23456', 'OK, I will tell <@U12345> about your message'],
47		'tell <@U12345> you are so nice' => ['tell <@U12345> you are so nice', 'OK, I will tell <@U12345> about your message'],
48		];
49		}
50
51		/**
52		* @test
53		* @dataProvider tellDataProvider
54		*
55		* @param string $message
56		* @param string $expectedMessage
57		*/
58	View Code Duplication	public function processTellReturnsCorrectResponse($message, $expectedMessage)
		1 ignored issue – show Duplication introduced 2016-04-13 09:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		{
60		$this->initCommandWithPayload(TellCommand::class, [
61		'user' => 'U54321',
62		'text' => $message,
63		]);
64		$result = $this->command->process();
		0 ignored issues – show Bug introduced 2016-07-08 19:19 UTC by Report Bug Copy Issue Report The method `process` does only exist in `T3Bot\Commands\AbstractCommand`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
65		static::assertEquals($expectedMessage, $result);
66		}
67
68		/**
69		* @test
70		*/
71		public function processPresenceChangeReturnsCorrectResponseForPresenceAway()
72		{
73		$loop = $this->getMock(LoopInterface::class);
74		/** @var Payload $payload */
75		$payload = new Payload([
76		'user' => 'U12345',
77		'presence' => 'away',
78		]);
79		/** @var RealTimeClient $client */
80		$client = $this->getMock(RealTimeClient::class, [], [$loop]);
81		/** @var TellCommand\|\PHPUnit_Framework_MockObject_MockObject $command */
82		$command = $this->getMock(TellCommand::class, ['sendResponse'], [$payload, $client]);
83		$command->expects(static::exactly(0))
		0 ignored issues – show Bug introduced 2016-03-28 19:38 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `T3Bot\Commands\TellCommand`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
84		->method('sendResponse');
85		$command->processPresenceChange('U12345', 'away');
		0 ignored issues – show Bug introduced 2016-03-28 19:38 UTC by Report Bug Copy Issue Report The method `processPresenceChange` does only exist in `T3Bot\Commands\TellCommand`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
86		}
87
88		/**
89		* @test
90		* @dataProvider tellDataProvider
91		*/
92		public function processPresenceChangeReturnsCorrectResponseForPresenceActive($message)
93		{
94		$this->initCommandWithPayload(TellCommand::class, [
95		'user' => 'U54321',
96		'text' => $message,
97		]);
98		$this->command->process();
		0 ignored issues – show Bug introduced 2017-07-22 20:44 UTC by Report Bug Copy Issue Report The method `process` does only exist in `T3Bot\Commands\AbstractCommand`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
99
100		$loop = $this->getMock(LoopInterface::class);
101		$payload = new Payload([
102		'user' => 'U12345',
103		'presence' => 'active',
104		]);
105		$client = $this->getMock(RealTimeClient::class, [], [$loop]);
106		/** @var TellCommand\|\PHPUnit_Framework_MockObject_MockObject $command */
107		$command = $this->getMock(TellCommand::class, ['sendResponse'], [$payload, $client]);
108		$command
		0 ignored issues – show Bug introduced 2017-07-22 20:44 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `T3Bot\Commands\TellCommand`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
109		->expects(static::exactly(1))
110		->method('sendResponse');
111		$command->processPresenceChange('U12345', 'active');
		0 ignored issues – show Bug introduced 2016-03-28 19:38 UTC by Report Bug Copy Issue Report The method `processPresenceChange` does only exist in `T3Bot\Commands\TellCommand`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
112		}
113		}
114

NeoBlack / T3Bot

Push — master ( 191869...afc708 )

TellCommandTest::tearDown() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like