AuthServiceTrait::getClientMock() - Code Metrics - Inspection of "Follow google auth" - Nekland/YoutubeApi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

by Maxime

created 2018-08-15 23:06 UTC

AuthServiceTrait::getClientMock() A

↳ Parent: AuthServiceTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0

<?php
/**
 * This file is a part of YoutubeApi package.
 *
 * (c) Nekland <[email protected]>
 *
 * For the full license, take a look to the LICENSE file
 * on the root directory of this project
 */

namespace Nekland\Tests\Http\Auth;


use Guzzle\Http\ClientInterface;
use Guzzle\Http\Message\EntityEnclosingRequestInterface;
use Guzzle\Http\Message\Response;
use Prophecy\Argument;

trait AuthServiceTrait
{
    protected function getClientMock()
    {
        $client = $this->prophesize(ClientInterface::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $request = $this->prophesize(EntityEnclosingRequestInterface::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $response = $this->prophesize(Response::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $response->getBody(Argument::cetera())->willReturn($this->getGoogleResponse());
        $request->send(Argument::any())->shouldBeCalled()->willReturn($response->reveal());
        $client->post(Argument::cetera())->willReturn($request->reveal());

        return $client->reveal();
    }

    protected function getGoogleResponse()
    {
        return '{
    "access_token" : "ya29.1.AADHN_WnGjqYiAcnONRLFDOfXia5XZLFO4RSyEhWtQPAvYpgPYiQj89c7UsrAs5_",
    "token_type" : "Bearer",
    "expires_in" : 3600
}';
    }
}


1			<?php
2			/**
3			* This file is a part of YoutubeApi package.
4			*
5			* (c) Nekland <[email protected]>
6			*
7			* For the full license, take a look to the LICENSE file
8			* on the root directory of this project
9			*/
10
11			namespace Nekland\Tests\Http\Auth;
12
13
14			use Guzzle\Http\ClientInterface;
15			use Guzzle\Http\Message\EntityEnclosingRequestInterface;
16			use Guzzle\Http\Message\Response;
17			use Prophecy\Argument;
18
19			trait AuthServiceTrait
20			{
21			protected function getClientMock()
22			{
23			$client = $this->prophesize(ClientInterface::class);
			0 ignored issues – show Bug introduced 2018-08-15 23:09 UTC by Report Bug Copy Issue Report It seems like `prophesize()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			$request = $this->prophesize(EntityEnclosingRequestInterface::class);
			0 ignored issues – show Bug introduced 2018-08-15 23:09 UTC by Report Bug Copy Issue Report It seems like `prophesize()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25			$response = $this->prophesize(Response::class);
			0 ignored issues – show Bug introduced 2018-08-15 23:09 UTC by Report Bug Copy Issue Report It seems like `prophesize()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26
27			$response->getBody(Argument::cetera())->willReturn($this->getGoogleResponse());
28			$request->send(Argument::any())->shouldBeCalled()->willReturn($response->reveal());
29			$client->post(Argument::cetera())->willReturn($request->reveal());
30
31			return $client->reveal();
32			}
33
34			protected function getGoogleResponse()
35			{
36			return '{
37			"access_token" : "ya29.1.AADHN_WnGjqYiAcnONRLFDOfXia5XZLFO4RSyEhWtQPAvYpgPYiQj89c7UsrAs5_",
38			"token_type" : "Bearer",
39			"expires_in" : 3600
40			}';
41			}
42			}
43

Nekland / YoutubeApi

Pull Request — master (#13)

AuthServiceTrait::getClientMock() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like