Nekland\YoutubeApi\Http\Auth\JsonFileServiceAuth

Complexity

Total Complexity

4

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getIss()	0	6	1
A	getPrivateKey()	0	7	1
A	loadFile()	0	10	2

<?php

/**
 * This file is a part of nekland youtube api package
 *
 * (c) Nekland <nekland.fr@gmail.fr>
 *
 * For the full license, take a look to the LICENSE file
 * on the root directory of this project
 */

namespace Nekland\YoutubeApi\Http\Auth;

/**
 * Class JsonfileServiceAuth
 *
 * Options:
 *      json_file: the path to the json file given by Google
 */
final class JsonFileServiceAuth extends ServiceAuth
{
    /**
     * @var array
     */
    private $json;

    /**
     * {@inheritdoc}
     */
    protected function getIss()
    {
        $this->loadFile();

        return $this->json['client_email'];
    }

    /**
     * @return string
     * @throws \Nekland\YoutubeApi\Exception\AuthException
     */
    protected function getPrivateKey()
    {
        $this->loadFile();

        return $this->json['private_key'];

    }

    /**
     * @return array
     */
    private function loadFile()
    {
        if ($this->json) {

The expression $this->json of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->json;
        }

        $json = file_get_contents($this->getOption('json_file'));

        return $this->json = json_decode($json, true);

It seems like json_decode($json, true) of type * is incompatible with the declared type array of property $json.

    }
}