AbstractConnection - Code Metrics - Inspection of "Woketo Client" - Nekland/Woketo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#100)

by Maxime

created 2017-02-14 00:53 UTC

AbstractConnection A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

33.33%

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	5
dl	0
loc	76
ccs	6
cts	18
cp	0.3333
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
A	onMessage()	16	3
	processHandshake()	1	?
	processMessage()	1	?
A	getIp()	4	1
A	getLogger()	4	1

<?php

/**
 * This file is a part of Woketo package.
 *
 * (c) Nekland <[email protected]>
 *
 * For the full license, take a look to the LICENSE file
 * on the root directory of this project
 */

namespace Nekland\Woketo\Core;

use Nekland\Woketo\Exception\WebsocketException;
use Nekland\Woketo\Message\MessageHandlerInterface;
use Nekland\Woketo\Rfc6455\Handshake\HandshakeInterface;
use Nekland\Woketo\Rfc6455\MessageProcessor;
use Psr\Log\LoggerAwareTrait;
use React\Socket\Connection;

abstract class AbstractConnection
{
    use LoggerAwareTrait;

    /**
     * @var Connection
     */
    protected $stream;

    /**
     * @var MessageProcessor
     */
    protected $messageProcessor;

    /**
     * @var HandshakeInterface
     */
    protected $handshake;

    /**
     * @var bool
     */
    protected $handshakeDone;

    /**
     * @var string
     */
    protected $uri;

    /**
     * @var MessageHandlerInterface|\Closure
     */
    protected $handler;

    public function __construct(MessageProcessor $messageProcessor, HandshakeInterface $handshake = null)
    {
        $this->handshake = $handshake;
        $this->messageProcessor = $messageProcessor;
    }

    protected function onMessage(string $data)
    {
        try {
            if (!$this->handshakeDone) {
                $this->processHandshake($data);
            } else {
                $this->processMessage($data);
            }

            return;
        } catch (WebsocketException $e) {
            $this->messageProcessor->close($this->stream);
            $this->logger->notice('Connection to ' . $this->getIp() . ' closed with error : ' . $e->getMessage());
            $this->handler->onError($e, $this);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }
    }

    protected abstract function processHandshake(string $data);

    protected abstract function processMessage(string $data);


    /**
     * @return string
     */
    public function getIp()
    {
        return $this->stream->getRemoteAddress();
    }

    /**
     * @return \Psr\Log\LoggerInterface
     */
    public function getLogger()
    {
        return $this->logger;
    }
}


1		<?php
2
3		/**
4		* This file is a part of Woketo package.
5		*
6		* (c) Nekland <[email protected]>
7		*
8		* For the full license, take a look to the LICENSE file
9		* on the root directory of this project
10		*/
11
12		namespace Nekland\Woketo\Core;
13
14		use Nekland\Woketo\Exception\WebsocketException;
15		use Nekland\Woketo\Message\MessageHandlerInterface;
16		use Nekland\Woketo\Rfc6455\Handshake\HandshakeInterface;
17		use Nekland\Woketo\Rfc6455\MessageProcessor;
18		use Psr\Log\LoggerAwareTrait;
19		use React\Socket\Connection;
20
21		abstract class AbstractConnection
22		{
23		use LoggerAwareTrait;
24
25		/**
26		* @var Connection
27		*/
28		protected $stream;
29
30		/**
31		* @var MessageProcessor
32		*/
33		protected $messageProcessor;
34
35		/**
36		* @var HandshakeInterface
37		*/
38		protected $handshake;
39
40		/**
41		* @var bool
42		*/
43		protected $handshakeDone;
44
45		/**
46		* @var string
47		*/
48		protected $uri;
49
50		/**
51		* @var MessageHandlerInterface\|\Closure
52		*/
53		protected $handler;
54
55	5	public function __construct(MessageProcessor $messageProcessor, HandshakeInterface $handshake = null)
56		{
57	5	$this->handshake = $handshake;
58	5	$this->messageProcessor = $messageProcessor;
59	5	}
60
61		protected function onMessage(string $data)
62		{
63		try {
64		if (!$this->handshakeDone) {
65		$this->processHandshake($data);
66		} else {
67		$this->processMessage($data);
68		}
69
70		return;
71		} catch (WebsocketException $e) {
72		$this->messageProcessor->close($this->stream);
73		$this->logger->notice('Connection to ' . $this->getIp() . ' closed with error : ' . $e->getMessage());
74		$this->handler->onError($e, $this);
		0 ignored issues – show Bug introduced 2017-02-06 21:29 UTC by Report Bug Copy Issue Report The method `onError` does only exist in `Nekland\Woketo\Message\MessageHandlerInterface`, but not in `Closure`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
75		}
76		}
77
78		protected abstract function processHandshake(string $data);
		0 ignored issues – show Coding Style introduced 2017-01-06 22:26 UTC by Report Bug Copy Issue Report The abstract declaration must precede the visibility declaration Loading history...
79		protected abstract function processMessage(string $data);
		0 ignored issues – show Coding Style introduced 2017-01-06 22:26 UTC by Report Bug Copy Issue Report The abstract declaration must precede the visibility declaration Loading history...
80
81		/**
82		* @return string
83		*/
84		public function getIp()
85		{
86		return $this->stream->getRemoteAddress();
87		}
88
89		/**
90		* @return \Psr\Log\LoggerInterface
91		*/
92	1	public function getLogger()
93		{
94	1	return $this->logger;
95		}
96		}
97

Nekland / Woketo

Pull Request — master (#100)

AbstractConnection A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like