NeXTs / Jets.js

test/test.js

describe('Jets', function() {

  var people = ['John Doe', 'Mike Doe', 'Alex Smith', 'Alice Vazovsky', 'Denis Koen'],
    $search = $('#jetsSearch'),
    searchNode = $search.get(0),
    $content = $('#jetsContent');


  /*
   * Helper functions
   */
  function trigger(ev, _elem) {
    elem = _elem || searchNode

The variable elem seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.elem.

    if ("createEvent" in document) {
        var evt = document.createEvent("HTMLEvents");
        evt.initEvent(ev, false, true);
        elem.dispatchEvent(evt);
    } else elem.fireEvent("on" + ev);

Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

  }

  function ext(options) {
    return $.extend({
      searchTag: '#jetsSearch',
      contentTag: '#jetsContent'
    }, options || {});
  }

  function make(action) {
    action();
    trigger('change');
  }


  /*
   * Mocha helpers
   */ 
  before(function() {
    $content.html($.map(people, function(val, i){
      var reversed = val.split('').reverse().join('');
      return '<tr><td data-custom="' + reversed + '">' + val + '</td><td>' + i + '</td></tr>'
    }).join(''));
  })

  afterEach(function() {
    jet && jet.destroy();

If you intend to check if the variable jet is declared in the current environment, consider using typeof jet === "undefined" instead. This is safe if the variable is not actually declared.

    $search.val('');
    trigger('change', searchNode);
  })

  after(function() {
    jet && jet.destroy();

If you intend to check if the variable jet is declared in the current environment, consider using typeof jet === "undefined" instead. This is safe if the variable is not actually declared.

    $search.val('');
    $content.find('[data-custom]').removeAttr('data-custom');
  })


  /*
  * Specs
  */

  it('Should hide inappropriate rows', function() {
    jet = new Jets(ext({}));

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

    make(function() {
      $search.val(people[0]);
    })
    assert.lengthOf($content.children(':visible'), 1);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

  })

  it('Should show all rows if search query not specified', function() {
    jet = new Jets(ext({}));

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

    make(function() {
      $search.val('');
    })
    assert.lengthOf($content.children(':visible'), people.length);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

  })

  it('Should hide all rows if no suitable results', function() {
    jet = new Jets(ext({}));

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

    make(function() {
      $search.val('404');
    })
    assert.lengthOf($content.children(':visible'), 0);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

  })

  describe('On init', function() {

    it('Shoud add style tag after init', function() {
      jet = new Jets(ext({}));

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

      assert.lengthOf($('head').find(jet.styleTag), 1);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

    it('Should add "data-jets" attribute', function() {
      jet = new Jets(ext({

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

        columns: [0]
      }));
      var $firstRow = $content.children(':first');
      assert.equal($firstRow.attr('data-jets'), $firstRow.children(':first').text().trim().toLowerCase());

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

  })

  describe('On destroy', function() {

    it('Shoud remove style tag after destroy', function() {
      jet = new Jets(ext({}));

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

      jet.destroy();
      assert.lengthOf($('head').find(jet.styleTag), 0);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

    it('Should remove "data-jets" attribute', function() {
      jet = new Jets(ext({}));

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

      jet.destroy()
      assert.isUndefined($content.children(':first').attr('data-jets'));

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })
    
  })

  describe('Columns option', function() {
    
    it('Should search by any column', function() {
      jet = new Jets(ext({}));

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

      make(function() {
        $search.val('1');
      })
      assert.lengthOf($content.children(':visible'), 1);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

    it('Should find one row by first column', function() {
      jet = new Jets(ext({

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

        columns: [0]
      }));
      make(function() {
        $search.val(people[0]);
      })
      assert.lengthOf($content.children(':visible'), 1);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

    it('Should avoid second column', function() {
      jet = new Jets(ext({

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

        columns: [0]
      }));
      make(function() {
        $search.val('1');
      })
      assert.lengthOf($content.children(':visible'), 0);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })
    
  })

  describe('addImportant option', function() {

    it('Should avoid !important by default', function() {
      jet = new Jets(ext({}));

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

      make(function() {
        $search.val(people[0]);
      })
      assert.notInclude($(jet.styleTag).html(), '!important');

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

    it('Should add !important', function() {
      jet = new Jets(ext({

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

        addImportant: true
      }));
      make(function() {
        $search.val(people[0]);
      })
      assert.include($(jet.styleTag).html(), '!important');

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

  })

  describe('searchSelector option', function() {

    function execute(selector) {
      it('Should use custom selector: ' + selector, function() {
        jet = new Jets(ext({

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

          searchSelector: selector
        }));
        make(function() {
          $search.val(people[0]);
        })
        assert.include($(jet.styleTag).html(), selector);  

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

      })
    }

    var selectors = ['^', '$', '~', '|'];
    for(var i = 0, ii = selectors.length; i < ii; i++) {
      execute(selectors[i]);
    }

    it('Should find one result with * selector', function() {

      jet = new Jets(ext({

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

        searchSelector: '*'
      }));
      make(function() {
        $search.val('John Doe');
      })
      assert.lengthOf($content.children(':visible'), 1);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

    it('Should hide all results with * selector and mixed words', function() {

      jet = new Jets(ext({

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

        searchSelector: '*'
      }));
      make(function() {
        $search.val('Doe John');
      })
      assert.lengthOf($content.children(':visible'), 0);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

    it('Should find one result with *AND selector and mixed words', function() {

      jet = new Jets(ext({

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

        searchSelector: '*AND'
      }));
      make(function() {
        $search.val('Doe John');
      })
      assert.lengthOf($content.children(':visible'), 1);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

    it('Should find one result with *AND selector and part of word', function() {

      jet = new Jets(ext({

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

        searchSelector: '*AND'
      }));
      make(function() {
        $search.val('John oe');
      })
      assert.lengthOf($content.children(':visible'), 1);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

    it('Should find three results with *OR selector and part of word', function() {

      jet = new Jets(ext({

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

        searchSelector: '*OR'
      }));
      make(function() {
        $search.val('John oe');
      })
      assert.lengthOf($content.children(':visible'), 3);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

  })

  describe('manualContentHandling option', function() {

    it('Should fetch content by custom rule', function() {
      jet = new Jets(ext({

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

        manualContentHandling: function(tag) {
          return $(tag).children(0).attr('data-custom')
        }
      }));
      make(function() {
        $search.val(people[0].split('').reverse().join(''));
      })
      assert.lengthOf($content.children(':visible'), 1);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

  })

  describe('invert option', function() {

    it('Should invert results', function() {
      jet = new Jets(ext({

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

        invert: true
      }));
      make(function() {
        $search.val(people[0]);
      })
      assert.lengthOf($content.children(':visible'), 3);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

  })

  describe('callSearchManually option', function() {

    it('Should not call search on typing', function() {
      jet = new Jets(ext({

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

        callSearchManually: true
      }));
      make(function() {
        $search.val(people[0]);
      })
      assert.lengthOf($content.children(':visible'), 5);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

    it('Should call search by manual calling .search', function() {
      jet = new Jets(ext({

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

        callSearchManually: true
      }));
      make(function() {
        $search.val(people[0]);
      })
      jet.search();
      assert.lengthOf($content.children(':visible'), 1);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

    it('Should call search by manual calling .search with search phrase as attribute', function() {
      jet = new Jets(ext({

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

        callSearchManually: true
      }));
      jet.search(people[0]);
      assert.lengthOf($content.children(':visible'), 1);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

  })

  describe('searchInSpecificColumn option', function() {

    it('Should search in specific column', function() {
      // duplicate data in columns (in reversed order)
      $content.html($.map(people, function(val, i){
        var reversed = val.split('').reverse().join('');

The variable reversed seems to be never used. Consider removing it.

        return '<tr><td>' + val + '</td><td>' + people[people.length - i - 1] + '</td></tr>'
      }).join(''));
      jet = new Jets(ext({

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

        callSearchManually: true,
        searchInSpecificColumn: true
      }));
      make(function() {
        jet.search(people[0], 0);
      })
      assert.lengthOf($content.children(':visible'), 1);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

    it('Should search in all column in column not specified', function() {
      // duplicate data in columns (in reversed order)
      $content.html($.map(people, function(val, i){
        var reversed = val.split('').reverse().join('');

The variable reversed seems to be never used. Consider removing it.

        return '<tr><td>' + val + '</td><td>' + people[people.length - i - 1] + '</td></tr>'
      }).join(''));
      jet = new Jets(ext({

The variable Jets seems to be never declared. If this is a global, consider adding a /** global: Jets */ comment.

The variable jet seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.jet.

        callSearchManually: true,
        searchInSpecificColumn: true
      }));
      make(function() {
        jet.search(people[0]);
      })
      assert.lengthOf($content.children(':visible'), 2);

The variable assert seems to be never declared. If this is a global, consider adding a /** global: assert */ comment.

    })

  })

})