Review::__construct() - Code Metrics - Inspection of "updated travis badge" - Ne-Lexa/google-play-scraper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (45165d)

by Alexey

created 2019-05-28 07:24 UTC

Review::__construct() A

↳ Parent: Review

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	9
dl	0
loc	20
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	9

How to fix Many Parameters

<?php
declare(strict_types=1);

namespace Nelexa\GPlay\Model;

class Review
{
    /**
     * @var string
     */
    private $id;
    /**
     * @var string
     */
    private $url;
    /**
     * @var string
     */
    private $userName;
    /**
     * @var string
     */
    private $text;
    /**
     * @var GoogleImage
     */
    private $avatar;
    /**
     * @var \DateTimeInterface
     */
    private $date;
    /**
     * @var int
     */
    private $score;
    /**
     * @var int
     */
    private $likeCount;
    /**
     * @var ReplyReview|null
     */
    private $reply;

    /**
     * Review constructor.
     *
     * @param string $id
     * @param string $url
     * @param string $userName
     * @param string $text
     * @param GoogleImage $avatar
     * @param \DateTimeInterface $date
     * @param int $score
     * @param int $likeCount
     * @param ReplyReview|null $reply
     */
    public function __construct(
        string $id,
        string $url,
        string $userName,
        string $text,
        GoogleImage $avatar,
        \DateTimeInterface $date,
        int $score,
        int $likeCount = 0,
        ?ReplyReview $reply = null
    ) {
        $this->id = $id;
        $this->url = $url;
        $this->userName = $userName;
        $this->text = $text;
        $this->avatar = $avatar;
        $this->date = $date;
        $this->score = $score;
        $this->likeCount = $likeCount;
        $this->reply = $reply;
    }

    /**
     * @return string
     */
    public function getId(): string
    {
        return $this->id;
    }

    /**
     * @return string
     */
    public function getUrl(): string
    {
        return $this->url;
    }

    /**
     * @return string
     */
    public function getUserName(): string
    {
        return $this->userName;
    }

    /**
     * @return string
     */
    public function getText(): string
    {
        return $this->text;
    }

    /**
     * @return GoogleImage
     */
    public function getAvatar(): GoogleImage
    {
        return $this->avatar;
    }

    /**
     * @return \DateTimeInterface
     */
    public function getDate(): \DateTimeInterface
    {
        return $this->date;
    }

    /**
     * @return int
     */
    public function getScore(): int
    {
        return $this->score;
    }

    /**
     * @return int
     */
    public function getLikeCount(): int
    {
        return $this->likeCount;
    }

    /**
     * @return ReplyReview|null
     */
    public function getReply(): ?ReplyReview
    {
        return $this->reply;
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace Nelexa\GPlay\Model;
5
6			class Review
7			{
8			/**
9			* @var string
10			*/
11			private $id;
12			/**
13			* @var string
14			*/
15			private $url;
16			/**
17			* @var string
18			*/
19			private $userName;
20			/**
21			* @var string
22			*/
23			private $text;
24			/**
25			* @var GoogleImage
26			*/
27			private $avatar;
28			/**
29			* @var \DateTimeInterface
30			*/
31			private $date;
32			/**
33			* @var int
34			*/
35			private $score;
36			/**
37			* @var int
38			*/
39			private $likeCount;
40			/**
41			* @var ReplyReview\|null
42			*/
43			private $reply;
44
45			/**
46			* Review constructor.
47			*
48			* @param string $id
49			* @param string $url
50			* @param string $userName
51			* @param string $text
52			* @param GoogleImage $avatar
53			* @param \DateTimeInterface $date
54			* @param int $score
55			* @param int $likeCount
56			* @param ReplyReview\|null $reply
57			*/
58			public function __construct(
59			string $id,
60			string $url,
61			string $userName,
62			string $text,
63			GoogleImage $avatar,
64			\DateTimeInterface $date,
65			int $score,
66			int $likeCount = 0,
67			?ReplyReview $reply = null
68			) {
69			$this->id = $id;
70			$this->url = $url;
71			$this->userName = $userName;
72			$this->text = $text;
73			$this->avatar = $avatar;
74			$this->date = $date;
75			$this->score = $score;
76			$this->likeCount = $likeCount;
77			$this->reply = $reply;
78			}
79
80			/**
81			* @return string
82			*/
83			public function getId(): string
84			{
85			return $this->id;
86			}
87
88			/**
89			* @return string
90			*/
91			public function getUrl(): string
92			{
93			return $this->url;
94			}
95
96			/**
97			* @return string
98			*/
99			public function getUserName(): string
100			{
101			return $this->userName;
102			}
103
104			/**
105			* @return string
106			*/
107			public function getText(): string
108			{
109			return $this->text;
110			}
111
112			/**
113			* @return GoogleImage
114			*/
115			public function getAvatar(): GoogleImage
116			{
117			return $this->avatar;
118			}
119
120			/**
121			* @return \DateTimeInterface
122			*/
123			public function getDate(): \DateTimeInterface
124			{
125			return $this->date;
126			}
127
128			/**
129			* @return int
130			*/
131			public function getScore(): int
132			{
133			return $this->score;
134			}
135
136			/**
137			* @return int
138			*/
139			public function getLikeCount(): int
140			{
141			return $this->likeCount;
142			}
143
144			/**
145			* @return ReplyReview\|null
146			*/
147			public function getReply(): ?ReplyReview
148			{
149			return $this->reply;
150			}
151			}
152

Ne-Lexa / google-play-scraper

Branch — develop (45165d)

Review::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like