ReviewsScraper::__construct() - Code Metrics - Inspection of "refactoring" - Ne-Lexa/google-play-scraper - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (61f351)

by Alexey

created 2019-05-29 20:38 UTC

ReviewsScraper::__construct() A

↳ Parent: ReviewsScraper

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php
declare(strict_types=1);

namespace Nelexa\GPlay\Scraper;

use Nelexa\GPlay\Http\ResponseHandlerInterface;
use Nelexa\GPlay\Request\RequestApp;
use Nelexa\GPlay\Scraper\Extractor\ReviewsExtractor;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

class ReviewsScraper implements ResponseHandlerInterface
{
    /**
     * @var RequestApp
     */
    private $requestApp;

    /**
     * ReviewsScraper constructor.
     *
     * @param RequestApp $requestApp
     */
    public function __construct(RequestApp $requestApp)
    {
        $this->requestApp = $requestApp;
    }

    /**
     * @param RequestInterface $request
     * @param ResponseInterface $response
     * @return array
     */
    public function __invoke(RequestInterface $request, ResponseInterface $response)
    {
        $contents = substr($response->getBody()->getContents(), 5);
        $json = \GuzzleHttp\json_decode($contents, true);
        if (!isset($json[0][2])) {
            return [[], null];
        }
        $json = \GuzzleHttp\json_decode($json[0][2], true);

        if (empty($json[0])) {
            return [[], null];
        }
        $reviews = ReviewsExtractor::extractReviews($this->requestApp, $json[0]);
        $nextToken = $json[1][1] ?? null;
        return [$reviews, $nextToken];
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace Nelexa\GPlay\Scraper;
5
6			use Nelexa\GPlay\Http\ResponseHandlerInterface;
7			use Nelexa\GPlay\Request\RequestApp;
8			use Nelexa\GPlay\Scraper\Extractor\ReviewsExtractor;
9			use Psr\Http\Message\RequestInterface;
10			use Psr\Http\Message\ResponseInterface;
11
12			class ReviewsScraper implements ResponseHandlerInterface
13			{
14			/**
15			* @var RequestApp
16			*/
17			private $requestApp;
18
19			/**
20			* ReviewsScraper constructor.
21			*
22			* @param RequestApp $requestApp
23			*/
24			public function __construct(RequestApp $requestApp)
25			{
26			$this->requestApp = $requestApp;
27			}
28
29			/**
30			* @param RequestInterface $request
31			* @param ResponseInterface $response
32			* @return array
33			*/
34			public function __invoke(RequestInterface $request, ResponseInterface $response)
35			{
36			$contents = substr($response->getBody()->getContents(), 5);
37			$json = \GuzzleHttp\json_decode($contents, true);
38			if (!isset($json[0][2])) {
39			return [[], null];
40			}
41			$json = \GuzzleHttp\json_decode($json[0][2], true);
42
43			if (empty($json[0])) {
44			return [[], null];
45			}
46			$reviews = ReviewsExtractor::extractReviews($this->requestApp, $json[0]);
47			$nextToken = $json[1][1] ?? null;
48			return [$reviews, $nextToken];
49			}
50			}
51

Ne-Lexa / google-play-scraper

Branch — develop (61f351)

ReviewsScraper::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like