FindSimilarAppsUrlScraper::__invoke() - Code Metrics - Inspection of "refactoring" - Ne-Lexa/google-play-scraper - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (61f351)

by Alexey

created 2019-05-29 20:38 UTC

FindSimilarAppsUrlScraper::__invoke() A

↳ Parent: FindSimilarAppsUrlScraper

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	8
nc	3
nop	2
dl	0
loc	12
rs	10
c	0
b	0
f	0

<?php
declare(strict_types=1);

namespace Nelexa\GPlay\Scraper;

use Nelexa\GPlay\GPlayApps;
use Nelexa\GPlay\Http\ResponseHandlerInterface;
use Nelexa\GPlay\Request\RequestApp;
use Nelexa\GPlay\Util\ScraperUtil;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

class FindSimilarAppsUrlScraper implements ResponseHandlerInterface
{
    /**
     * @var RequestApp
     */
    private $requestApp;

    /**
     * SimilarScraper constructor.
     *
     * @param RequestApp $requestApp
     */
    public function __construct(RequestApp $requestApp)
    {
        $this->requestApp = $requestApp;
    }

    /**
     * @param RequestInterface $request
     * @param ResponseInterface $response
     * @return string|null
     */
    public function __invoke(RequestInterface $request, ResponseInterface $response): ?string
    {
        $scriptData = ScraperUtil::extractScriptData($response->getBody()->getContents());
        foreach ($scriptData as $key => $scriptValue) {
            if (isset($scriptValue[1][1][0][0][3][4][2])) {
                return GPlayApps::GOOGLE_PLAY_URL . $scriptValue[1][1][0][0][3][4][2] .
                    '&' . GPlayApps::REQ_PARAM_LOCALE . '=' . urlencode($this->requestApp->getLocale()) .
                    '&' . GPlayApps::REQ_PARAM_COUNTRY . '=' . urlencode($this->requestApp->getCountry());
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            }
        }
        return null;
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace Nelexa\GPlay\Scraper;
5
6			use Nelexa\GPlay\GPlayApps;
7			use Nelexa\GPlay\Http\ResponseHandlerInterface;
8			use Nelexa\GPlay\Request\RequestApp;
9			use Nelexa\GPlay\Util\ScraperUtil;
10			use Psr\Http\Message\RequestInterface;
11			use Psr\Http\Message\ResponseInterface;
12
13			class FindSimilarAppsUrlScraper implements ResponseHandlerInterface
14			{
15			/**
16			* @var RequestApp
17			*/
18			private $requestApp;
19
20			/**
21			* SimilarScraper constructor.
22			*
23			* @param RequestApp $requestApp
24			*/
25			public function __construct(RequestApp $requestApp)
26			{
27			$this->requestApp = $requestApp;
28			}
29
30			/**
31			* @param RequestInterface $request
32			* @param ResponseInterface $response
33			* @return string\|null
34			*/
35			public function __invoke(RequestInterface $request, ResponseInterface $response): ?string
36			{
37			$scriptData = ScraperUtil::extractScriptData($response->getBody()->getContents());
38			foreach ($scriptData as $key => $scriptValue) {
39			if (isset($scriptValue[1][1][0][0][3][4][2])) {
40			return GPlayApps::GOOGLE_PLAY_URL . $scriptValue[1][1][0][0][3][4][2] .
41			'&' . GPlayApps::REQ_PARAM_LOCALE . '=' . urlencode($this->requestApp->getLocale()) .
42			'&' . GPlayApps::REQ_PARAM_COUNTRY . '=' . urlencode($this->requestApp->getCountry());
43			break;
			0 ignored issues – show Unused Code introduced 2019-05-29 20:40 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
44			}
45			}
46			return null;
47			}
48			}
49

Ne-Lexa / google-play-scraper

Branch — develop (61f351)

FindSimilarAppsUrlScraper::__invoke() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like