AppsExtractor::extractDeveloper() - Code Metrics - Inspection of "refactoring" - Ne-Lexa/google-play-scraper - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (61f351)

by Alexey

created 2019-05-29 20:38 UTC

AppsExtractor::extractDeveloper() A

↳ Parent: AppsExtractor

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	9
nc	1
nop	1
dl	0
loc	12
rs	9.9666
c	0
b	0
f	0

<?php
declare(strict_types=1);

namespace Nelexa\GPlay\Scraper\Extractor;

use Nelexa\GPlay\GPlayApps;
use Nelexa\GPlay\Model\App;
use Nelexa\GPlay\Model\Developer;
use Nelexa\GPlay\Model\GoogleImage;
use function GuzzleHttp\Psr7\parse_query;

class AppsExtractor
{
    /**
     * @param array $data
     * @param string $locale
     * @return App
     */
    public static function extractApp(array $data, string $locale): App
    {
        $name = $data[2];
        $appId = $data[12][0];
        $url = GPlayApps::GOOGLE_PLAY_URL . $data[9][4][2];
        $icon = new GoogleImage($data[1][1][0][3][2]);
        $developer = self::extractDeveloper($data);
        $price = $data[7][0][3][2][1][0][2];
        $summary = $data[4][1][1][1][1];
        $score = $data[6][0][2][1][1];

        return new App(
            App::newBuilder()
                ->setId($appId)
                ->setUrl($url)
                ->setLocale($locale)
                ->setName($name)
                ->setSummary($summary)
                ->setDeveloper($developer)
                ->setIcon($icon)
                ->setScore($score)
                ->setPriceText($price)
        );
    }

    /**
     * @param array $data
     * @return Developer
     */
    private static function extractDeveloper(array $data): Developer
    {
        $developerName = $data[4][0][0][0];
        $developerPage = GPlayApps::GOOGLE_PLAY_URL . $data[4][0][0][1][4][2];
        $developerId = parse_query(parse_url($developerPage, PHP_URL_QUERY))[GPlayApps::REQ_PARAM_ID];
        $developer = new Developer(
            Developer::newBuilder()
                ->setId($developerId)
                ->setUrl($developerPage)
                ->setName($developerName)
        );
        return $developer;
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace Nelexa\GPlay\Scraper\Extractor;
5
6			use Nelexa\GPlay\GPlayApps;
7			use Nelexa\GPlay\Model\App;
8			use Nelexa\GPlay\Model\Developer;
9			use Nelexa\GPlay\Model\GoogleImage;
10			use function GuzzleHttp\Psr7\parse_query;
11
12			class AppsExtractor
13			{
14			/**
15			* @param array $data
16			* @param string $locale
17			* @return App
18			*/
19			public static function extractApp(array $data, string $locale): App
20			{
21			$name = $data[2];
22			$appId = $data[12][0];
23			$url = GPlayApps::GOOGLE_PLAY_URL . $data[9][4][2];
24			$icon = new GoogleImage($data[1][1][0][3][2]);
25			$developer = self::extractDeveloper($data);
26			$price = $data[7][0][3][2][1][0][2];
27			$summary = $data[4][1][1][1][1];
28			$score = $data[6][0][2][1][1];
29
30			return new App(
31			App::newBuilder()
32			->setId($appId)
33			->setUrl($url)
34			->setLocale($locale)
35			->setName($name)
36			->setSummary($summary)
37			->setDeveloper($developer)
38			->setIcon($icon)
39			->setScore($score)
40			->setPriceText($price)
41			);
42			}
43
44			/**
45			* @param array $data
46			* @return Developer
47			*/
48			private static function extractDeveloper(array $data): Developer
49			{
50			$developerName = $data[4][0][0][0];
51			$developerPage = GPlayApps::GOOGLE_PLAY_URL . $data[4][0][0][1][4][2];
52			$developerId = parse_query(parse_url($developerPage, PHP_URL_QUERY))[GPlayApps::REQ_PARAM_ID];
53			$developer = new Developer(
54			Developer::newBuilder()
55			->setId($developerId)
56			->setUrl($developerPage)
57			->setName($developerName)
58			);
59			return $developer;
60			}
61			}
62

Ne-Lexa / google-play-scraper

Branch — develop (61f351)

AppsExtractor::extractDeveloper() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like