Ne-Lexa / RequestDtoBundle

src/ArgumentResolver/RequestDtoValueResolver.php

<?php

declare(strict_types=1);

namespace Nelexa\RequestDtoBundle\ArgumentResolver;

use Nelexa\RequestDtoBundle\Dto\RequestDtoInterface;
use Nelexa\RequestDtoBundle\Transform\RequestDtoTransform;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface;
use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadata;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\Serializer\Exception\NotEncodableValueException;
use Symfony\Component\Validator\Validator\ValidatorInterface;

final class RequestDtoValueResolver implements ArgumentValueResolverInterface
{
    private RequestDtoTransform $transformer;

    private ValidatorInterface $validator;

    public function __construct(RequestDtoTransform $transformer, ValidatorInterface $validator)
    {
        $this->transformer = $transformer;
        $this->validator = $validator;
    }

    public function supports(Request $request, ArgumentMetadata $argument): bool
    {
        return is_a($argument->getType(), RequestDtoInterface::class, true);
    }

    private function getSerializeFormat(Request $request): string
    {
        static $supportFormats = ['json', 'xml'];
        static $defaultFormat = 'json';

        $format = $request->getContentType() ?? $defaultFormat;

        if (!\in_array($format, $supportFormats, true)) {
            $format = $defaultFormat;
        }

        return $format;
    }

    /**
     * @return iterable
     */
    public function resolve(Request $request, ArgumentMetadata $argument)
    {
        $format = $this->getSerializeFormat($request);

        try {
            $obj = $this->transformer->transform($request, $argument->getType(), $format);

It seems like $argument->getType() can also be of type null; however, parameter $className of Nelexa\RequestDtoBundle\Transform\RequestDtoTransform::transform() does only seem to accept string, maybe add an additional type check?

        } catch (\TypeError | NotEncodableValueException $e) {
            $problemMimeType = 'application/problem+' . $format;

            throw new HttpException(
                400,
                'Bad Request',
                $e,
                [
                    'Content-Type' => $problemMimeType,
                ]
            );
        }

        $request->attributes->set(
            ConstraintViolationListValueResolver::REQUEST_ATTR_KEY,
            $this->validator->validate($obj)
        );

        yield $obj;
    }
}